From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id E65D66E0BE for ; Thu, 25 Oct 2018 12:51:51 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id p3-v6so5580055qkb.5 for ; Thu, 25 Oct 2018 05:51:51 -0700 (PDT) Date: Thu, 25 Oct 2018 08:51:49 -0400 From: Sean Paul Message-ID: <20181025125149.GG154160@art_vandelay> References: <20181019085049.25482-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181019085049.25482-1-daniel.vetter@ffwll.ch> Subject: Re: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory? List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter Cc: IGT development , Intel Graphics Development , amd-gfx@lists.freedesktop.org, DRI Development List-ID: T24gRnJpLCBPY3QgMTksIDIwMTggYXQgMTA6NTA6NDlBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBIaSBhbGwsCj4gCj4gVGhpcyBpcyBqdXN0IHRvIGNvbGxlY3QgZmVlZGJhY2sgb24g dGhpcyBpZGVhLCBhbmQgc2VlIHdoZXRoZXIgdGhlCj4gb3ZlcmFsbCBkcmktZGV2ZWwgY29tbXVu aXR5IHN0YW5kcyBvbiBhbGwgdGhpcy4gSSB0aGluayB0aGUgcGFzdCBmZXcKPiBjcm9zcy12ZW5k b3IgdWFwaSBleHRlbnNpb25zIGFsbCBjYW1lIHdpdGggaWd0cyBhdHRhY2hlZCwgYW5kCj4gcGVy c29uYWxseSBJIHRoaW5rIHRoZXJlJ3MgbG90cyBvZiB2YWx1ZSBpbiBoYXZpbmcgdGhlbTogQQo+ IGNyb3NzLXZlbmRvciBpbnRlcmZhY2UgaXNuJ3QgdXNlZnVsIGlmIGV2ZXJ5IGRyaXZlciBpbXBs ZW1lbnRzIGl0Cj4gc2xpZ2h0bHkgZGlmZmVyZW50bHkuCj4gCj4gSSB0aGluayB0aGVyZSdzIDIg cXVlc3Rpb25zIGhlcmU6Cj4gCj4gLSBEbyB3ZSB3YW50IHRvIG1ha2Ugc3VjaCB0ZXN0Y2FzZXMg bWFuZGF0b3J5Pwo+IAoKWWVzLCBtb3JlIHRlc3RpbmcgPT0gYmV0dGVyIGNvZGUuCgoKPiAtIElm IHllcywgYXJlIHdlIHRoZXJlIHlldCwgb3IgaXMgdGhlcmUgc29tZXRoaW5nIGNydWNpYWxseSBt aXNzaW5nCj4gICBzdGlsbD8KCkluIG15IGV4cGVyaWVuY2UsIG5vLiBMYXN0IHdlZWsgd2hpbGUg dHJ5aW5nIHRvIHJlcGxpY2F0ZSBhbiBpbnRlbC1nZnggQ0kKZmFpbHVyZSwgSSB0cmllZCBjb21w aWxpbmcgaWd0IGZvciBvbmUgb2YgbXkgKGludGVsKSBjaHJvbWVib29rcy4gSXQgc2VlbXMgbGlr ZQpjcm9zcy1jb21waWxhdGlvbiAob3IsIGluIG15IGNhc2UsIGp1c3Qgc3BlY2lmeWluZwpwcmVm aXgvbGRfbGlicmFyeV9wYXRoL3NiaW5fcGF0aCkgaXMgYnJva2VuIG9uIGlndC4gSWYgd2Ugd2Fu dCB0byBpbXBvc2UKcmVzdHJpY3Rpb25zIGFjcm9zcyB0aGUgZW50aXJlIHN1YnN5c3RlbSwgd2Ug bmVlZCB0byBtYWtlIHN1cmUgdGhhdCBldmVyeW9uZSBjYW4KYnVpbGQgYW5kIGRlcGxveSBpZ3Qg ZWFzaWx5LgoKSSBtYW5hZ2VkIHRvIGhhY2sgYXJvdW5kIGV2ZXJ5dGhpbmcgYW5kIGdldCBpdCB3 b3JraW5nLCBidXQgSSBzdGlsbCBoYXZlbid0CnRyaWVkIHN3aXRjaGluZyBvdXQgdGhlIHRvb2xj aGFpbi4gT25jZSB3ZSBoYXZlIHNvbWUgR2l0TGFiIENJIHRvIHZhbGlkYXRlCmNyb3NzLWNvbXBp bGF0aW9uLCB0aGVuIHdlIGNhbiBjb25zaWRlciBtYWtpbmcgSUdUIG1hbmRhdG9yeS4KCkl0J3Mg cG9zc2libGUgdGhhdCBJJ20ganVzdCBhIG1lc29uIG4wMGIgYW5kIGRpZG4ndCB1c2UgdGhlIHJp Z2h0IGluY2FudGF0aW9uLApzbyBtYXliZSBpdCBhbHJlYWR5IHdvcmtzLCBidXQgdGhlbiB3ZSBu ZWVkIGJldHRlciBkb2N1bWVudGF0aW9uLgoKSSd2ZSBwYXN0ZWQgbXkgaG9ycmlibGUgaGFja3Mg YmVsb3csIEkgYWxzbyBkaWRuJ3QgaGF2ZSBsaWJ1bndpbmQsIHNvIHJlbW92ZWQKaXRzIHVzYWdl LgoKU2VhbgoKCi9zbmlwCgoKRnJvbSBhYjhjN2QyNzRjMzI1NTkyOTViMzhkNmNlZWFhYmRlZDE0 YjIwN2Q0IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTZWFuIFBhdWwgPHNlYW5wYXVs QGNocm9taXVtLm9yZz4KRGF0ZTogVGh1LCAyNSBPY3QgMjAxOCAwODo0MDoyOCAtMDQwMApTdWJq ZWN0OiBbUEFUQ0hdIGlndDogSGFja3MgdG8gY29tcGlsZSBpbiBDck9TIGNocm9vdAoKU2lnbmVk LW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Ci0tLQogbGliL2lndF9j b3JlLmMgICAgICAgICAgICB8IDc4IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogbGliL21lc29uLmJ1aWxkICAgICAgICAgICB8ICAxIC0KIG1lc29uLmJ1aWxkICAgICAg ICAgICAgICAgfCAgNCArLQogdGVzdHMvZ2VtX3VzZXJwdHJfYmxpdHMuYyB8ICAyICsKIHRvb2xz L21lc29uLmJ1aWxkICAgICAgICAgfCAgNyAtLS0tCiA1IGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0 aW9ucygrKSwgODcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGliL2lndF9jb3JlLmMgYi9s aWIvaWd0X2NvcmUuYwppbmRleCAyM2JiODU4Zi4uY2E2NWQ3Y2MgMTAwNjQ0Ci0tLSBhL2xpYi9p Z3RfY29yZS5jCisrKyBiL2xpYi9pZ3RfY29yZS5jCkBAIC03MSw4ICs3MSw2IEBACiAjaW5jbHVk ZSAiaWd0X3N5c3JxLmgiCiAjaW5jbHVkZSAiaWd0X3JjLmgiCiAKLSNkZWZpbmUgVU5XX0xPQ0FM X09OTFkKLSNpbmNsdWRlIDxsaWJ1bndpbmQuaD4KICNpbmNsdWRlIDxlbGZ1dGlscy9saWJkd2Zs Lmg+CiAKICNpZmRlZiBIQVZFX0xJQkdFTl9ICkBAIC0xMjA5LDYzICsxMjA3LDYgQEAgc3RhdGlj IHZvaWQgd3JpdGVfc3RkZXJyKGNvbnN0IGNoYXIgKnN0cikKIAogc3RhdGljIHZvaWQgcHJpbnRf YmFja3RyYWNlKHZvaWQpCiB7Ci0JdW53X2N1cnNvcl90IGN1cnNvcjsKLQl1bndfY29udGV4dF90 IHVjOwotCWludCBzdGFja19udW0gPSAwOwotCi0JRHdmbF9DYWxsYmFja3MgY2JzID0gewotCQku ZmluZF9lbGYgPSBkd2ZsX2xpbnV4X3Byb2NfZmluZF9lbGYsCi0JCS5maW5kX2RlYnVnaW5mbyA9 IGR3Zmxfc3RhbmRhcmRfZmluZF9kZWJ1Z2luZm8sCi0JfTsKLQotCUR3ZmwgKmR3ZmwgPSBkd2Zs X2JlZ2luKCZjYnMpOwotCi0JaWYgKGR3ZmxfbGludXhfcHJvY19yZXBvcnQoZHdmbCwgZ2V0cGlk KCkpKSB7Ci0JCWR3ZmxfZW5kKGR3ZmwpOwotCQlkd2ZsID0gTlVMTDsKLQl9IGVsc2UKLQkJZHdm bF9yZXBvcnRfZW5kKGR3ZmwsIE5VTEwsIE5VTEwpOwotCi0JaWd0X2luZm8oIlN0YWNrIHRyYWNl OlxuIik7Ci0KLQl1bndfZ2V0Y29udGV4dCgmdWMpOwotCXVud19pbml0X2xvY2FsKCZjdXJzb3Is ICZ1Yyk7Ci0Jd2hpbGUgKHVud19zdGVwKCZjdXJzb3IpID4gMCkgewotCQljaGFyIG5hbWVbMjU1 XTsKLQkJdW53X3dvcmRfdCBvZmYsIGlwOwotCQlEd2ZsX01vZHVsZSAqbW9kID0gTlVMTDsKLQot CQl1bndfZ2V0X3JlZygmY3Vyc29yLCBVTldfUkVHX0lQLCAmaXApOwotCi0JCWlmIChkd2ZsKQot CQkJbW9kID0gZHdmbF9hZGRybW9kdWxlKGR3ZmwsIGlwKTsKLQotCQlpZiAobW9kKSB7Ci0JCQlj b25zdCBjaGFyICpzcmMsICpkd2ZsX25hbWU7Ci0JCQlEd2ZsX0xpbmUgKmxpbmU7Ci0JCQlpbnQg bGluZW5vOwotCQkJR0VsZl9TeW0gc3ltOwotCi0JCQlsaW5lID0gZHdmbF9tb2R1bGVfZ2V0c3Jj KG1vZCwgaXApOwotCQkJZHdmbF9uYW1lID0gZHdmbF9tb2R1bGVfYWRkcnN5bShtb2QsIGlwLCAm c3ltLCBOVUxMKTsKLQotCQkJaWYgKGxpbmUgJiYgZHdmbF9uYW1lKSB7Ci0JCQkJc3JjID0gZHdm bF9saW5laW5mbyhsaW5lLCBOVUxMLCAmbGluZW5vLCBOVUxMLCBOVUxMLCBOVUxMKTsKLQkJCQlp Z3RfaW5mbygiICAjJWQgJXM6JWQgJXMoKVxuIiwgc3RhY2tfbnVtKyssIHNyYywgbGluZW5vLCBk d2ZsX25hbWUpOwotCQkJCWNvbnRpbnVlOwotCQkJfQotCQl9Ci0KLQkJaWYgKHVud19nZXRfcHJv Y19uYW1lKCZjdXJzb3IsIG5hbWUsIDI1NSwgJm9mZikgPCAwKQotCQkJaWd0X2luZm8oIiAgIyVk IFs8dW5rbm93bj4rMHgleF1cbiIsIHN0YWNrX251bSsrLAotCQkJCSAodW5zaWduZWQgaW50KSBp cCk7Ci0JCWVsc2UKLQkJCWlndF9pbmZvKCIgICMlZCBbJXMrMHgleF1cbiIsIHN0YWNrX251bSsr LCBuYW1lLAotCQkJCSAodW5zaWduZWQgaW50KSBvZmYpOwotCX0KLQotCWlmIChkd2ZsKQotCQlk d2ZsX2VuZChkd2ZsKTsKIH0KIAogc3RhdGljIGNvbnN0IGNoYXIgaGV4W10gPSAiMDEyMzQ1Njc4 OWFiY2RlZiI7CkBAIC0xNDIwLDI1ICsxMzYxLDYgQEAgeHByaW50Zihjb25zdCBjaGFyICpmbXQs IC4uLikKIAogc3RhdGljIHZvaWQgcHJpbnRfYmFja3RyYWNlX3NpZ19zYWZlKHZvaWQpCiB7Ci0J dW53X2N1cnNvcl90IGN1cnNvcjsKLQl1bndfY29udGV4dF90IHVjOwotCWludCBzdGFja19udW0g PSAwOwotCi0Jd3JpdGVfc3RkZXJyKCJTdGFjayB0cmFjZTogXG4iKTsKLQotCXVud19nZXRjb250 ZXh0KCZ1Yyk7Ci0JdW53X2luaXRfbG9jYWwoJmN1cnNvciwgJnVjKTsKLQl3aGlsZSAodW53X3N0 ZXAoJmN1cnNvcikgPiAwKSB7Ci0JCWNoYXIgbmFtZVsyNTVdOwotCQl1bndfd29yZF90IG9mZjsK LQotCQlpZiAodW53X2dldF9wcm9jX25hbWUoJmN1cnNvciwgbmFtZSwgMjU1LCAmb2ZmKSA8IDAp Ci0JCQl4c3RybGNweShuYW1lLCAiPHVua25vd24+IiwgMTApOwotCi0JCXhwcmludGYoIiAjJWQg WyVzKzB4JXhdXG4iLCBzdGFja19udW0rKywgbmFtZSwKLQkJCQkodW5zaWduZWQgaW50KSBvZmYp OwotCi0JfQogfQogCiB2b2lkIF9faWd0X2ZhaWxfYXNzZXJ0KGNvbnN0IGNoYXIgKmRvbWFpbiwg Y29uc3QgY2hhciAqZmlsZSwgY29uc3QgaW50IGxpbmUsCmRpZmYgLS1naXQgYS9saWIvbWVzb24u YnVpbGQgYi9saWIvbWVzb24uYnVpbGQKaW5kZXggN2UyYzliN2EuLjI2Y2VmMGM2IDEwMDY0NAot LS0gYS9saWIvbWVzb24uYnVpbGQKKysrIGIvbGliL21lc29uLmJ1aWxkCkBAIC01OSw3ICs1OSw2 IEBAIGxpYl9kZXBzID0gWwogCWxpYmttb2QsCiAJbGlicHJvY3BzLAogCWxpYnVkZXYsCi0JbGli dW53aW5kLAogCWxpYmR3LAogCXBjaWFjY2VzcywKIAlwdGhyZWFkcywKZGlmZiAtLWdpdCBhL21l c29uLmJ1aWxkIGIvbWVzb24uYnVpbGQKaW5kZXggZWZmMzU1ODUuLjg2YWQ2NjAyIDEwMDY0NAot LS0gYS9tZXNvbi5idWlsZAorKysgYi9tZXNvbi5idWlsZApAQCAtMTAyLDcgKzEwMiw2IEBAIGJ1 aWxkX2luZm8gKz0gJ1dpdGggbGliZHJtOiAnICsgJywnLmpvaW4obGliZHJtX2luZm8pCiBwY2lh Y2Nlc3MgPSBkZXBlbmRlbmN5KCdwY2lhY2Nlc3MnLCB2ZXJzaW9uIDogJz49MC4xMCcpCiBsaWJr bW9kID0gZGVwZW5kZW5jeSgnbGlia21vZCcpCiBsaWJwcm9jcHMgPSBkZXBlbmRlbmN5KCdsaWJw cm9jcHMnLCByZXF1aXJlZCA6IHRydWUpCi1saWJ1bndpbmQgPSBkZXBlbmRlbmN5KCdsaWJ1bndp bmQnLCByZXF1aXJlZCA6IHRydWUpCiBsaWJkdyA9IGRlcGVuZGVuY3koJ2xpYmR3JywgcmVxdWly ZWQgOiB0cnVlKQogc3NsID0gZGVwZW5kZW5jeSgnb3BlbnNzbCcsIHJlcXVpcmVkIDogdHJ1ZSkK IHBpeG1hbiA9IGRlcGVuZGVuY3koJ3BpeG1hbi0xJywgcmVxdWlyZWQgOiB0cnVlKQpAQCAtMjE3 LDEyICsyMTYsMTUgQEAgcHJlZml4ID0gZ2V0X29wdGlvbigncHJlZml4JykKIGJpbmRpciA9IGdl dF9vcHRpb24oJ2JpbmRpcicpCiBkYXRhZGlyID0gam9pbl9wYXRocyhnZXRfb3B0aW9uKCdkYXRh ZGlyJyksICdpZ3QtZ3B1LXRvb2xzJykKIGluY2x1ZGVkaXIgPSBnZXRfb3B0aW9uKCdpbmNsdWRl ZGlyJykKK2Z1bGxpbmNkaXIgPSBqb2luX3BhdGhzKHByZWZpeCwgaW5jbHVkZWRpcikKIGxpYmRp ciA9IGdldF9vcHRpb24oJ2xpYmRpcicpCiBsaWJleGVjZGlyID0gam9pbl9wYXRocyhnZXRfb3B0 aW9uKCdsaWJleGVjZGlyJyksICdpZ3QtZ3B1LXRvb2xzJykKIGFtZGdwdWRpciA9IGpvaW5fcGF0 aHMobGliZXhlY2RpciwgJ2FtZGdwdScpCiBtYW5kaXIgPSBnZXRfb3B0aW9uKCdtYW5kaXInKQog cGtnY29uZmlnZGlyID0gam9pbl9wYXRocyhsaWJkaXIsICdwa2djb25maWcnKQogCitpbmMgPSBb IGluY2x1ZGVfZGlyZWN0b3JpZXMoZnVsbGluY2Rpciwgam9pbl9wYXRocyggZnVsbGluY2Rpciwg J2xpYmRybScpKSwgaW5jIF0KKwogaWYgZ2V0X29wdGlvbigndXNlX3JwYXRoJykKIAkjIFNldCB1 cCBydW5wYXRoIGZvciB0aGUgdGVzdCBleGVjdXRhYmxlcyB0b3dhcmRzIGxpYmlndC5zby4KIAkj IFRoZSBwYXRoIHNob3VsZCBiZSByZWxhdGl2ZSB0byAkT1JJR0lOIHNvIHRoZSBsaWJyYXJ5IGlz CmRpZmYgLS1naXQgYS90ZXN0cy9nZW1fdXNlcnB0cl9ibGl0cy5jIGIvdGVzdHMvZ2VtX3VzZXJw dHJfYmxpdHMuYwppbmRleCA5MDlkZDE5ZC4uOTJkNWE2ZTEgMTAwNjQ0Ci0tLSBhL3Rlc3RzL2dl bV91c2VycHRyX2JsaXRzLmMKKysrIGIvdGVzdHMvZ2VtX3VzZXJwdHJfYmxpdHMuYwpAQCAtMTA2 OSw2ICsxMDY5LDcgQEAgc3RhdGljIHZvaWQgc3RvcmVfZHdvcmRfcmFuZChpbnQgaTkxNSwgdW5z aWduZWQgaW50IGVuZ2luZSwKIAogc3RhdGljIHZvaWQgdGVzdF9yZWFkb25seShpbnQgaTkxNSkK IHsKKyNpZiAwCiAJdW5zaWduZWQgY2hhciBvcmlnW1NIQV9ESUdFU1RfTEVOR1RIXTsKIAl1aW50 NjRfdCBhcGVydHVyZV9zaXplOwogCXVpbnQzMl90IHdoYW5kbGUsIHJoYW5kbGU7CkBAIC0xMTc4 LDYgKzExNzksNyBAQCBzdGF0aWMgdm9pZCB0ZXN0X3JlYWRvbmx5KGludCBpOTE1KQogCiAJbXVu bWFwKHNwYWNlLCB0b3RhbCk7CiAJbXVubWFwKHBhZ2VzLCBzeik7CisjZW5kaWYKIH0KIAogc3Rh dGljIGptcF9idWYgc2lnam1wOwpkaWZmIC0tZ2l0IGEvdG9vbHMvbWVzb24uYnVpbGQgYi90b29s cy9tZXNvbi5idWlsZAppbmRleCA3OWYzNmFhOS4uNWU5OTBjZDcgMTAwNjQ0Ci0tLSBhL3Rvb2xz L21lc29uLmJ1aWxkCisrKyBiL3Rvb2xzL21lc29uLmJ1aWxkCkBAIC05MCwxMSArOTAsNiBAQCBp bnN0YWxsX3N1YmRpcigncmVnaXN0ZXJzJywgaW5zdGFsbF9kaXIgOiBkYXRhZGlyLAogCQkgJ01h a2VmaWxlJywgJ01ha2VmaWxlLmluJywgJ01ha2VmaWxlLmFtJywKIAkgICAgICAgXSkKIAotc2hh cmVkX2xpYnJhcnkoJ2ludGVsX2F1YmR1bXAnLCAnYXViZHVtcC5jJywKLQkgICAgICAgZGVwZW5k ZW5jaWVzIDogWyBsaWJfaWd0X2NoaXBzZXQsIGRsc3ltIF0sCi0JICAgICAgIG5hbWVfcHJlZml4 IDogJycsCi0JICAgICAgIGluc3RhbGwgOiB0cnVlKQotCiBleGVjdXRhYmxlKCdpbnRlbF9ncHVf dG9wJywgJ2ludGVsX2dwdV90b3AuYycsCiAJICAgaW5zdGFsbCA6IHRydWUsCiAJICAgaW5zdGFs bF9ycGF0aCA6IGJpbmRpcl9ycGF0aGRpciwKQEAgLTEwNCw3ICs5OSw1IEBAIGNvbmZfZGF0YSA9 IGNvbmZpZ3VyYXRpb25fZGF0YSgpCiBjb25mX2RhdGEuc2V0KCdwcmVmaXgnLCBwcmVmaXgpCiBj b25mX2RhdGEuc2V0KCdleGVjX3ByZWZpeCcsICcke3ByZWZpeH0nKQogY29uZl9kYXRhLnNldCgn bGliZGlyJywgam9pbl9wYXRocygnJHtwcmVmaXh9JywgbGliZGlyKSkKLWNvbmZpZ3VyZV9maWxl KGlucHV0IDogJ2ludGVsX2F1YmR1bXAuaW4nLCBvdXRwdXQgOiAnaW50ZWxfYXViZHVtcCcsCi0g ICAgICAgICAgICAgICBjb25maWd1cmF0aW9uIDogY29uZl9kYXRhLCBpbnN0YWxsX2RpciA6IGJp bmRpcikKIAogc3ViZGlyKCdudWxsX3N0YXRlX2dlbicpCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJl IEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2lndC1kZXYK