From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: stanislav.lisovskiy@intel.com, ville.syrjala@intel.com,
martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t v2] lib/igt_fb: Fix unused variable buf.
Date: Fri, 26 Oct 2018 15:03:05 +0300 [thread overview]
Message-ID: <20181026120305.18672-1-stanislav.lisovskiy@intel.com> (raw)
Despite the comment temporary buf is not
used anywhere in convert_nv12_to_rgb24,
so it has to be either removed or used instead
of cvt->src.ptr.
v2: Put it in use instead of removing as other
functions seem to use it.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
lib/igt_fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4700b152..5e775c44 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1538,8 +1538,8 @@ static void convert_nv12_to_rgb24(struct fb_convert *cvt)
* from there.
*/
igt_memcpy_from_wc(buf, cvt->src.ptr, cvt->src.fb->size);
- y = cvt->src.ptr + cvt->src.fb->offsets[0];
- uv = cvt->src.ptr + cvt->src.fb->offsets[1];
+ y = buf + cvt->src.fb->offsets[0];
+ uv = buf + cvt->src.fb->offsets[1];
for (i = 0; i < cvt->dst.fb->height / 2; i++) {
for (j = 0; j < cvt->dst.fb->width / 2; j++) {
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2018-10-26 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 12:03 Stanislav Lisovskiy [this message]
2018-10-26 13:21 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Fix unused variable buf Patchwork
2018-10-26 14:41 ` Patchwork
2018-10-26 15:57 ` [igt-dev] [PATCH i-g-t v2] " Maarten Lankhorst
2018-11-02 18:31 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026120305.18672-1-stanislav.lisovskiy@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox