Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Only skip when width/x is not a multiple of 2.

Ville Syrjälä
2018-10-30T13:34:50Z

On Tue, Oct 30, 2018 at 12:26:46PM +0100, Maarten Lankhorst wrote:
> Y and height have no such restrictions, since pixel size has no
> relation to height.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> lib/igt_draw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 05821480bc80..84dd212c1daf 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -581,9 +581,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
> * smaller bpps you won't succeeed if you need to copy "half" of a 32bpp
> * pixel or something similar. */
> igt_skip_on(rect->x % (32 / buf->bpp) != 0 ||
> - rect->y % (32 / buf->bpp) != 0 ||
> - rect->w % (32 / buf->bpp) != 0 ||
> - rect->h % (32 / buf->bpp) != 0);
> + rect->w % (32 / buf->bpp) != 0);

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Adding 16bpp support to rendercopy shouldn't be too hard...

>
> igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
>
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel