Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Only skip when width/x is not a multiple of 2.

Maarten Lankhorst
2018-11-16T10:16:15Z

Op 30-10-18 om 14:34 schreef Ville Syrjälä:
> On Tue, Oct 30, 2018 at 12:26:46PM +0100, Maarten Lankhorst wrote:
>> Y and height have no such restrictions, since pixel size has no
>> relation to height.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> lib/igt_draw.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
>> index 05821480bc80..84dd212c1daf 100644
>> --- a/lib/igt_draw.c
>> +++ b/lib/igt_draw.c
>> @@ -581,9 +581,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>> * smaller bpps you won't succeeed if you need to copy "half" of a 32bpp
>> * pixel or something similar. */
>> igt_skip_on(rect->x % (32 / buf->bpp) != 0 ||
>> - rect->y % (32 / buf->bpp) != 0 ||
>> - rect->w % (32 / buf->bpp) != 0 ||
>> - rect->h % (32 / buf->bpp) != 0);
>> + rect->w % (32 / buf->bpp) != 0);
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Adding 16bpp support to rendercopy shouldn't be too hard...

Thanks, pushed. Will take a look at how to add it to rendercopy.