From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
Date: Tue, 30 Oct 2018 15:32:39 +0200 [thread overview]
Message-ID: <20181030133239.GU9144@intel.com> (raw)
In-Reply-To: <20181029204958.9759-1-chris@chris-wilson.co.uk>
On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> Older platforms require fence registers to perform blits, and so
> userspace is expected to mark up the objects to request fences be
> assigned.
>
> Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_tiled_fence_blits.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> index 7560fa52..e40a7b43 100644
> --- a/tests/i915/gem_tiled_fence_blits.c
> +++ b/tests/i915/gem_tiled_fence_blits.c
> @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
>
> memset(reloc, 0, sizeof(reloc));
> memset(obj, 0, sizeof(obj));
> + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
No harm in always asking for the fence I suppose.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> obj[2].handle = create_batch(fd, reloc);
> obj[2].relocs_ptr = to_user_pointer(reloc);
> obj[2].relocation_count = ARRAY_SIZE(reloc);
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-30 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 20:49 [Intel-gfx] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits Chris Wilson
2018-10-30 2:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-30 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-30 13:32 ` Ville Syrjälä [this message]
2018-10-30 17:30 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-10-30 18:04 ` [Intel-gfx] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030133239.GU9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox