Re: [igt-dev] [PATCH i-g-t 5/5] lib/igt_fb: s/tiling/modifier/ where appropriate

Dhinakaran Pandiyan
2018-10-31T22:48:14Z

On Tuesday, October 30, 2018 9:20:38 AM PDT Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Rename the igt_fb.tiling to igt_fb.modifier to better reflect
> what information it carries. Now it's clear whether we're talking
> about a modifier or a i915 tiling thing.
>

Makes sense,
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

We should probably rename the locals in the callers for more clarity. kms_flip_tiling.c,
kms_rotation_crc.c, pm_rpm.c and kms_available_modes_crc.c store the modifier as
"tiling". Is this something that can be scripted easily?

-DK

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_fb.c | 102 ++++++++++++++++++++++++------------------------
> lib/igt_fb.h | 22 +++++------
> tests/kms_ccs.c | 2 +-