Re: [igt-dev] [PATCH i-g-t 2/5] tests/debugfs: use igt_display_require

Chris Wilson
2018-11-02T11:16:33Z

Quoting Daniel Vetter (2018-11-02 09:57:23)
> Need to extract into a test subgroup to make sure we only skip the
> tests that need display support.
>
> v2: Chris pointed out that "read-all-entries" was the original non-kms
> tests, and we don't want to skip that if there's no output. Make a
> seperate test for this.
>
> Also, that kind of where libraries magically second-guess what the
> test might have wanted when it supplies an invalid request is exactly
> why I want to fix the igt_display_init API regression.

So strongly disagree about who is second guessing. A degenerate request
is still valid and I think a desirably property of the API.

You are handed a valid request to do nothing, stop complaining about it.
-Chris