Re: [igt-dev] [PATCH i-g-t v2 4/4] lib/igt_fb: Generalize the slow read from gtt mmap handling

Maxime Ripard
2018-11-05T15:19:40Z

[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]

On Fri, Nov 02, 2018 at 09:37:31PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the handling of slow gtt mmap reads generic, and extend it to
> the pixman converter. Makes the pixman path a bit faster.
>
> With testing just XRGB8888 and XBGR8888 on KBL:
> $ time kms_plane --r pixel-format-pipe-A-planes
> - real 0m18,757s
> + real 0m2,635s
>
> v2: Use the original src buffer if the malloc fails (Chris)
> Drop the duplicated comment about things being slow
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

For the 4 patches,
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]