Re: [igt-dev] [PATCH i-g-t v6 1/1] runner: Implement --abort-on-monitored-error

Arkadiusz Hiler
2018-11-13T13:23:54Z

On Fri, Nov 09, 2018 at 01:13:03PM +0200, Petri Latvala wrote:
<SNIP>
> diff --git a/runner/executor.c b/runner/executor.c
> index 007b72ce..089e6312 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -108,6 +108,91 @@ static void ping_watchdogs(void)
> }
> }
>
> +static char *handle_lockdep(void)
> +{
> + const char *header = "Lockdep not active\n\n/proc/lockdep_stats contents:\n";

I would prefer to have slightly more verbose message here, explaining
what might have happened (lock detected / out of classes) as this is
quite vague and easily may be misinterpreted.

But since I do not have a better idea that is not an essay:
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>