From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/4] tests/kms_plane_multiple: Add tiled-none plane position subtests
Date: Tue, 13 Nov 2018 10:23:48 -0500 [thread overview]
Message-ID: <20181113152350.23864-2-nicholas.kazlauskas@amd.com> (raw)
In-Reply-To: <20181113152350.23864-1-nicholas.kazlauskas@amd.com>
The per-pipe plane position subtests are capable of running on
AMDGPU as long as they're not using i915 specific tiling formats.
The test setup already supports being invoked with different tiling
modes so this patch introduces the new 'tiled-none' subtest that runs
without any tiling.
The tiled-none tests are skipped on i915 to retain existing test
coverage and behavior on i915.
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
tests/kms_plane_multiple.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 721afe59..7c8adf94 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -291,12 +291,16 @@ test_plane_position(data_t *data, enum pipe pipe, uint64_t tiling)
{
igt_output_t *output;
int connected_outs;
- int devid = intel_get_drm_devid(data->drm_fd);
int n_planes = data->display.pipes[pipe].n_planes;
+ if (is_i915_device(data->drm_fd))
+ igt_skip_on(tiling == LOCAL_DRM_FORMAT_MOD_NONE);
+ else
+ igt_skip_on(tiling != LOCAL_DRM_FORMAT_MOD_NONE);
+
if ((tiling == LOCAL_I915_FORMAT_MOD_Y_TILED ||
tiling == LOCAL_I915_FORMAT_MOD_Yf_TILED))
- igt_require(AT_LEAST_GEN(devid, 9));
+ igt_require(AT_LEAST_GEN(intel_get_drm_devid(data->drm_fd), 9));
if (!opt.user_seed)
opt.seed = time(NULL);
@@ -344,6 +348,10 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
igt_subtest_f("atomic-pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
for_each_valid_output_on_pipe(&data->display, pipe, output)
test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_Yf_TILED);
+
+ igt_subtest_f("atomic-pipe-%s-tiling-none", kmstest_pipe_name(pipe))
+ for_each_valid_output_on_pipe(&data->display, pipe, output)
+ test_plane_position(data, pipe, LOCAL_DRM_FORMAT_MOD_NONE);
}
static data_t data;
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-13 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 15:23 [igt-dev] [PATCH i-g-t 1/4] tests/kms_plane_scaling: Add support for testing AMDGPU Nicholas Kazlauskas
2018-11-13 15:23 ` Nicholas Kazlauskas [this message]
2018-11-13 16:58 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_plane_multiple: Add tiled-none plane position subtests Ville Syrjälä
2018-11-13 17:02 ` Kazlauskas, Nicholas
2018-11-13 17:15 ` Ville Syrjälä
2018-11-27 18:36 ` Kazlauskas, Nicholas
2018-11-27 19:00 ` Ville Syrjälä
2018-11-13 15:23 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_plane_lowres: Only test i915 features on i915 Nicholas Kazlauskas
2018-11-13 17:00 ` Ville Syrjälä
2018-11-13 15:23 ` [igt-dev] [PATCH i-g-t 4/4] tests: Enable plane tests for AMDGPU Nicholas Kazlauskas
2018-11-13 16:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_plane_scaling: Add support for testing AMDGPU Patchwork
2018-11-13 16:57 ` [igt-dev] [PATCH i-g-t 1/4] " Ville Syrjälä
2018-11-13 17:00 ` Kazlauskas, Nicholas
2018-11-13 17:08 ` Ville Syrjälä
2018-11-13 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-11-28 14:56 [igt-dev] [PATCH i-g-t 1/4] " Nicholas Kazlauskas
2018-11-28 14:56 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_plane_multiple: Add tiled-none plane position subtests Nicholas Kazlauskas
2018-11-29 21:48 ` Wentland, Harry
2018-11-30 13:35 ` Kazlauskas, Nicholas
2018-11-30 13:55 ` Ville Syrjälä
2018-11-30 13:57 ` Kazlauskas, Nicholas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113152350.23864-2-nicholas.kazlauskas@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox