From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Eric Anholt <eric@anholt.net>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 1/6] kms_content_protection: Fix log bug on 32-bit platforms.
Date: Thu, 15 Nov 2018 22:39:27 +0200 [thread overview]
Message-ID: <20181115203927.GA9144@intel.com> (raw)
In-Reply-To: <20181115185737.19311-1-eric@anholt.net>
On Thu, Nov 15, 2018 at 10:57:32AM -0800, Eric Anholt wrote:
> long is different between 32 and 64 and should basically never be
> used. Fixes compiler warning about passing the wrong type.
>
> v2: Use the PRId64 macros instead of long long.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_content_protection.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
> index 801eff66c272..ef90ed4c1792 100644
> --- a/tests/kms_content_protection.c
> +++ b/tests/kms_content_protection.c
> @@ -89,7 +89,8 @@ wait_for_prop_value(igt_output_t *output, uint64_t expected,
> return true;
> usleep(1000);
> }
> - igt_info("prop_value mismatch %ld != %ld\n", val, expected);
> + igt_info("prop_value mismatch %" PRId64 " != %" PRId64 "\n",
> + val, expected);
>
> return false;
> }
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-15 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 18:57 [igt-dev] [PATCH i-g-t v2 1/6] kms_content_protection: Fix log bug on 32-bit platforms Eric Anholt
2018-11-15 18:57 ` [igt-dev] [PATCH i-g-t v2 2/6] meson: Drop -Wdeclaration-after-statement Eric Anholt
2018-11-15 18:57 ` [igt-dev] [PATCH i-g-t v2 3/6] v3d: Import the V3D DRM UAPI header Eric Anholt
2018-11-15 18:57 ` [igt-dev] [PATCH i-g-t v2 4/6] v3d: Add a helper library Eric Anholt
2018-11-15 18:57 ` [igt-dev] [PATCH i-g-t v2 5/6] v3d_*: Add new tests for the V3D UABI Eric Anholt
2018-11-15 18:57 ` [igt-dev] [PATCH i-g-t v2 6/6] v3d: Add tests for hanging V3D using an RCL Eric Anholt
2018-11-15 19:41 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/6] kms_content_protection: Fix log bug on 32-bit platforms Patchwork
2018-11-15 20:39 ` Ville Syrjälä [this message]
2018-11-15 21:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115203927.GA9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=eric@anholt.net \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox