From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: igt-dev@lists.freedesktop.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] chamelium: Pass and use stride for xr24 pattern paint
Date: Fri, 16 Nov 2018 08:46:51 +0100 [thread overview]
Message-ID: <20181116074651.iglr47vyqtdgzebv@flea> (raw)
In-Reply-To: <20181115165140.21947-2-paul.kocialkowski@bootlin.com>
[-- Attachment #1.1: Type: text/plain, Size: 571 bytes --]
On Thu, Nov 15, 2018 at 05:51:40PM +0100, Paul Kocialkowski wrote:
> Using the width from the selected mode is not sufficient to correctly
> paint a pattern on the framebuffer memory: the stride also has to be
> taken in account for proper line start alignment.
>
> Pass the stride and use it in chamelium_paint_xr24_pattern.
Both patches look fine, but your missing your SoB here.
With that fixed,
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-11-16 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 16:51 [igt-dev] [PATCH i-g-t 1/2] chamelium: Fix inverted xr24 pattern paint dimensions Paul Kocialkowski
2018-11-15 18:01 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2018-11-15 21:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
[not found] ` <20181115165140.21947-2-paul.kocialkowski@bootlin.com>
2018-11-16 7:46 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116074651.iglr47vyqtdgzebv@flea \
--to=maxime.ripard@bootlin.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox