From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_render_tiled_blits: Make sure igt_buf is initially zero'd
Date: Mon, 19 Nov 2018 12:05:28 +0100 [thread overview]
Message-ID: <20181119110528.12877-2-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20181119110528.12877-1-maarten.lankhorst@linux.intel.com>
gen8_bind_buf looks at buf->aux.stride/offset, which is not set by the
test. When I added the bpp field, it was enough to make the test fail,
fix this by making sure that the buf is initially zero'd explicitly,
which fixes the test to run reliably 100% of the time.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
tests/i915/gem_render_tiled_blits.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
index 3007f2abd655..129500616315 100644
--- a/tests/i915/gem_render_tiled_blits.c
+++ b/tests/i915/gem_render_tiled_blits.c
@@ -121,7 +121,7 @@ static void run_test (int fd, int count)
igt_info("Using a snoop linear buffer for comparisons\n");
}
- buf = malloc(sizeof(*buf)*count);
+ buf = calloc(sizeof(*buf), count);
start_val = malloc(sizeof(*start_val)*count);
for (i = 0; i < count; i++) {
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-19 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 11:05 [igt-dev] [PATCH i-g-t 1/2] lib/igt_fb: Fix -Werror=missing-braces compilation on clang Maarten Lankhorst
2018-11-19 11:05 ` Maarten Lankhorst [this message]
2018-11-19 12:05 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_render_tiled_blits: Make sure igt_buf is initially zero'd Chris Wilson
2018-11-19 12:08 ` Chris Wilson
2018-11-19 13:41 ` Maarten Lankhorst
2018-11-19 13:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_fb: Fix -Werror=missing-braces compilation on clang Patchwork
2018-11-19 16:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119110528.12877-2-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox