Re: [igt-dev] [PATCH i-g-t] runner: Treat dmesg warnings as pure warnings

Ville Syrjälä
2018-11-14T13:25:43Z

On Wed, Nov 14, 2018 at 01:56:53PM +0200, Petri Latvala wrote:
> On Tue, Nov 13, 2018 at 05:25:47PM +0000, Chris Wilson wrote:
> > I have whinged on for ages about the dmesg-warnings being an expected
> > part of kernel testing (where else is the kernel meant to log its
> > errors?) and should be treated the same as our stderr for the test. That
> > is if a test fails, it fails and does not need to be conflated with
> > whether or not there was a dmesg warning (just as the test saying why it
> > failed on stderr does not need flagging), and that a passing test with a
> > dmesg warning is simply a warn.
> >
> > The effect is that we simply remove the "dmesg-" flagging from results
> > names, as the err/dmesg output is simply collated for the error report
> > already.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Cc: Martin Peres <martin.peres@linux.intel.com>
>
>
> Yep, now's a good a time as any to remove this cargo cult if ever.
>
> Some acks from kernel people in general would be nice.
>
> TODO:
> Martin: cibuglog filters ready for this
> Tomi et al: Visualization ready for this (tooltips etc)

Can I still see from the color/etc. whether there was some dmesg spew or
not? I often glance at those and would prefer to not have to go through
all the fails to find them.

--
Ville Syrjälä
Intel