public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Petri Latvala <petri.latvala@intel.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/gem_ctx_param: Missing igt_fixture
Date: Mon, 26 Nov 2018 15:24:26 +0100	[thread overview]
Message-ID: <20181126142426.19636-1-daniel.vetter@ffwll.ch> (raw)

It's not cool to run an ioctl outside of igt_fixture.

Reported-by: Petri Latvala <petri.latvala@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/i915/gem_ctx_param.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c
index c46fd709b0d7..0bbc5effbf9f 100644
--- a/tests/i915/gem_ctx_param.c
+++ b/tests/i915/gem_ctx_param.c
@@ -156,14 +156,14 @@ igt_main
 
 		gem_require_contexts(fd);
 		ctx = gem_context_create(fd);
-	}
 
-	arg.param = I915_CONTEXT_PARAM_BAN_PERIOD;
+		arg.param = I915_CONTEXT_PARAM_BAN_PERIOD;
 
-	/* XXX start to enforce ban period returning -EINVAL when
-	 * transition has been done */
-	if (__gem_context_get_param(fd, &arg) == -EINVAL)
-		arg.param = I915_CONTEXT_PARAM_BANNABLE;
+		/* XXX start to enforce ban period returning -EINVAL when
+		 * transition has been done */
+		if (__gem_context_get_param(fd, &arg) == -EINVAL)
+			arg.param = I915_CONTEXT_PARAM_BANNABLE;
+	}
 
 	igt_subtest("basic") {
 		arg.ctx_id = ctx;
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-11-26 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 14:24 Daniel Vetter [this message]
2018-11-26 14:52 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/gem_ctx_param: Missing igt_fixture Patchwork
2018-11-26 17:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181126142426.19636-1-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox