From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE4C889DA2 for ; Mon, 26 Nov 2018 14:26:10 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id d3so15975616edx.7 for ; Mon, 26 Nov 2018 06:26:10 -0800 (PST) Date: Mon, 26 Nov 2018 15:26:06 +0100 From: Daniel Vetter Message-ID: <20181126142606.GN4266@phenom.ffwll.local> References: <20181126100824.31623-1-daniel.vetter@ffwll.ch> <8736roca5b.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8736roca5b.fsf@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jani Nikula Cc: IGT development , Daniel Vetter List-ID: T24gTW9uLCBOb3YgMjYsIDIwMTggYXQgMDI6MTA6MDhQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gTW9uLCAyNiBOb3YgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4gd3JvdGU6Cj4gPiBTb21lIHRlc3RzIGFzc3VtZSB0aGF0IGNsb3NlIG9uIGFuIHVu b3BlbmVkIGZkIGlzIGZpbmUsIGV4Y2VwdCBpdCdzCj4gPiBub3QganVzdCB1bm9wZW5lZCBidXQg YWN0dWFsbHkgc3RhY2sgZ2FyYmFnZS4gVGhlcmUncyBhIGdvb2QgY2hhbmNlIHdlCj4gPiBlbmQg dXAgcnVubmluZyBjbG9zZSgwKSwgd2hpY2ggd3JlYWtzIHRoZSB0ZXN0Y2FzZSBlbnVtZXJhdGlv bi4gRml4Cj4gPiB0aGlzLgo+ID4KPiA+IE5vdCBzdXJlIHRoZXJlJ3MgYSBiZXR0ZXIgd2F5IHRv IGNhdGNoIHRoaXMgdGhhbiBnaXQgZ3JlcCBwbHVzIGxvdHMgb2YKPiA+IG1hbnVhbCBhdWRpdGlu ZyAuLi4gVGhlIHVuaXQgdGVzdHMgb25seSBjYXRjaCBpdCBieSBhY2NpZGVudCAoeDg2Cj4gPiB3 b3JrcyBmaW5lLCBJIGhpdCBpdCBpbiBvbmUgdGVzdGNhc2Ugb25seSBjcm9zcy1idWlsZGluZyB0 byBhYXJjaDY0KS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIHRlc3RzL2k5MTUvZ2VtX3ByZWFkX2FmdGVy X2JsaXQuYyAgfCAzICsrLQo+ID4gIHRlc3RzL2k5MTUvZ2VtX3RpbGVkX2ZlbmNlX2JsaXRzLmMg fCAzICsrLQo+ID4gIHRlc3RzL2k5MTUvZ2VtX3RpbGVkX3N3YXBwaW5nLmMgICAgfCAzICsrLQo+ ID4gIDMgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4K PiA+IGRpZmYgLS1naXQgYS90ZXN0cy9pOTE1L2dlbV9wcmVhZF9hZnRlcl9ibGl0LmMgYi90ZXN0 cy9pOTE1L2dlbV9wcmVhZF9hZnRlcl9ibGl0LmMKPiA+IGluZGV4IDZlZjNjYTIwMDc3Ni4uY2Vl OTIxMjc0OWQ2IDEwMDY0NAo+ID4gLS0tIGEvdGVzdHMvaTkxNS9nZW1fcHJlYWRfYWZ0ZXJfYmxp dC5jCj4gPiArKysgYi90ZXN0cy9pOTE1L2dlbV9wcmVhZF9hZnRlcl9ibGl0LmMKPiA+IEBAIC0y NDgsNSArMjQ4LDYgQEAgaWd0X21haW4KPiA+ICAJCWRybV9pbnRlbF9idWZtZ3JfZGVzdHJveShi dWZtZ3IpOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCWNsb3NlKGZkKTsKPiAKPiBUaGlzIG9uZSBpc24n dCBzdGFjayBnYXJiYWdlLCBpdCdzIGd1YXJhbnRlZWQgdG8gYmUgMCBmb3IKPiAhaWd0X2ZpeHR1 cmUuIFRoZSBvdGhlciB0d28gYXJlIGdhcmJhZ2Ugb24gc3RhY2suCj4gCj4gVGhlIGNoYW5nZSBp cwo+IAo+IFJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ IAo+IGJ1dCBwbGVhc2UgdXBkYXRlIHRoZSBjb21taXQgbWVzc2FnZS4KCkluZGVlZCEgTm90ZWQg aW4gdGhlIGNvbW1pdCBtZXNzYWdlIGFuZCBwdXNoZWQsIHRoYW5rcyBmb3IgeW91ciByZXZpZXcu Ci1EYW5pZWwKCj4gCj4gPiArCWlndF9maXh0dXJlCj4gPiArCQljbG9zZShmZCk7Cj4gPiAgfQo+ ID4gZGlmZiAtLWdpdCBhL3Rlc3RzL2k5MTUvZ2VtX3RpbGVkX2ZlbmNlX2JsaXRzLmMgYi90ZXN0 cy9pOTE1L2dlbV90aWxlZF9mZW5jZV9ibGl0cy5jCj4gPiBpbmRleCBjMDJlMzVhNWZlNGMuLjI0 NTNiY2MwYjI3MSAxMDA2NDQKPiA+IC0tLSBhL3Rlc3RzL2k5MTUvZ2VtX3RpbGVkX2ZlbmNlX2Js aXRzLmMKPiA+ICsrKyBiL3Rlc3RzL2k5MTUvZ2VtX3RpbGVkX2ZlbmNlX2JsaXRzLmMKPiA+IEBA IC0yMzAsNSArMjMwLDYgQEAgaWd0X21haW4KPiA+ICAJCXJ1bl90ZXN0KGZkLCBjb3VudCk7Cj4g PiAgCX0KPiA+ICAKPiA+IC0JY2xvc2UoZmQpOwo+ID4gKwlpZ3RfZml4dHVyZQo+ID4gKwkJY2xv c2UoZmQpOwo+ID4gIH0KPiA+IGRpZmYgLS1naXQgYS90ZXN0cy9pOTE1L2dlbV90aWxlZF9zd2Fw cGluZy5jIGIvdGVzdHMvaTkxNS9nZW1fdGlsZWRfc3dhcHBpbmcuYwo+ID4gaW5kZXggZGNlNjY4 MDYzMDE0Li5kZGYyYTc0OGZjODQgMTAwNjQ0Cj4gPiAtLS0gYS90ZXN0cy9pOTE1L2dlbV90aWxl ZF9zd2FwcGluZy5jCj4gPiArKysgYi90ZXN0cy9pOTE1L2dlbV90aWxlZF9zd2FwcGluZy5jCj4g PiBAQCAtMjM1LDUgKzIzNSw2IEBAIGlndF9tYWluCj4gPiAgCQkJdGhyZWFkX2ZpbmkoJnRocmVh ZHNbbl0pOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCWNsb3NlKGZkKTsKPiA+ICsJaWd0X2ZpeHR1cmUK PiA+ICsJCWNsb3NlKGZkKTsKPiA+ICB9Cj4gCj4gLS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5n aW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0 CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=