From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Flip kill args
Date: Tue, 27 Nov 2018 14:42:52 +0200 [thread overview]
Message-ID: <20181127124252.GI17124@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20181127122255.11566-1-chris@chris-wilson.co.uk>
On Tue, Nov 27, 2018 at 12:22:55PM +0000, Chris Wilson wrote:
> int kill(pid_t pid, int sig)!
>
> Fixes: a6b514d242bd ("runner: Be patient for processes to die")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> runner/executor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runner/executor.c b/runner/executor.c
> index 62901d86a..f75efbbc4 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -545,7 +545,7 @@ static int monitor_output(pid_t child,
> * forward progress towards exiting (i.e. still
> * freeing all of its resources).
> */
> - if (kill(0, child) == 0 && !tainted(&taints)) {
> + if (kill(child, 0) == 0 && !tainted(&taints)) {
> intervals_left = 1;
> break;
> }
> --
> 2.20.0.rc1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-27 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 12:22 [igt-dev] [PATCH i-g-t] runner: Flip kill args Chris Wilson
2018-11-27 12:42 ` Petri Latvala [this message]
2018-11-27 12:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-11-27 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-27 15:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127124252.GI17124@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox