From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 241746E311
 for <igt-dev@lists.freedesktop.org>; Tue,  4 Dec 2018 19:28:34 +0000 (UTC)
Date: Tue, 4 Dec 2018 21:28:29 +0200
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Message-ID: <20181204192829.GO9144@intel.com>
References: <cover.c2054fa47f16b6319869fa4a8a2357a3a13e6d6c.1543917797.git-series.maxime.ripard@bootlin.com>
 <892b6e0724e7f5a76c9e37474aaa8ff387a3fab8.1543917797.git-series.maxime.ripard@bootlin.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <892b6e0724e7f5a76c9e37474aaa8ff387a3fab8.1543917797.git-series.maxime.ripard@bootlin.com>
Subject: Re: [igt-dev] [PATCH 5/8] igt: fb: Move i915 buffer allocation to a
 function of its own
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Petri Latvala <petri.latvala@intel.com>, eben@raspberrypi.org, igt-dev@lists.freedesktop.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
List-ID: <igt-dev@lists.freedesktop.org>

T24gVHVlLCBEZWMgMDQsIDIwMTggYXQgMTE6MDg6MTlBTSArMDEwMCwgTWF4aW1lIFJpcGFyZCB3
cm90ZToKPiBUaGUgY3JlYXRlX2JvX2Zvcl9mYiBmdW5jdGlvbiBoYXMgYSByYXRoZXIgYmlnLCBu
b24gdHJpdmlhbCBibG9jayBvZgo+IGNvZGUgdG8gYWxsb2NhdGUgYnVmZmVycyBpbiBzb21lIG5v
bi10cml2aWFsIHNpdHVhdGlvbiBvbiB0aGUgaTkxNQo+IGRyaXZlci4KPiAKPiBTaW5jZSB0aGlz
IGlzIGJvdGggbm9uLXRyaXZpYWwgYW5kIGRyaXZlciBzcGVjaWZpYywgbW92ZSB0aGF0IGNvZGUK
PiBpbnRvIGEgZnVuY3Rpb24gb2YgaXRzIG93biBzbyB0aGF0IHdlIGNhbiByZXdvcmsgdGhhdCBm
dW5jdGlvbiBsYXRlcgo+IG9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1h
eGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyB8IDg5ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmls
ZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCA0MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t
Z2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXggMjQ2MmQ2YmE2ZmFiLi5k
OTY2ODlhYTVmZTYgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4gKysrIGIvbGliL2lndF9m
Yi5jCj4gQEAgLTQ1Myw2ICs0NTMsNTIgQEAgdWludDY0X3QgaWd0X2ZiX3RpbGluZ190b19tb2Qo
dWludDY0X3QgdGlsaW5nKQo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGk5MTVfY3JlYXRl
X2dlbV9mb3JfZmIoc3RydWN0IGlndF9mYiAqZmIpCj4gK3sKPiArCWJvb2wgZnVsbF9yYW5nZSA9
IGZiLT5jb2xvcl9yYW5nZSA9PSBJR1RfQ09MT1JfWUNCQ1JfRlVMTF9SQU5HRTsKPiArCWludCBm
ZCA9IGZiLT5mZDsKPiArCXZvaWQgKnB0cjsKPiArCj4gKwlmYi0+Z2VtX2hhbmRsZSA9IGdlbV9j
cmVhdGUoZmQsIGZiLT5zaXplKTsKPiArCWdlbV9zZXRfdGlsaW5nKGZkLCBmYi0+Z2VtX2hhbmRs
ZSwKPiArCQkgICAgICAgaWd0X2ZiX21vZF90b190aWxpbmcoZmItPnRpbGluZyksCj4gKwkJICAg
ICAgIGZiLT5zdHJpZGVzWzBdKTsKPiArCj4gKwlnZW1fc2V0X2RvbWFpbihmZCwgZmItPmdlbV9o
YW5kbGUsCj4gKwkJICAgICAgIEk5MTVfR0VNX0RPTUFJTl9HVFQsIEk5MTVfR0VNX0RPTUFJTl9H
VFQpOwo+ICsKPiArCS8qIEVuc3VyZSB0aGUgZnJhbWVidWZmZXIgaXMgcHJlYWxsb2NhdGVkICov
Cj4gKwlwdHIgPSBnZW1fbW1hcF9fZ3R0KGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiArCQkJICAgIGZi
LT5zaXplLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRFKTsKPiArCWlndF9hc3NlcnQoKih1aW50MzJf
dCAqKXB0ciA9PSAwKTsKPiArCj4gKwlzd2l0Y2ggKGZiLT5kcm1fZm9ybWF0KSB7Cj4gKwljYXNl
IERSTV9GT1JNQVRfTlYxMjoKPiArCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gKwkJ
ICAgICAgIGZ1bGxfcmFuZ2UgPyAweDAwIDogMHgxMCwKPiArCQkgICAgICAgZmItPnN0cmlkZXNb
MF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdKTsKPiArCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNb
MV0sCj4gKwkJICAgICAgIDB4ODAsCj4gKwkJICAgICAgIGZiLT5zdHJpZGVzWzFdICogZmItPnBs
YW5lX2hlaWdodFsxXSk7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIERSTV9GT1JNQVRfWVVZVjoKPiAr
CWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+ICsJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0s
Cj4gKwkJCWZ1bGxfcmFuZ2UgPyAweDgwMDA4MDAwIDogMHg4MDEwODAxMCwKPiArCQkJZmItPnN0
cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiArCQli
cmVhazsKPiArCWNhc2UgRFJNX0ZPUk1BVF9VWVZZOgo+ICsJY2FzZSBEUk1fRk9STUFUX1ZZVVk6
Cj4gKwkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiArCQkJZnVsbF9yYW5nZSA/IDB4
MDA4MDAwODAgOiAweDEwODAxMDgwLAo+ICsJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9o
ZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ICsJCWJyZWFrOwo+ICsJfQo+ICsJZ2VtX211
bm1hcChwdHIsIGZiLT5zaXplKTsKCldlIHNob3VsZCBwcm9iYWJseSBleHRyYWN0IHRoaXMgbWVt
c2V0KCkgc3R1ZmYgaW50byBhIHNlcGFyYXRlCmZ1bmN0aW9uIGJlY2F1c2UgZXZlcnkgZHJpdmVy
IHdpbGwgcmVxdWlyZSBpdC4KCj4gKwo+ICsJcmV0dXJuIGZiLT5nZW1faGFuZGxlOwo+ICt9Cj4g
Kwo+ICAvKiBoZWxwZXJzIHRvIGNyZWF0ZSBuaWNlLWxvb2tpbmcgZnJhbWVidWZmZXJzICovCj4g
IHN0YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0X2ZiICpmYikKPiAgewo+IEBA
IC00NzAsNDggKzUxNiw3IEBAIHN0YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0
X2ZiICpmYikKPiAgCQlmYi0+aXNfZHVtYiA9IGZhbHNlOwo+ICAKPiAgCQlpZiAoaXNfaTkxNV9k
ZXZpY2UoZmQpKSB7Cj4gLQkJCXZvaWQgKnB0cjsKPiAtCQkJYm9vbCBmdWxsX3JhbmdlID0gZmIt
PmNvbG9yX3JhbmdlID09IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JBTkdFOwo+IC0KPiAtCQkJZmIt
PmdlbV9oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCBmYi0+c2l6ZSk7Cj4gLQo+IC0JCQlnZW1fc2V0
X3RpbGluZyhmZCwgZmItPmdlbV9oYW5kbGUsCj4gLQkJCQkgICAgICAgaWd0X2ZiX21vZF90b190
aWxpbmcoZmItPnRpbGluZyksCj4gLQkJCQkgICAgICAgZmItPnN0cmlkZXNbMF0pOwo+IC0KPiAt
CQkJZ2VtX3NldF9kb21haW4oZmQsIGZiLT5nZW1faGFuZGxlLAo+IC0JCQkJICAgICAgIEk5MTVf
R0VNX0RPTUFJTl9HVFQsIEk5MTVfR0VNX0RPTUFJTl9HVFQpOwo+IC0KPiAtCQkJLyogRW5zdXJl
IHRoZSBmcmFtZWJ1ZmZlciBpcyBwcmVhbGxvY2F0ZWQgKi8KPiAtCQkJcHRyID0gZ2VtX21tYXBf
X2d0dChmZCwgZmItPmdlbV9oYW5kbGUsCj4gLQkJCQkJICAgIGZiLT5zaXplLCBQUk9UX1JFQUQg
fCBQUk9UX1dSSVRFKTsKPiAtCQkJaWd0X2Fzc2VydCgqKHVpbnQzMl90ICopcHRyID09IDApOwo+
IC0KPiAtCQkJc3dpdGNoIChmYi0+ZHJtX2Zvcm1hdCkgewo+IC0JCQljYXNlIERSTV9GT1JNQVRf
TlYxMjoKPiAtCQkJCW1lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiAtCQkJCSAgICAgICBm
dWxsX3JhbmdlID8gMHgwMCA6IDB4MTAsCj4gLQkJCQkgICAgICAgZmItPnN0cmlkZXNbMF0gKiBm
Yi0+cGxhbmVfaGVpZ2h0WzBdKTsKPiAtCQkJCW1lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1sxXSwK
PiAtCQkJCSAgICAgICAweDgwLAo+IC0JCQkJICAgICAgIGZiLT5zdHJpZGVzWzFdICogZmItPnBs
YW5lX2hlaWdodFsxXSk7Cj4gLQkJCQlicmVhazsKPiAtCQkJY2FzZSBEUk1fRk9STUFUX1lVWVY6
Cj4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+IC0JCQkJd21lbXNldChwdHIgKyBmYi0+b2Zm
c2V0c1swXSwKPiAtCQkJCQlmdWxsX3JhbmdlID8gMHg4MDAwODAwMCA6IDB4ODAxMDgwMTAsCj4g
LQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFy
X3QpKTsKPiAtCQkJCWJyZWFrOwo+IC0JCQljYXNlIERSTV9GT1JNQVRfVVlWWToKPiAtCQkJY2Fz
ZSBEUk1fRk9STUFUX1ZZVVk6Cj4gLQkJCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+
IC0JCQkJCWZ1bGxfcmFuZ2UgPyAweDAwODAwMDgwIDogMHgxMDgwMTA4MCwKPiAtCQkJCQlmYi0+
c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+IC0J
CQkJYnJlYWs7Cj4gLQkJCX0KPiAtCQkJZ2VtX211bm1hcChwdHIsIGZiLT5zaXplKTsKPiAtCj4g
LQkJCXJldHVybiBmYi0+Z2VtX2hhbmRsZTsKPiArCQkJcmV0dXJuIGk5MTVfY3JlYXRlX2dlbV9m
b3JfZmIoZmIpOwo+ICAJCX0gZWxzZSB7Cj4gIAkJCWJvb2wgZHJpdmVyX2hhc19nZW1fYXBpID0g
ZmFsc2U7Cj4gIAo+IC0tIAo+IGdpdC1zZXJpZXMgMC45LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QK
SW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0
LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==