From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Petri Latvala <petri.latvala@intel.com>,
Eben Upton <eben@raspberrypi.org>,
igt-dev@lists.freedesktop.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t 4/9] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation
Date: Thu, 6 Dec 2018 15:30:40 +0100 [thread overview]
Message-ID: <20181206143040.hv33hrzcw2lxom3d@flea> (raw)
In-Reply-To: <20181206141132.23349-5-paul.kocialkowski@bootlin.com>
[-- Attachment #1.1: Type: text/plain, Size: 669 bytes --]
On Thu, Dec 06, 2018 at 03:11:27PM +0100, Paul Kocialkowski wrote:
> The code path for allocating tiled buffers has a few i915-specific bits
> without checks for the i915 driver. Add these missing checks.
>
> For the map_bo function, initially define the return pointer to
> MAP_FAILED and assert that it's not MAP_FAILED when no mapping function
> was found, in order to provide an understandable error when it occurs.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
You're doing two things in that patch, it should be two patches.
maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-06 14:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 14:11 [igt-dev] [PATCH i-g-t 0/9] Chamelium VC4 plane testing, with T-tiled mode Paul Kocialkowski
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 1/9] chamelium: Pass dimensions instead of mode to pattern generation helper Paul Kocialkowski
2018-12-06 21:43 ` Lyude Paul
2018-12-07 7:37 ` Paul Kocialkowski
2018-12-07 22:41 ` Lyude Paul
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 2/9] chamelium: Pass the pattern block size as argument to helpers Paul Kocialkowski
2018-12-06 22:54 ` Lyude Paul
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 3/9] lib: drmtest: Add helpers to check and require the VC4 driver Paul Kocialkowski
2018-12-06 22:55 ` Lyude Paul
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 4/9] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation Paul Kocialkowski
2018-12-06 14:30 ` Maxime Ripard [this message]
2018-12-10 16:30 ` Ville Syrjälä
2018-12-13 13:29 ` Paul Kocialkowski
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 5/9] lib/igt_fb: Add support for allocating T-tiled VC4 buffers Paul Kocialkowski
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 6/9] lib/igt_vc4: Add helpers for converting linear to T-tiled XRGB buffers Paul Kocialkowski
2018-12-06 21:51 ` Lyude Paul
2018-12-07 7:38 ` Paul Kocialkowski
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 7/9] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert Paul Kocialkowski
2018-12-06 14:32 ` Maxime Ripard
2018-12-06 22:57 ` Lyude Paul
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 8/9] lib/igt_fb: Add a helper to retreive the plane bpp for a given format Paul Kocialkowski
2018-12-06 22:58 ` Lyude Paul
2018-12-06 14:11 ` [igt-dev] [PATCH i-g-t 9/9] chamelium: Add a CRC-based display test for randomized planes Paul Kocialkowski
2018-12-06 14:49 ` Maxime Ripard
2018-12-06 22:52 ` Lyude Paul
2018-12-13 14:39 ` Paul Kocialkowski
2018-12-06 14:19 ` [igt-dev] ✗ Fi.CI.BAT: failure for Chamelium VC4 plane testing, with T-tiled mode Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206143040.hv33hrzcw2lxom3d@flea \
--to=maxime.ripard@bootlin.com \
--cc=eben@raspberrypi.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=petri.latvala@intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox