From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 15BFC6E5E3 for ; Thu, 6 Dec 2018 14:49:03 +0000 (UTC) Date: Thu, 6 Dec 2018 15:49:01 +0100 From: Maxime Ripard Message-ID: <20181206144901.bc7mjfqtrotiex3c@flea> References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-10-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20181206141132.23349-10-paul.kocialkowski@bootlin.com> Subject: Re: [igt-dev] [PATCH i-g-t 9/9] chamelium: Add a CRC-based display test for randomized planes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0969937212==" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski Cc: Petri Latvala , Eben Upton , igt-dev@lists.freedesktop.org, Thomas Petazzoni List-ID: --===============0969937212== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2f2ythpdnryukdtz" Content-Disposition: inline --2f2ythpdnryukdtz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Dec 06, 2018 at 03:11:32PM +0100, Paul Kocialkowski wrote: > This introduces a new test for the Chamelium, that sets up planes > with randomized properties such as the format, dimensions, position, > in-framebuffer offsets and stride. The Chamelium capture is checked > against the reference generated by cairo with a CRC. >=20 > This test also includes testing for some VC4-specific features, such as > T-tiled mode (in XR24 format), bandwidth limitation and underrun > (that require kernel-side patches that are currently under review). it's not really clear to me why both are part of the same test? You don't really need to test the HVS bandwidth limitation with the patterns, and you don't really need a pattern and a CRC to test the HVS bandwith? > Since this test does not share much with previous CRC-based display > tests (especially regarding KMS configuration), most of the code is > not shared with other tests. >=20 > This test can be derived with reproducible properties for regression > testing in the future. For now, it serves as a kind of fuzzing test. That function is also pretty long. While sticking to function that are under 50-80 lines is not always easy, this one is over 300 lines long and would definitely benefit being split into many, smaller, functions. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --2f2ythpdnryukdtz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXAk23QAKCRDj7w1vZxhR xdlZAQCPhf8tgFcIo6dEnvyxwargqeuMpqrWfFpvTS6gglw6pwD9Gdhg23yNI6iN GnDMKCn7cOC3iGporgZiEGqR4f2xgQ4= =5qWh -----END PGP SIGNATURE----- --2f2ythpdnryukdtz-- --===============0969937212== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg== --===============0969937212==--