Re: [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local

Ville Syrjälä
2018-12-10T16:02:45Z

On Mon, Dec 10, 2018 at 10:45:36AM +0100, Daniel Vetter wrote:
> On Fri, Dec 07, 2018 at 07:28:16PM +0200, Ville Syrjälä wrote:
> > On Thu, Dec 06, 2018 at 07:27:14PM +0100, Daniel Vetter wrote:
> > > python is brittle otherwise and loves to just blow up. Especially
> > > when you have commits with non-ASCII characters, which gitlab CI
> > > injects into the docker env.
> > >
> > > Strangely we've only seen this go boom on the ninja test target
> > > in the arm64 cross-compile. For paranoia roll it out everywhere.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > ---
> > > .gitlab-ci.yml | 11 ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index efd01be0ea07..5c457ab0431b 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -22,6 +22,7 @@ stages:
> > > build:tests-fedora:
> > > stage: build
> > > script:
> > > + - export LANG=C.UTF-8
> >
> > LC_ALL?
>
> Implied by setting LANG. I checked by looking at the output of locale. I
> honestly have no idea what should be done.

I think LANG only provides the default for the all the LC_ env
variables if you haven't set anything at all, whereas LC_ALL
overrides all of them even if they're set.

unset LC_MESSAGES
unset LANG
unset LC_ALL
LANG=foo locale -> foo
LANG=foo LC_MESSAGES=bar locale -> bar
LANG=foo LC_MESSAGES=bar LC_ALL=hah -> hah

--
Ville Syrjälä
Intel