Re: [igt-dev] [PATCH i-g-t] igt: Remove incorrect get_aperture IOCTL arg

Antonio Argenziano
2018-12-06T21:34:34Z

On 06/12/18 13:22, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-12-06 21:17:04)
>> The local implementation of struct drm_i915_gem_get_aperture is
>> inconsistent with what is defined in the driver and now made its way
>> into IGT's include folder. The correct structure also doesn't contain
>> fields that were being used is some require functions about stolen
>> size. Removed those functions and all tests that used the require, they
>> have been skipping for a while and if none complained they must not be
>> needed.
>
> Or they are for future implementations...

I assumed they were for a proposed implementation that didn't land since
gem_stolen has been there ~3yrs :)

Do you want to keep them? I'm OK with it but maybe we should add a
comment saying there is a plan for extending the IOCTL.

Antonio

> -Chris
>