Re: [igt-dev] [Intel-gfx] [RFT i-g-t 1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

Chris Wilson
2018-12-07T14:06:37Z

Quoting Tvrtko Ursulin (2018-12-07 14:04:05)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> ...
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> lib/igt_core.c | 18 +++
> lib/igt_core.h | 1 +
> tests/i915/gem_shrink.c | 299 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 318 insertions(+)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 64883d6402af..d8fa0c83e279 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1680,6 +1680,24 @@ void igt_stop_helper(struct igt_helper_process *proc)
> assert(helper_was_alive(proc, status));
> }
>
> +/**
> + * igt_try_stop_helper:
> + * @proc: #igt_helper_process structure
> + *
> + * Terminates a helper process if it is still running.
> + */
> +void igt_try_stop_helper(struct igt_helper_process *proc)

General thoughtless comment about try_func is that usually report a
bool.
-Chris