From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: igt-dev@lists.freedesktop.org,
Petri Latvala <petri.latvala@intel.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion
Date: Fri, 7 Dec 2018 10:12:50 +0100 [thread overview]
Message-ID: <20181207091250.bj2ugmaih5wkn3gp@flea> (raw)
In-Reply-To: <20181207090146.4686-1-paul.kocialkowski@bootlin.com>
[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]
On Fri, Dec 07, 2018 at 10:01:46AM +0100, Paul Kocialkowski wrote:
> Pixman requires buffer strides the be aligned to 32-bit words in order
> to create internal representations of buffers. If this condition is not
> met, it will fail and IGT will not be able to report the error cause,
> making it hard to debug the issue.
>
> Add an explicit check in our code prior to calling pixman when
> converting buffer so that the error can be understood if it occurs.
Missing SoB.
Otherwise,
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-07 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 9:01 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
2018-12-07 9:12 ` Maxime Ripard [this message]
2018-12-07 9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-07 15:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207091250.bj2ugmaih5wkn3gp@flea \
--to=maxime.ripard@bootlin.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=petri.latvala@intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox