Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion

Maxime Ripard
2018-12-07T09:13:01Z

[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]

On Fri, Dec 07, 2018 at 10:01:46AM +0100, Paul Kocialkowski wrote:
> Pixman requires buffer strides the be aligned to 32-bit words in order
> to create internal representations of buffers. If this condition is not
> met, it will fail and IGT will not be able to report the error cause,
> making it hard to debug the issue.
>
> Add an explicit check in our code prior to calling pixman when
> converting buffer so that the error can be understood if it occurs.

Missing SoB.

Otherwise,
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]