From: James Ausmus <james.ausmus@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>,
igt-dev@lists.freedesktop.org, ville.syrjala@intel.com,
martin.peres@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case
Date: Fri, 7 Dec 2018 08:11:53 -0800 [thread overview]
Message-ID: <20181207161153.GA7698@jausmus-gentoo-dev6.jf.intel.com> (raw)
In-Reply-To: <53a32a93-9d12-ca3a-c08f-740c77f37ae2@linux.intel.com>
On Wed, Nov 28, 2018 at 02:56:03PM +0100, Maarten Lankhorst wrote:
> Op 28-11-18 om 14:03 schreef Stanislav Lisovskiy:
> > Otherwise we are getting EINVAL as drm requires it
> > at some point.
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108642
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> > tests/kms_properties.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> > index 82d28e9b..eb9cbdda 100644
> > --- a/tests/kms_properties.c
> > +++ b/tests/kms_properties.c
> > @@ -100,7 +100,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
> > ret = drmModeAtomicAddProperty(req, id, prop_id, i);
> > igt_assert(ret >= 0);
> >
> > - ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> > + ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> > igt_assert_eq(ret, 0);
> > }
> > }
>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Lets wait for CI results before committing it. :)
Can this get merged now, or is it still waiting for something
additional?
Thanks!
-James
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-07 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 13:03 [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case Stanislav Lisovskiy
2018-11-28 13:56 ` Maarten Lankhorst
2018-12-07 16:11 ` James Ausmus [this message]
2018-11-28 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-06 11:17 ` [igt-dev] ✓ Fi.CI.BAT: success for Allow a full modeset in kms_properties atomic case (rev2) Patchwork
2018-12-07 5:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207161153.GA7698@jausmus-gentoo-dev6.jf.intel.com \
--to=james.ausmus@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.peres@intel.com \
--cc=stanislav.lisovskiy@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox