Re: [igt-dev] [PATCH i-g-t v2 02/12] chamelium: Pass the pattern block size as argument to helpers

Maxime Ripard
2018-12-14T09:00:14Z

[-- Attachment #1.1: Type: text/plain, Size: 1616 bytes --]

On Thu, Dec 13, 2018 at 04:55:23PM +0100, Paul Kocialkowski wrote:
> This adds a new block size argument to the pattern generation helpers so
> that different sizes of blocks can be used.
>
> In the future, this allows us to use different block sizes when testing
> overlay planes, making it visually explicit what is part of the main
> plane and what is part of the overlay plane.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> ---
> tests/kms_chamelium.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index b8cab9275bec..7d95a8bc52f3 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -490,7 +490,7 @@ enable_output(data_t *data,
>
> static void chamelium_paint_xr24_pattern(uint32_t *data,
> size_t width, size_t height,
> - size_t stride)
> + size_t stride, size_t block_size)
> {
> uint32_t colors[] = { 0xff000000,
> 0xffff0000,
> @@ -501,11 +501,12 @@ static void chamelium_paint_xr24_pattern(uint32_t *data,
>
> for (i = 0; i < height; i++)
> for (j = 0; j < width; j++)
> - *(data + i * stride / 4 + j) = colors[((j / 64) + (i / 64)) % 5];
> + *(data + i * stride / 4 + j) = colors[((j / block_size) + (i / block_size)) % 5];

That line really doesn't fit on 80 characters anymore. I guess you
could split the pointer arithmetic to a new line.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]