From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
Eben Upton <eben@raspberrypi.org>
Subject: [igt-dev] [PATCH i-g-t 4/6] chamelium: Pass the pattern block size as argument to helpers
Date: Thu, 27 Dec 2018 15:57:39 +0100 [thread overview]
Message-ID: <20181227145741.28096-5-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20181227145741.28096-1-paul.kocialkowski@bootlin.com>
This adds a new block size argument to the pattern generation helpers so
that different sizes of blocks can be used.
In the future, this allows us to use different block sizes when testing
overlay planes, making it visually explicit what is part of the main
plane and what is part of the overlay plane.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
tests/kms_chamelium.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 42ea490cf25a..2d848c2f0620 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -490,7 +490,7 @@ enable_output(data_t *data,
static void chamelium_paint_xr24_pattern(uint32_t *data,
size_t width, size_t height,
- size_t stride)
+ size_t stride, size_t block_size)
{
uint32_t colors[] = { 0xff000000,
0xffff0000,
@@ -501,11 +501,12 @@ static void chamelium_paint_xr24_pattern(uint32_t *data,
for (i = 0; i < height; i++)
for (j = 0; j < width; j++)
- *(data + i * stride / 4 + j) = colors[((j / 64) + (i / 64)) % 5];
+ *(data + i * stride / 4 + j) = colors[((j / block_size) + (i / block_size)) % 5];
}
static int chamelium_get_pattern_fb(data_t *data, size_t width, size_t height,
- uint32_t fourcc, struct igt_fb *fb)
+ uint32_t fourcc, size_t block_size,
+ struct igt_fb *fb)
{
int fb_id;
void *ptr;
@@ -519,7 +520,8 @@ static int chamelium_get_pattern_fb(data_t *data, size_t width, size_t height,
ptr = igt_fb_map_buffer(fb->fd, fb);
igt_assert(ptr);
- chamelium_paint_xr24_pattern(ptr, width, height, fb->strides[0]);
+ chamelium_paint_xr24_pattern(ptr, width, height, fb->strides[0],
+ block_size);
igt_fb_unmap_buffer(fb, ptr);
return fb_id;
@@ -537,7 +539,7 @@ static void do_test_display_crc(data_t *data, struct chamelium_port *port,
int frame_id;
fb_id = chamelium_get_pattern_fb(data, mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888, &fb);
+ DRM_FORMAT_XRGB8888, 64, &fb);
igt_assert(fb_id > 0);
frame_id = igt_fb_convert(&frame_fb, &fb, fourcc);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-27 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 1/6] chamelium: Fix inverted xr24 pattern paint dimensions Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 2/6] chamelium: Pass and use stride for xr24 pattern paint Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 3/6] chamelium: Pass dimensions instead of mode to pattern generation helper Paul Kocialkowski
2018-12-27 14:57 ` Paul Kocialkowski [this message]
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 5/6] chamelium: Debug-print CRCs when comparing them and dumping frames Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 6/6] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
2018-12-27 16:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Preliminary patches for chamelium improvements Patchwork
2018-12-27 17:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-31 8:35 ` [igt-dev] [PATCH i-g-t 0/6] " Arkadiusz Hiler
2019-01-02 8:37 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227145741.28096-5-paul.kocialkowski@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=eben@raspberrypi.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox