From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Petri Latvala <petri.latvala@intel.com>,
igt-dev@lists.freedesktop.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_edid_template: Fix parenthesis for vertical pulse coding
Date: Mon, 7 Jan 2019 16:39:50 +0200 [thread overview]
Message-ID: <20190107143950.GP20097@intel.com> (raw)
In-Reply-To: <20190103165448.23748-1-paul.kocialkowski@bootlin.com>
On Thu, Jan 03, 2019 at 05:54:48PM +0100, Paul Kocialkowski wrote:
> Add missing parenthesis in the macro coding the vertical pulse high
> bits. Without them, the shift takes precedence over the logical and
> operation, which is not how these bits should be coded according to
> the spec.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_edid_template.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_edid_template.h b/lib/igt_edid_template.h
> index de421e080a88..8dbd19caea4c 100644
> --- a/lib/igt_edid_template.h
> +++ b/lib/igt_edid_template.h
> @@ -8,7 +8,7 @@
> #define op(ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \
> (((vo) & 0xf) << 4) | ((vp) & 0xf), \
> (((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \
> - | (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4)
> + | (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)
>
> static unsigned char EDID_NAME[EDID_LENGTH] = {
> 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, /* header */
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-07 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 16:54 [igt-dev] [PATCH i-g-t] lib/igt_edid_template: Fix parenthesis for vertical pulse coding Paul Kocialkowski
2019-01-03 17:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-03 18:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-07 14:39 ` Ville Syrjälä [this message]
2019-01-14 14:20 ` [igt-dev] [PATCH i-g-t] " Paul Kocialkowski
2019-01-14 19:25 ` Antonio Argenziano
2019-01-15 9:29 ` Jani Nikula
2019-01-18 15:17 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107143950.GP20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=petri.latvala@intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox