From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id F05F76F34F for ; Thu, 10 Jan 2019 14:38:59 +0000 (UTC) Date: Thu, 10 Jan 2019 16:38:54 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20190110143854.GX20097@intel.com> References: <20190108152001.5367-4-maxime.ripard@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t v2 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski Cc: Petri Latvala , eben@raspberrypi.org, igt-dev@lists.freedesktop.org, Thomas Petazzoni List-ID: T24gVGh1LCBKYW4gMTAsIDIwMTkgYXQgMTE6MTA6MDlBTSArMDEwMCwgUGF1bCBLb2NpYWxrb3dz a2kgd3JvdGU6Cj4gT24gVHVlLCAyMDE5LTAxLTA4IGF0IDE2OjE5ICswMTAwLCBNYXhpbWUgUmlw YXJkIHdyb3RlOgo+ID4gVGhlIFlVViBidWZmZXIgYWxsb2NhdGlvbiBwYXRoIGZvciB0aGUgaTkx NSBkcml2ZXIgYWxzbyBoYXMgc29tZSBjb2RlIHRvCj4gPiBjbGVhciBhIFlVViBidWZmZXIuCj4g PiAKPiA+IEFzIHRoYXQgaXMgZ29pbmcgdG8gYmUgdXNlZnVsIGZvciBhbGwgdGhlIG90aGVyIGRy aXZlcnMsIGxldCdzIG1vdmUgaXQgdG8KPiA+IGEgc2VwYXJhdGUgZnVuY3Rpb24uCj4gPgo+ID4g U2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4K PiAKPiBJJ20gbm90IHJlYWxseSBzdXJlIHdoeSBjbGVhcmluZyB0aGUgYnVmZmVycyBpcyBhIHVz ZWZ1bCB0aGluZyB0byBkbwo+IGFuZCB3aHkgd2Ugc2hvdWxkIG9ubHkgZG8gaXQgZm9yIFlVViBh bmQgbm90IFJHQiBmb3JtYXRzLgoKMCA9IGJsYWNrIGZvciBSR0IsIDAgIT0gYmxhY2sgZm9yIFlV Vi4gVGhlIG1lbXNldCB3YXMganVzdCB0byBtYWtlCnRoaW5ncyBtb3JlIGNvbnNpc3RlbnQuIEJ1 dCBub3Qgc3VyZSBpZiBhbnkgdGVzdCB3b3VsZCBhY3R1YWxseQpmYWlsIGlmIHdlIGp1c3QgZHJv cCB0aGUgbWVtc2V0LgoKPiAKPiBBbnl3YXksIHNpbmNlIHRoaXMgY29kZSB3YXMgYWxyZWFkeSB0 aGVyZSBhbmQgdGhlIHJlZmFjdG9yaW5nCj4gZGVmaW5pdGVseSBtYWtlcyBzZW5zZToKPiAKPiBS ZXZpZXdlZC1ieTogUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4u Y29tPgo+IAo+IENoZWVycywKPiAKPiBQYXVsCj4gCj4gPiAtLS0KPiA+ICBsaWIvaWd0X2ZiLmMg fCA4MCArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQo+ ID4gCj4gPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gPiBpbmRl eCA0NTY5MWZkNDQxZDkuLmQ2OWMzZmIyZDM4ZCAxMDA2NDQKPiA+IC0tLSBhL2xpYi9pZ3RfZmIu Ywo+ID4gKysrIGIvbGliL2lndF9mYi5jCj4gPiBAQCAtNDg0LDYgKzQ4NCw0NyBAQCB1aW50NjRf dCBpZ3RfZmJfdGlsaW5nX3RvX21vZCh1aW50NjRfdCB0aWxpbmcpCj4gPiAgCX0KPiA+ICB9Cj4g PiAgCj4gPiArc3RhdGljIHZvaWQgY2xlYXJfeXV2X2J1ZmZlcihzdHJ1Y3QgaWd0X2ZiICpmYikK PiA+ICt7Cj4gPiArCWJvb2wgZnVsbF9yYW5nZSA9IGZiLT5jb2xvcl9yYW5nZSA9PSBJR1RfQ09M T1JfWUNCQ1JfRlVMTF9SQU5HRTsKPiA+ICsJdm9pZCAqcHRyOwo+ID4gKwo+ID4gKwlpZ3RfYXNz ZXJ0KGlndF9mb3JtYXRfaXNfeXV2KGZiLT5kcm1fZm9ybWF0KSk7Cj4gPiArCj4gPiArCS8qIEVu c3VyZSB0aGUgZnJhbWVidWZmZXIgaXMgcHJlYWxsb2NhdGVkICovCj4gPiArCXB0ciA9IGlndF9m Yl9tYXBfYnVmZmVyKGZiLT5mZCwgZmIpOwo+ID4gKwlpZ3RfYXNzZXJ0KCoodWludDMyX3QgKilw dHIgPT0gMCk7Cj4gPiArCj4gPiArCXN3aXRjaCAoZmItPmRybV9mb3JtYXQpIHsKPiA+ICsJY2Fz ZSBEUk1fRk9STUFUX05WMTI6Cj4gPiArCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4g PiArCQkgICAgICAgZnVsbF9yYW5nZSA/IDB4MDAgOiAweDEwLAo+ID4gKwkJICAgICAgIGZiLT5z dHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSk7Cj4gPiArCQltZW1zZXQocHRyICsgZmIt Pm9mZnNldHNbMV0sCj4gPiArCQkgICAgICAgMHg4MCwKPiA+ICsJCSAgICAgICBmYi0+c3RyaWRl c1sxXSAqIGZiLT5wbGFuZV9oZWlnaHRbMV0pOwo+ID4gKwkJYnJlYWs7Cj4gPiArCWNhc2UgRFJN X0ZPUk1BVF9YWVVWODg4ODoKPiA+ICsJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sIGZ1 bGxfcmFuZ2UgPyAweDAwMDA4MDgwIDogMHgwMDEwODA4MCwKPiA+ICsJCQlmYi0+c3RyaWRlc1sw XSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ID4gKwkJYnJlYWs7 Cj4gPiArCWNhc2UgRFJNX0ZPUk1BVF9ZVVlWOgo+ID4gKwljYXNlIERSTV9GT1JNQVRfWVZZVToK PiA+ICsJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gPiArCQkJZnVsbF9yYW5nZSA/ IDB4ODAwMDgwMDAgOiAweDgwMTA4MDEwLAo+ID4gKwkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBs YW5lX2hlaWdodFswXSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gPiArCQlicmVhazsKPiA+ICsJY2Fz ZSBEUk1fRk9STUFUX1VZVlk6Cj4gPiArCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+ID4gKwkJd21l bXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiA+ICsJCQlmdWxsX3JhbmdlID8gMHgwMDgwMDA4 MCA6IDB4MTA4MDEwODAsCj4gPiArCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0 WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+ICsJCWJyZWFrOwo+ID4gKwl9Cj4gPiArCj4gPiAr CWlndF9mYl91bm1hcF9idWZmZXIoZmIsIHB0cik7Cj4gPiArfQo+ID4gKwo+ID4gIC8qIGhlbHBl cnMgdG8gY3JlYXRlIG5pY2UtbG9va2luZyBmcmFtZWJ1ZmZlcnMgKi8KPiA+ICBzdGF0aWMgaW50 IGNyZWF0ZV9ib19mb3JfZmIoc3RydWN0IGlndF9mYiAqZmIpCj4gPiAgewo+ID4gQEAgLTUwMSw1 MCArNTQyLDEzIEBAIHN0YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0X2ZiICpm YikKPiA+ICAJCWZiLT5pc19kdW1iID0gZmFsc2U7Cj4gPiAgCj4gPiAgCQlpZiAoaXNfaTkxNV9k ZXZpY2UoZmQpKSB7Cj4gPiAtCQkJdm9pZCAqcHRyOwo+ID4gLQkJCWJvb2wgZnVsbF9yYW5nZSA9 IGZiLT5jb2xvcl9yYW5nZSA9PSBJR1RfQ09MT1JfWUNCQ1JfRlVMTF9SQU5HRTsKPiA+ICAKPiA+ ICAJCQlmYi0+Z2VtX2hhbmRsZSA9IGdlbV9jcmVhdGUoZmQsIGZiLT5zaXplKTsKPiA+ICAKPiA+ ICAJCQlnZW1fc2V0X3RpbGluZyhmZCwgZmItPmdlbV9oYW5kbGUsCj4gPiAgCQkJCSAgICAgICBp Z3RfZmJfbW9kX3RvX3RpbGluZyhmYi0+dGlsaW5nKSwKPiA+ICAJCQkJICAgICAgIGZiLT5zdHJp ZGVzWzBdKTsKPiA+IC0KPiA+IC0JCQlnZW1fc2V0X2RvbWFpbihmZCwgZmItPmdlbV9oYW5kbGUs Cj4gPiAtCQkJCSAgICAgICBJOTE1X0dFTV9ET01BSU5fR1RULCBJOTE1X0dFTV9ET01BSU5fR1RU KTsKPiA+IC0KPiA+IC0JCQkvKiBFbnN1cmUgdGhlIGZyYW1lYnVmZmVyIGlzIHByZWFsbG9jYXRl ZCAqLwo+ID4gLQkJCXB0ciA9IGdlbV9tbWFwX19ndHQoZmQsIGZiLT5nZW1faGFuZGxlLAo+ID4g LQkJCQkJICAgIGZiLT5zaXplLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRFKTsKPiA+IC0JCQlpZ3Rf YXNzZXJ0KCoodWludDMyX3QgKilwdHIgPT0gMCk7Cj4gPiAtCj4gPiAtCQkJc3dpdGNoIChmYi0+ ZHJtX2Zvcm1hdCkgewo+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9OVjEyOgo+ID4gLQkJCQltZW1z ZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gPiAtCQkJCSAgICAgICBmdWxsX3JhbmdlID8gMHgw MCA6IDB4MTAsCj4gPiAtCQkJCSAgICAgICBmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWln aHRbMF0pOwo+ID4gLQkJCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNbMV0sCj4gPiAtCQkJCSAg ICAgICAweDgwLAo+ID4gLQkJCQkgICAgICAgZmItPnN0cmlkZXNbMV0gKiBmYi0+cGxhbmVfaGVp Z2h0WzFdKTsKPiA+IC0JCQkJYnJlYWs7Cj4gPiAtCQkJY2FzZSBEUk1fRk9STUFUX1hZVVY4ODg4 Ogo+ID4gLQkJCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLCBmdWxsX3JhbmdlID8gMHgw MDAwODA4MCA6IDB4MDAxMDgwODAsCj4gPiAtCQkJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFu ZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ID4gLQkJCQlicmVhazsKPiA+IC0JCQlj YXNlIERSTV9GT1JNQVRfWVVZVjoKPiA+IC0JCQljYXNlIERSTV9GT1JNQVRfWVZZVToKPiA+IC0J CQkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiA+IC0JCQkJCWZ1bGxfcmFuZ2UgPyAw eDgwMDA4MDAwIDogMHg4MDEwODAxMCwKPiA+IC0JCQkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBs YW5lX2hlaWdodFswXSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gPiAtCQkJCWJyZWFrOwo+ID4gLQkJ CWNhc2UgRFJNX0ZPUk1BVF9VWVZZOgo+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+ID4g LQkJCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gLQkJCQkJZnVsbF9yYW5nZSA/ IDB4MDA4MDAwODAgOiAweDEwODAxMDgwLAo+ID4gLQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+ cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+IC0JCQkJYnJlYWs7Cj4gPiAt CQkJfQo+ID4gLQkJCWdlbV9tdW5tYXAocHRyLCBmYi0+c2l6ZSk7Cj4gPiArCQkJY2xlYXJfeXV2 X2J1ZmZlcihmZCk7Cj4gPiAgCj4gPiAgCQkJcmV0dXJuIGZiLT5nZW1faGFuZGxlOwo+ID4gIAkJ fSBlbHNlIHsKPiAtLSAKPiBQYXVsIEtvY2lhbGtvd3NraSwgQm9vdGxpbgo+IEVtYmVkZGVkIExp bnV4IGFuZCBrZXJuZWwgZW5naW5lZXJpbmcKPiBodHRwczovL2Jvb3RsaW4uY29tCgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRl dgo=