From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, Martin Peres <martin.peres@free.fr>
Subject: Re: [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU)
Date: Mon, 14 Jan 2019 12:55:45 +0200 [thread overview]
Message-ID: <20190114105545.GA17124@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190111161942.29975-1-chris@chris-wilson.co.uk>
On Fri, Jan 11, 2019 at 04:19:42PM +0000, Chris Wilson wrote:
> Just use the normal library function, with the normal warning message
> for an unmatched GPU so that CI buglog can filter it.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109315
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@free.fr>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/amdgpu/amd_basic.c | 3 +--
> tests/amdgpu/amd_cs_nop.c | 3 +--
> tests/amdgpu/amd_prime.c | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/tests/amdgpu/amd_basic.c b/tests/amdgpu/amd_basic.c
> index 9f21de65b..d3c060e32 100644
> --- a/tests/amdgpu/amd_basic.c
> +++ b/tests/amdgpu/amd_basic.c
> @@ -1384,8 +1384,7 @@ igt_main
> uint32_t major, minor;
> int err;
>
> - fd = __drm_open_driver(DRIVER_AMDGPU);
> - igt_require(fd >= 0);
> + fd = drm_open_driver(DRIVER_AMDGPU);
>
> err = amdgpu_device_initialize(fd, &major, &minor, &device);
> igt_require(err == 0);
> diff --git a/tests/amdgpu/amd_cs_nop.c b/tests/amdgpu/amd_cs_nop.c
> index c5ea66aa5..46f4b7c65 100644
> --- a/tests/amdgpu/amd_cs_nop.c
> +++ b/tests/amdgpu/amd_cs_nop.c
> @@ -219,8 +219,7 @@ igt_main
> uint32_t major, minor;
> int err;
>
> - fd = __drm_open_driver(DRIVER_AMDGPU);
> - igt_require(fd >= 0);
> + fd = drm_open_driver(DRIVER_AMDGPU);
>
> err = amdgpu_device_initialize(fd, &major, &minor, &device);
> igt_require(err == 0);
> diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
> index 518c88963..dc71ac70c 100644
> --- a/tests/amdgpu/amd_prime.c
> +++ b/tests/amdgpu/amd_prime.c
> @@ -437,7 +437,7 @@ igt_main
> igt_require_gem(i915);
> igt_require(gem_has_exec_fence(i915));
>
> - amd = __drm_open_driver(DRIVER_AMDGPU);
> + amd = drm_open_driver(DRIVER_AMDGPU);
> err = amdgpu_device_initialize(amd, &major, &minor, &device);
> igt_require(err == 0);
> }
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-01-14 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 16:19 [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU) Chris Wilson
2019-01-11 17:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-11 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-14 10:55 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114105545.GA17124@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox