From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D42D6E361 for ; Mon, 14 Jan 2019 16:40:16 +0000 (UTC) Date: Mon, 14 Jan 2019 18:40:10 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20190114164010.GC20097@intel.com> References: <20190108152001.5367-4-maxime.ripard@bootlin.com> <20190110143854.GX20097@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t v2 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski Cc: Petri Latvala , eben@raspberrypi.org, igt-dev@lists.freedesktop.org, Thomas Petazzoni List-ID: T24gTW9uLCBKYW4gMTQsIDIwMTkgYXQgMDQ6MTM6MDJQTSArMDEwMCwgUGF1bCBLb2NpYWxrb3dz a2kgd3JvdGU6Cj4gSGksCj4gCj4gT24gVGh1LCAyMDE5LTAxLTEwIGF0IDE2OjM4ICswMjAwLCBW aWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUaHUsIEphbiAxMCwgMjAxOSBhdCAxMToxMDow OUFNICswMTAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90ZToKPiA+ID4gT24gVHVlLCAyMDE5LTAx LTA4IGF0IDE2OjE5ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ID4gPiA+IFRoZSBZVVYg YnVmZmVyIGFsbG9jYXRpb24gcGF0aCBmb3IgdGhlIGk5MTUgZHJpdmVyIGFsc28gaGFzIHNvbWUg Y29kZSB0bwo+ID4gPiA+IGNsZWFyIGEgWVVWIGJ1ZmZlci4KPiA+ID4gPiAKPiA+ID4gPiBBcyB0 aGF0IGlzIGdvaW5nIHRvIGJlIHVzZWZ1bCBmb3IgYWxsIHRoZSBvdGhlciBkcml2ZXJzLCBsZXQn cyBtb3ZlIGl0IHRvCj4gPiA+ID4gYSBzZXBhcmF0ZSBmdW5jdGlvbi4KPiA+ID4gPiAKPiA+ID4g PiBTaWduZWQtb2ZmLWJ5OiBNYXhpbWUgUmlwYXJkIDxtYXhpbWUucmlwYXJkQGJvb3RsaW4uY29t Pgo+ID4gPiAKPiA+ID4gSSdtIG5vdCByZWFsbHkgc3VyZSB3aHkgY2xlYXJpbmcgdGhlIGJ1ZmZl cnMgaXMgYSB1c2VmdWwgdGhpbmcgdG8gZG8KPiA+ID4gYW5kIHdoeSB3ZSBzaG91bGQgb25seSBk byBpdCBmb3IgWVVWIGFuZCBub3QgUkdCIGZvcm1hdHMuCj4gPiAKPiA+IDAgPSBibGFjayBmb3Ig UkdCLCAwICE9IGJsYWNrIGZvciBZVVYuIFRoZSBtZW1zZXQgd2FzIGp1c3QgdG8gbWFrZQo+ID4g dGhpbmdzIG1vcmUgY29uc2lzdGVudC4gQnV0IG5vdCBzdXJlIGlmIGFueSB0ZXN0IHdvdWxkIGFj dHVhbGx5Cj4gPiBmYWlsIGlmIHdlIGp1c3QgZHJvcCB0aGUgbWVtc2V0Lgo+IAo+IFJpZ2h0LCBJ IHVuZGVyc3RhbmQgdGhhdCB0aGlzIGlzIHJlcXVpcmVkIGZvciBzZXR0aW5nIHRoZSBmcmFtZWJ1 ZmZlcgo+IHRvIGJsYWNrLCBidXQgSSdtIGp1c3Qgd29uZGVyaW5nIHdoeSB0aGlzIGhhcyB0byBi ZSBkb25lIGluIHRoZSBmaXJzdAo+IHBsYWNlLgo+IAo+IEFzIGZhciBhcyBJIGtub3csIChSR0Ip IGJ1ZmZlcnMgYWxsb2NhdGVkIHdpdGggR0VNIGFyZSBub3QgemVyby1lZCBieQo+IHRoZSBhbGxv Y2F0b3IsCgpUaGV5IGFyZSB6ZXJvZWQuIFlvdSB3b3VsZG4ndCB3YW50IHRoZSBrZXJuZWwgdG8g bGVhayByYW5kb20KbWVtb3J5IGNvbnRlbnRzIGFsbCBvdmVyLgoKPiBub3IgYnkgYW55IGNvbXBv bmVudCBpbiBJR1QuIFNvIEknbSB3b25kZXJpbmcgd2h5IHdlJ3JlCj4gdGFraW5nIHRoZSBleHRy YSB0aW1lIGZvciBjbGVhcmluZyBidWZmZXJzIGluIHRoZSBZVVYgY2FzZS4KPiAKPiBDaGVlcnMs Cj4gCj4gUGF1bAo+IAo+ID4gPiBBbnl3YXksIHNpbmNlIHRoaXMgY29kZSB3YXMgYWxyZWFkeSB0 aGVyZSBhbmQgdGhlIHJlZmFjdG9yaW5nCj4gPiA+IGRlZmluaXRlbHkgbWFrZXMgc2Vuc2U6Cj4g PiA+IAo+ID4gPiBSZXZpZXdlZC1ieTogUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293 c2tpQGJvb3RsaW4uY29tPgo+ID4gPiAKPiA+ID4gQ2hlZXJzLAo+ID4gPiAKPiA+ID4gUGF1bAo+ ID4gPiAKPiA+ID4gPiAtLS0KPiA+ID4gPiAgbGliL2lndF9mYi5jIHwgODAgKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiA+ICAxIGZpbGUg Y2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ ID4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+ID4gPiA+IGluZGV4 IDQ1NjkxZmQ0NDFkOS4uZDY5YzNmYjJkMzhkIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2xpYi9pZ3Rf ZmIuYwo+ID4gPiA+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+ID4gPiA+IEBAIC00ODQsNiArNDg0LDQ3 IEBAIHVpbnQ2NF90IGlndF9mYl90aWxpbmdfdG9fbW9kKHVpbnQ2NF90IHRpbGluZykKPiA+ID4g PiAgCX0KPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiArc3RhdGljIHZvaWQgY2xlYXJfeXV2 X2J1ZmZlcihzdHJ1Y3QgaWd0X2ZiICpmYikKPiA+ID4gPiArewo+ID4gPiA+ICsJYm9vbCBmdWxs X3JhbmdlID0gZmItPmNvbG9yX3JhbmdlID09IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JBTkdFOwo+ ID4gPiA+ICsJdm9pZCAqcHRyOwo+ID4gPiA+ICsKPiA+ID4gPiArCWlndF9hc3NlcnQoaWd0X2Zv cm1hdF9pc195dXYoZmItPmRybV9mb3JtYXQpKTsKPiA+ID4gPiArCj4gPiA+ID4gKwkvKiBFbnN1 cmUgdGhlIGZyYW1lYnVmZmVyIGlzIHByZWFsbG9jYXRlZCAqLwo+ID4gPiA+ICsJcHRyID0gaWd0 X2ZiX21hcF9idWZmZXIoZmItPmZkLCBmYik7Cj4gPiA+ID4gKwlpZ3RfYXNzZXJ0KCoodWludDMy X3QgKilwdHIgPT0gMCk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJc3dpdGNoIChmYi0+ZHJtX2Zvcm1h dCkgewo+ID4gPiA+ICsJY2FzZSBEUk1fRk9STUFUX05WMTI6Cj4gPiA+ID4gKwkJbWVtc2V0KHB0 ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gPiA+ICsJCSAgICAgICBmdWxsX3JhbmdlID8gMHgwMCA6 IDB4MTAsCj4gPiA+ID4gKwkJICAgICAgIGZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdo dFswXSk7Cj4gPiA+ID4gKwkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzFdLAo+ID4gPiA+ICsJ CSAgICAgICAweDgwLAo+ID4gPiA+ICsJCSAgICAgICBmYi0+c3RyaWRlc1sxXSAqIGZiLT5wbGFu ZV9oZWlnaHRbMV0pOwo+ID4gPiA+ICsJCWJyZWFrOwo+ID4gPiA+ICsJY2FzZSBEUk1fRk9STUFU X1hZVVY4ODg4Ogo+ID4gPiA+ICsJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sIGZ1bGxf cmFuZ2UgPyAweDAwMDA4MDgwIDogMHgwMDEwODA4MCwKPiA+ID4gPiArCQkJZmItPnN0cmlkZXNb MF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+ID4gPiArCQli cmVhazsKPiA+ID4gPiArCWNhc2UgRFJNX0ZPUk1BVF9ZVVlWOgo+ID4gPiA+ICsJY2FzZSBEUk1f Rk9STUFUX1lWWVU6Cj4gPiA+ID4gKwkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiA+ ID4gPiArCQkJZnVsbF9yYW5nZSA/IDB4ODAwMDgwMDAgOiAweDgwMTA4MDEwLAo+ID4gPiA+ICsJ CQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkp Owo+ID4gPiA+ICsJCWJyZWFrOwo+ID4gPiA+ICsJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gPiA+ ID4gKwljYXNlIERSTV9GT1JNQVRfVllVWToKPiA+ID4gPiArCQl3bWVtc2V0KHB0ciArIGZiLT5v ZmZzZXRzWzBdLAo+ID4gPiA+ICsJCQlmdWxsX3JhbmdlID8gMHgwMDgwMDA4MCA6IDB4MTA4MDEw ODAsCj4gPiA+ID4gKwkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAvIHNp emVvZih3Y2hhcl90KSk7Cj4gPiA+ID4gKwkJYnJlYWs7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwo+ ID4gPiA+ICsJaWd0X2ZiX3VubWFwX2J1ZmZlcihmYiwgcHRyKTsKPiA+ID4gPiArfQo+ID4gPiA+ ICsKPiA+ID4gPiAgLyogaGVscGVycyB0byBjcmVhdGUgbmljZS1sb29raW5nIGZyYW1lYnVmZmVy cyAqLwo+ID4gPiA+ICBzdGF0aWMgaW50IGNyZWF0ZV9ib19mb3JfZmIoc3RydWN0IGlndF9mYiAq ZmIpCj4gPiA+ID4gIHsKPiA+ID4gPiBAQCAtNTAxLDUwICs1NDIsMTMgQEAgc3RhdGljIGludCBj cmVhdGVfYm9fZm9yX2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ID4gPiA+ICAJCWZiLT5pc19kdW1i ID0gZmFsc2U7Cj4gPiA+ID4gIAo+ID4gPiA+ICAJCWlmIChpc19pOTE1X2RldmljZShmZCkpIHsK PiA+ID4gPiAtCQkJdm9pZCAqcHRyOwo+ID4gPiA+IC0JCQlib29sIGZ1bGxfcmFuZ2UgPSBmYi0+ Y29sb3JfcmFuZ2UgPT0gSUdUX0NPTE9SX1lDQkNSX0ZVTExfUkFOR0U7Cj4gPiA+ID4gIAo+ID4g PiA+ICAJCQlmYi0+Z2VtX2hhbmRsZSA9IGdlbV9jcmVhdGUoZmQsIGZiLT5zaXplKTsKPiA+ID4g PiAgCj4gPiA+ID4gIAkJCWdlbV9zZXRfdGlsaW5nKGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiA+ID4g PiAgCQkJCSAgICAgICBpZ3RfZmJfbW9kX3RvX3RpbGluZyhmYi0+dGlsaW5nKSwKPiA+ID4gPiAg CQkJCSAgICAgICBmYi0+c3RyaWRlc1swXSk7Cj4gPiA+ID4gLQo+ID4gPiA+IC0JCQlnZW1fc2V0 X2RvbWFpbihmZCwgZmItPmdlbV9oYW5kbGUsCj4gPiA+ID4gLQkJCQkgICAgICAgSTkxNV9HRU1f RE9NQUlOX0dUVCwgSTkxNV9HRU1fRE9NQUlOX0dUVCk7Cj4gPiA+ID4gLQo+ID4gPiA+IC0JCQkv KiBFbnN1cmUgdGhlIGZyYW1lYnVmZmVyIGlzIHByZWFsbG9jYXRlZCAqLwo+ID4gPiA+IC0JCQlw dHIgPSBnZW1fbW1hcF9fZ3R0KGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiA+ID4gPiAtCQkJCQkgICAg ZmItPnNpemUsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUpOwo+ID4gPiA+IC0JCQlpZ3RfYXNzZXJ0 KCoodWludDMyX3QgKilwdHIgPT0gMCk7Cj4gPiA+ID4gLQo+ID4gPiA+IC0JCQlzd2l0Y2ggKGZi LT5kcm1fZm9ybWF0KSB7Cj4gPiA+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9OVjEyOgo+ID4gPiA+ IC0JCQkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gPiA+IC0JCQkJICAgICAgIGZ1 bGxfcmFuZ2UgPyAweDAwIDogMHgxMCwKPiA+ID4gPiAtCQkJCSAgICAgICBmYi0+c3RyaWRlc1sw XSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0pOwo+ID4gPiA+IC0JCQkJbWVtc2V0KHB0ciArIGZiLT5v ZmZzZXRzWzFdLAo+ID4gPiA+IC0JCQkJICAgICAgIDB4ODAsCj4gPiA+ID4gLQkJCQkgICAgICAg ZmItPnN0cmlkZXNbMV0gKiBmYi0+cGxhbmVfaGVpZ2h0WzFdKTsKPiA+ID4gPiAtCQkJCWJyZWFr Owo+ID4gPiA+IC0JCQljYXNlIERSTV9GT1JNQVRfWFlVVjg4ODg6Cj4gPiA+ID4gLQkJCQl3bWVt c2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLCBmdWxsX3JhbmdlID8gMHgwMDAwODA4MCA6IDB4MDAx MDgwODAsCj4gPiA+ID4gLQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBd IC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+ID4gPiAtCQkJCWJyZWFrOwo+ID4gPiA+IC0JCQljYXNl IERSTV9GT1JNQVRfWVVZVjoKPiA+ID4gPiAtCQkJY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4gPiA+ ID4gLQkJCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gPiA+IC0JCQkJCWZ1bGxf cmFuZ2UgPyAweDgwMDA4MDAwIDogMHg4MDEwODAxMCwKPiA+ID4gPiAtCQkJCQlmYi0+c3RyaWRl c1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ID4gPiA+IC0J CQkJYnJlYWs7Cj4gPiA+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9VWVZZOgo+ID4gPiA+IC0JCQlj YXNlIERSTV9GT1JNQVRfVllVWToKPiA+ID4gPiAtCQkJCXdtZW1zZXQocHRyICsgZmItPm9mZnNl dHNbMF0sCj4gPiA+ID4gLQkJCQkJZnVsbF9yYW5nZSA/IDB4MDA4MDAwODAgOiAweDEwODAxMDgw LAo+ID4gPiA+IC0JCQkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAvIHNp emVvZih3Y2hhcl90KSk7Cj4gPiA+ID4gLQkJCQlicmVhazsKPiA+ID4gPiAtCQkJfQo+ID4gPiA+ IC0JCQlnZW1fbXVubWFwKHB0ciwgZmItPnNpemUpOwo+ID4gPiA+ICsJCQljbGVhcl95dXZfYnVm ZmVyKGZkKTsKPiA+ID4gPiAgCj4gPiA+ID4gIAkJCXJldHVybiBmYi0+Z2VtX2hhbmRsZTsKPiA+ ID4gPiAgCQl9IGVsc2Ugewo+ID4gPiAtLSAKPiA+ID4gUGF1bCBLb2NpYWxrb3dza2ksIEJvb3Rs aW4KPiA+ID4gRW1iZWRkZWQgTGludXggYW5kIGtlcm5lbCBlbmdpbmVlcmluZwo+ID4gPiBodHRw czovL2Jvb3RsaW4uY29tCj4gLS0gCj4gUGF1bCBLb2NpYWxrb3dza2ksIEJvb3RsaW4KPiBFbWJl ZGRlZCBMaW51eCBhbmQga2VybmVsIGVuZ2luZWVyaW5nCj4gaHR0cHM6Ly9ib290bGluLmNvbQoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2lndC1kZXYK