From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id EA6918922A
 for <igt-dev@lists.freedesktop.org>; Tue, 15 Jan 2019 13:32:03 +0000 (UTC)
Date: Tue, 15 Jan 2019 15:32:02 +0200
From: Andi Shyti <andi.shyti@intel.com>
Message-ID: <20190115133201.GA2052@intel.intel>
References: <20190115123511.11474-1-andi.shyti@intel.com>
 <20190115123511.11474-3-andi.shyti@intel.com>
 <154755723693.30063.8985044656295200164@skylake-alporthouse-com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <154755723693.30063.8985044656295200164@skylake-alporthouse-com>
Subject: Re: [igt-dev] [RFC PATCH v4 2/3] lib: implement new engine
 discovery interface
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
List-ID: <igt-dev@lists.freedesktop.org>

SGkgQ2hyaXMsCgp0aGFua3MgZm9yIGxvb2tpbmcgaW50byB0aGlzIQoKPiA+IEBAIC0zMDEsNyAr
MzAxLDcgQEAgc3RhdGljIGludCBfX29wZW5fZHJpdmVyKGNvbnN0IGNoYXIgKmJhc2UsIGludCBv
ZmZzZXQsIHVuc2lnbmVkIGludCBjaGlwc2V0KQo+ID4gIAo+ID4gICAgICAgICBmZCA9IF9fc2Vh
cmNoX2FuZF9vcGVuKGJhc2UsIG9mZnNldCwgY2hpcHNldCk7Cj4gPiAgICAgICAgIGlmIChmZCAh
PSAtMSkKPiA+IC0gICAgICAgICAgICAgICByZXR1cm4gZmQ7Cj4gPiArICAgICAgICAgICAgICAg
Z290byBzZXRfZW5naW5lc19hbmRfcmV0dXJuOwo+ID4gIAo+ID4gICAgICAgICBwdGhyZWFkX211
dGV4X2xvY2soJm11dGV4KTsKPiA+ICAgICAgICAgZm9yIChjb25zdCBzdHJ1Y3QgbW9kdWxlICpt
ID0gbW9kdWxlczsgbS0+bW9kdWxlOyBtKyspIHsKPiA+IEBAIC0zMTQsNyArMzE0LDE1IEBAIHN0
YXRpYyBpbnQgX19vcGVuX2RyaXZlcihjb25zdCBjaGFyICpiYXNlLCBpbnQgb2Zmc2V0LCB1bnNp
Z25lZCBpbnQgY2hpcHNldCkKPiA+ICAgICAgICAgfQo+ID4gICAgICAgICBwdGhyZWFkX211dGV4
X3VubG9jaygmbXV0ZXgpOwo+ID4gIAo+ID4gLSAgICAgICByZXR1cm4gX19zZWFyY2hfYW5kX29w
ZW4oYmFzZSwgb2Zmc2V0LCBjaGlwc2V0KTsKPiA+ICsgICAgICAgZmQgPSBfX3NlYXJjaF9hbmRf
b3BlbihiYXNlLCBvZmZzZXQsIGNoaXBzZXQpOwo+ID4gKyAgICAgICBpZiAoZmQgPCAwKQo+ID4g
KyAgICAgICAgICAgICAgIHJldHVybiBmZDsKPiA+ICsKPiA+ICtzZXRfZW5naW5lc19hbmRfcmV0
dXJuOgo+ID4gKyAgICAgICBpZiAoaXNfaTkxNV9kZXZpY2UoZmQpKQo+ID4gKyAgICAgICAgICAg
ICAgIGdlbV9pbml0X2VuZ2luZV9saXN0KGZkKTsKPiAKPiBEbyB3ZSByZWFsbHkgd2FudCBtb3Jl
IGltcGxpY2l0IGFjdGlvbnMgb24gb3BlbmluZyBhbiBmZD8KPiAKPiBXZSBhbHJlYWR5IGhhdmUg
aWd0X3JlcXVpcmVfZ2VtKCkgd2hpY2ggd291bGQgbWFrZSBhbiBpbnRlcmVzdGluZwo+IHN0YXJ0
aW5nIHBvaW50LCBmb3IgdGhhdCB3ZSBtYXkgd2FudCB0byB1c2UgZmQgbm90IGZyb20KPiBkcm1f
b3Blbl9kcml2ZXIoKS4gSG93ZXZlciwgdGhlcmUgc2VlbXMgdG8gYmUgbm8gaXNzdWUgd2l0aCBj
cmVhdGluZyB0aGUKPiBuYW1lcyBvbiB0aGUgZmx5IChhbmQgYXNrIGZvciB0aGUgY29tcGxlbWVu
dGFyeSBnZXR0ZXIgZm9yIGVuZ2luZXNbXSBzbwo+IHRoYXQgYW4gaW5kZXggY291bGQgYmUgdHJh
bnNsYXRlZCBiYWNrIHRvIGNsYXNzOmluc3RhbmNlKS4KPiAKPiBDZXJ0YWlubHkgaGF2aW5nIGRy
bXRlc3QgcHJlc3VtZSBHRU0gKGFuZCBiZSBzdWJqZWN0IHRvIGFsbCBvZiB0aGUgZXh0cmEKPiBy
dWxlcykgZ2l2ZW4gaTkxNSBzZWVtcyBhIGJpdCBydWRlLgoKT0ssIEkgY2FuIHRyeSBpdCBvdXQg
aW4gaWd0X3JlcXVpcmVfZ2VtKCkuCgo+ID4gKyAgICAgICAvKgo+ID4gKyAgICAgICAgKiBUaGUg
Zmlyc3QgaW9jdGwgaXMgc2VudCB3aXRoIGl0ZW0ubGVuZ3RoID0gMAo+ID4gKyAgICAgICAgKiB3
aGljaCBhc2tzIHRvIHRoZSBkcml2ZXIgdG8gc3RvcmUgaW4gbGVuZ3RoIHRoZQo+ID4gKyAgICAg
ICAgKiBtZW1vcnkgbmVlZGVkIGZvciB0aGUgZW5naW5lcy4gSW4gdGhlIGRyaXZlciwgbGVuZ3Ro
Cj4gPiArICAgICAgICAqIGlzIGVxdWFsIHRvCj4gPiArICAgICAgICAqCj4gPiArICAgICAgICAq
ICAgbGVuID0gc2l6ZW9mKHN0cnVjdCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbykgKwo+ID4g
KyAgICAgICAgKiAgICAgICAgICAgICAgICAgICBJTlRFTF9JTkZPKGk5MTUpLT5udW1fcmluZ3Mg
Kgo+ID4gKyAgICAgICAgKiAgICAgICAgICAgICAgICAgICBzaXplb2Yoc3RydWN0IGRybV9pOTE1
X2VuZ2luZV9pbmZvKTsKPiAKPiBOYWgsIGRvIG5vdCBpbXBseSB5b3UgYXJlIHRpZWQgdG8gaW1w
bGVtZW50YXRpb24gZGV0YWlscyAtIHRoYXQgaXMgdGhlCj4gd2hvbGUgcG9pbnQgb2YgcXVlcnlp
bmcgdGhlIGxlbmd0aCBmaXJzdC4gRG8gbm90ZSB0aGF0IHlvdSBjYW4gb3Zlcgo+IGFsbG9jYXRl
IChzYXkgdXNlIGEgc21hbGwgYml0IG9mIHN0YWNrKSBhbmQgZG8gdGhlIHF1ZXJ5IGluIG9uZSBz
aG90LAo+IG9ubHkgYWxsb2NhdGluZyBmcm9tIGhlYXAgaWYgd2UgbmVlZCBtb3JlIHJvb20uCgpT
dXJlIQoKPiA+ICsgICAgICAgICovCj4gPiArICAgICAgIGlndF9hc3NlcnQoIWlvY3RsKGZkLCBE
Uk1fSU9DVExfSTkxNV9RVUVSWSwgJnF1ZXJ5KSk7Cj4gCj4gQmFkIG5ld3MgZm9yIG9sZCBrZXJu
ZWxzLgoKTm8gYml0IG9mIHRoaXMgcGF0Y2ggd291bGQgd29yayBvbiBvbGQga2VybmVscy4gSSB0
aG91Z2h0IHRoaXMKd2FzIHRoZSByZWFzb24gdG8gY3JlYXRlIGEgc2Vjb25kIGZvcl9lYWNoX3Bo
eXNpY2FsX2VuZ2luZTIKKHdoaWNoIEkgY2FsbGVkIGZvcl9lYWNoX2VuZ2luZV9jdHgoKSkuCgpN
YXliZSBpbiBhIG5leHQgcGF0Y2ggSSBjYW4gdGhpbmsgb2YgcmV3b3JraW5nIHRoaW5ncyBhIGJp
dCAoaW4KdGhlIGlndF9ndC5oKSBzbyB0aGF0IHdlIGNob29zZSB0aGUgcmlnaHQgImZvcl9lYWNo
Li4uIiBiYXNlZCBvbgp0aGUga2VybmVsJ3MgQVBJLgoKPiA+ICt2b2lkIF9fc2V0X2N0eF9lbmdp
bmVfbWFwKGludCBmZCwgdWludDMyX3QgY3R4X2lkKQo+ID4gK3sKPiA+ICsgICAgICAgaW50IGk7
Cj4gPiArICAgICAgIHVuc2lnbmVkIGNoYXIgbjsKPiA+ICsgICAgICAgc3RydWN0IGRybV9pOTE1
X2dlbV9jb250ZXh0X3BhcmFtIGN0eF9wYXJhbTsKPiA+ICsgICAgICAgc3RydWN0IGk5MTVfY29u
dGV4dF9wYXJhbV9lbmdpbmVzICpjdHhfZW5naW5lOwo+ID4gKyAgICAgICBzaXplX3Qgc2l6ZTsK
PiA+ICsKPiA+ICsgICAgICAgZm9yIChuID0gMDsgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyW25d
Lm5hbWU7IG4rKyk7Cj4gCj4gQ2xvc2UgeW91ciBleWVzIGFuZCB0ZWxsIG1lIHdoZXJlIHRoZSAn
OycgaXMuCgo6KQoKPiA+ICsgICAgICAgc2l6ZSA9IHNpemVvZihzdHJ1Y3QgaTkxNV9jb250ZXh0
X3BhcmFtX2VuZ2luZXMpICsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAobiArIDEpICogc2l6
ZW9mKCpjdHhfZW5naW5lLT5jbGFzc19pbnN0YW5jZSk7Cj4gCj4gU2hvdWxkIGJlIHNtYWxsIGVu
b3VnaCBmb3IgYSBzdGFjayBhbGxvY2F0aW9ucyBvZiBzYXkgNjQgZW5naW5lcyAodGhlCj4gbGlt
aXQgb2YgdGhlIGN1cnJlbnQgZXhlY2J1ZiB1YWJpKS4KCkkgd2lsbCBvdmVyLWFsbG9jYXRlIGhl
cmUgYXMgd2VsbCwgc28gdGhhdCBJIHJlbW92ZSB0aGUgJzsnIHRoYXQKeW91IGRvbid0IGxpa2Uu
Cgo+ID4gKyAgICAgICBpZ3RfYXNzZXJ0KChjdHhfZW5naW5lID0gbWFsbG9jKHNpemUpKSk7Cj4g
PiArCj4gPiArICAgICAgIGN0eF9lbmdpbmUtPmV4dGVuc2lvbnMgPSAwOwo+ID4gKyAgICAgICBm
b3IgKGkgPSAwOyBpIDw9IG47IGkrKykgewo+ID4gKyAgICAgICAgICAgICAgIGN0eF9lbmdpbmUt
PmNsYXNzX2luc3RhbmNlW2ldLmNsYXNzID0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBpbnRlbF9leGVjdXRpb25fZW5naW5lczJbaV0uY2xhc3M7Cj4gPiArICAg
ICAgICAgICAgICAgY3R4X2VuZ2luZS0+Y2xhc3NfaW5zdGFuY2VbaV0uaW5zdGFuY2UgPQo+ID4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludGVsX2V4ZWN1dGlvbl9l
bmdpbmVzMltpXS5pbnN0YW5jZTsKPiA+ICsgICAgICAgfQo+ID4gKwo+ID4gKyAgICAgICBjdHhf
cGFyYW0uY3R4X2lkID0gY3R4X2lkOwo+ID4gKyAgICAgICBjdHhfcGFyYW0uc2l6ZSA9IHNpemU7
Cj4gPiArICAgICAgIGN0eF9wYXJhbS5wYXJhbSA9IEk5MTVfQ09OVEVYVF9QQVJBTV9FTkdJTkVT
Owo+ID4gKyAgICAgICBjdHhfcGFyYW0udmFsdWUgPSB0b191c2VyX3BvaW50ZXIoY3R4X2VuZ2lu
ZSk7Cj4gPiArCj4gPiArICAgICAgIGlndF9hc3NlcnQoIWlvY3RsKGZkLCBEUk1fSU9DVExfSTkx
NV9HRU1fQ09OVEVYVF9TRVRQQVJBTSwgJmN0eF9wYXJhbSkpOwo+IAo+IERvIHlvdSByZWFsbHkg
d2FudCB0byByaXNrIHRoYXQgdGhpcyB3b24ndCBiZSBpbnRlcnJ1cHRlZCBieSBhIHNpZ25hbCBh
dAo+IGFueSBwb2ludCBpbiB0aGUgZnV0dXJlPwoKU29ycnksIEkgZG9uJ3QgdW5kZXJzdGFuZCwg
ZXZlcnl0aGluZyBjYW4gYmUgaW50ZXJydXB0ZWQgYnkKc2lnbmFscy4gV2hhdCBhcmUgeW91IHN1
Z2dlc3Rpbmc/CgpUaGFua3MsCkFuZGkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
Z3QtZGV2Cg==