public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [RFC PATCH v4 2/3] lib: implement new engine discovery interface
Date: Tue, 15 Jan 2019 15:41:53 +0200	[thread overview]
Message-ID: <20190115134153.GB2052@intel.intel> (raw)
In-Reply-To: <5fb9e076-2371-12cc-c8db-6fbae7e2cb8c@linux.intel.com>

Hi Tvrtko,

> > > -const struct intel_execution_engine2 intel_execution_engines2[] = {
> > > -       { "rcs0", I915_ENGINE_CLASS_RENDER, 0 },
> > > -       { "bcs0", I915_ENGINE_CLASS_COPY, 0 },
> > > -       { "vcs0", I915_ENGINE_CLASS_VIDEO, 0 },
> > > -       { "vcs1", I915_ENGINE_CLASS_VIDEO, 1 },
> > > -       { "vecs0", I915_ENGINE_CLASS_VIDEO_ENHANCE, 0 },
> > > -       { }
> > > -};
> > > +struct intel_execution_engine2 intel_execution_engines2[32] = { };
> 
> I'd just make it a pointer, both size and explicit static initialization to
> zero are not needed.

So that you want to allocate *intel_execution_engines2 somewhere
in gem_init_engine_list(), is this what you are recommending?

Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-01-15 13:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 12:35 [igt-dev] [RFC PATCH v4 0/3] new engine discovery interface Andi Shyti
2019-01-15 12:35 ` [igt-dev] [RFC PATCH v4 1/3] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-01-15 12:35 ` [igt-dev] [RFC PATCH v4 2/3] lib: implement new engine discovery interface Andi Shyti
2019-01-15 13:00   ` Chris Wilson
2019-01-15 13:14     ` Tvrtko Ursulin
2019-01-15 13:19       ` Chris Wilson
2019-01-15 13:32         ` Tvrtko Ursulin
2019-01-15 13:43           ` Chris Wilson
2019-01-15 13:41       ` Andi Shyti [this message]
2019-01-15 13:50         ` Tvrtko Ursulin
2019-01-15 13:55           ` Andi Shyti
2019-01-15 13:32     ` Andi Shyti
2019-01-15 12:35 ` [igt-dev] [RFC PATCH v4 3/3] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti
2019-01-15 13:04   ` Chris Wilson
2019-01-15 13:43     ` Andi Shyti
2019-01-15 12:39 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115134153.GB2052@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=andi@etezian.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox