Re: [igt-dev] [PATCH i-g-t] lib/igt_gt: Move assert with setting 'reset' parameter after IGT env check

Chris Wilson
2019-01-23T14:12:41Z

Quoting Katarzyna Dec (2019-01-23 14:04:04)
> We are trying to set reset parameter earlier than checking IGT env.
> Let's move it after checking IGT env to avoid setting reset parameter
> when hang injection is disabled.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>

I can see the sense in that. Can we kill the env var though?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

If the system is not suitable for reset tests, can we not derive that
from querying the system rather than rely on the user? We have better
means of test selection now than just setting env var (and if not, why
not) so afaik CI is not using it.
-Chris