From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [igt-dev] [PATCH i-g-t v4 1/4] test/psr: Skip PSR2 tests when panel resolution is bigger than PSR2 HW supports
Date: Wed, 23 Jan 2019 15:56:33 -0800 [thread overview]
Message-ID: <20190123235636.8720-1-jose.souza@intel.com> (raw)
If resolution that will be used in PSR tests is bigger than the
resolution that PSR2 HW supports, PSR2 will not be enabled so those
tests should be skiped. Most of eDP panels only supports one
resolution that is why we don't even try to use other resolution.
BSpec: 7713
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
tests/kms_psr.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/tests/kms_psr.c b/tests/kms_psr.c
index 3e16a6bf..4792e158 100644
--- a/tests/kms_psr.c
+++ b/tests/kms_psr.c
@@ -445,13 +445,30 @@ int main(int argc, char *argv[])
igt_require_f(sink_support(&data, PSR_MODE_1),
"Sink does not support PSR\n");
- data.supports_psr2 = sink_support(&data, PSR_MODE_2);
-
data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
igt_assert(data.bufmgr);
drm_intel_bufmgr_gem_enable_reuse(data.bufmgr);
display_init(&data);
+
+ data.supports_psr2 = sink_support(&data, PSR_MODE_2);
+ if (data.supports_psr2) {
+ uint32_t devid = intel_get_drm_devid(data.drm_fd);
+ uint16_t max_h = 0, max_v = 0;
+ int gen = intel_gen(devid);
+
+ if (gen >= 10 || IS_GEMINILAKE(devid)) {
+ max_h = 4096;
+ max_v = 2304;
+ } else if (gen == 9) {
+ max_h = 3640;
+ max_v = 2304;
+ }
+
+ if (data.mode->hdisplay > max_h ||
+ data.mode->vdisplay > max_v)
+ data.supports_psr2 = false;
+ }
}
for (data.op_psr_mode = PSR_MODE_1; data.op_psr_mode <= PSR_MODE_2;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-01-23 23:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 23:56 José Roberto de Souza [this message]
2019-01-23 23:56 ` [igt-dev] [PATCH i-g-t v4 2/4] tests/intel-ci: Add basic PSR2 tests to fast feedback test list José Roberto de Souza
2019-01-24 2:26 ` Dhinakaran Pandiyan
2019-01-23 23:56 ` [igt-dev] [PATCH i-g-t v4 3/4] test: Add PSR2 selective update tests José Roberto de Souza
2019-01-24 2:33 ` Dhinakaran Pandiyan
2019-01-24 18:27 ` Souza, Jose
2019-01-24 19:28 ` Dhinakaran Pandiyan
2019-01-23 23:56 ` [igt-dev] [PATCH i-g-t v4 4/4] DO NOT MERGE: Check result of kms_psr2_su tests José Roberto de Souza
2019-01-24 0:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v4,1/4] test/psr: Skip PSR2 tests when panel resolution is bigger than PSR2 HW supports Patchwork
2019-01-24 1:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v4,1/4] test/psr: Skip PSR2 tests when panel resolution is bigger than PSR2 HW supports (rev2) Patchwork
2019-01-24 2:25 ` [igt-dev] [PATCH i-g-t v4 1/4] test/psr: Skip PSR2 tests when panel resolution is bigger than PSR2 HW supports Dhinakaran Pandiyan
2019-01-24 6:39 ` Rodrigo Vivi
2019-01-24 18:20 ` Souza, Jose
2019-01-24 19:02 ` Dhinakaran Pandiyan
2019-01-24 22:06 ` Rodrigo Vivi
2019-01-25 0:09 ` Souza, Jose
2019-01-25 0:15 ` Rodrigo Vivi
2019-01-25 5:08 ` Dhinakaran Pandiyan
2019-01-24 3:02 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v4,1/4] test/psr: Skip PSR2 tests when panel resolution is bigger than PSR2 HW supports (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123235636.8720-1-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox