Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/intel-ci: Add basic PSR2 tests to fast feedback test list

Souza, Jose
2019-01-23T23:59:58Z

[-- Attachment #1.1: Type: text/plain, Size: 2288 bytes --]

On Wed, 2019-01-23 at 21:00 +0000, Souza, Jose wrote:
> On Wed, 2019-01-23 at 13:37 +0200, Petri Latvala wrote:
> > On Tue, Jan 22, 2019 at 05:09:49PM -0800, José Roberto de Souza
> > wrote:
> > > Lets run the same PSR1 basic tests for PSR2 to caught PSR2
> > > regressions faster.
> > >
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > tests/intel-ci/fast-feedback.testlist | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > > ci/fast-feedback.testlist
> > > index da3c4c8e..e48cb8a5 100644
> > > --- a/tests/intel-ci/fast-feedback.testlist
> > > +++ b/tests/intel-ci/fast-feedback.testlist
> > > @@ -227,6 +227,10 @@ igt@kms_psr@primary_page_flip
> > > igt@kms_psr@cursor_plane_move
> > > igt@kms_psr@sprite_plane_onoff
> > > igt@kms_psr@primary_mmap_gtt
> > > +igt@kms_psr@psr2_primary_page_flip
> > > +igt@kms_psr@psr2_cursor_plane_move
> > > +igt@kms_psr@psr2_sprite_plane_onoff
> > > +igt@kms_psr@psr2_primary_mmap_gtt
> >
> > The BAT results mail said success because these are new tests, but
> > do
> > note that they failed. They must pass to get onto the BAT list.
> >
> >
>
> <7>[ 91.805388] [drm:intel_psr_compute_config [i915]] PSR2 not
> enabled, resolution 3840x2160 > max supported 3640x2304
>
> It failed because the GEN9 PSR2 HW only supports resolutions up to
> 3640x2304, so it switched back go PSR1 and the test failed because it
> was expecting a PSR2 state not a PSR1.
>
> I talked with DK, he thinks that the panel should be replaced in that
> machine so we can have some PSR2 test coverage in GEN9.
>
> If not possible we should add more code in igt_fixture() to check if
> PSR2 is supported but that could potentially hide PSR2 issues behind
> tests skipped or whitelist PSR2 tests in fi-whl-u.

Bypassed with: https://patchwork.freedesktop.org/patch/279874/

Let me know what you guys think about this.

> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]