From: Katarzyna Dec <katarzyna.dec@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling
Date: Thu, 24 Jan 2019 15:34:24 +0100 [thread overview]
Message-ID: <20190124143424.GI4799@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190118211801.6362-1-chris@chris-wilson.co.uk>
On Fri, Jan 18, 2019 at 09:18:01PM +0000, Chris Wilson wrote:
> If the device has error capturing disabled, we still allow previous
> error state to be cleared by a write to sysfs/error. To actually confirm
> that we can capture a fresh error state, we have to perform a read().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_capture.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
> index f26b4102c..49394c311 100644
> --- a/tests/i915/gem_exec_capture.c
> +++ b/tests/i915/gem_exec_capture.c
> @@ -544,6 +544,7 @@ igt_main
>
> dir = igt_sysfs_open(fd, NULL);
> igt_require(igt_sysfs_set(dir, "error", "Begone!"));
> + igt_require(igt_sysfs_get(dir, "error"));
> }
LGTM.
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
>
> for (e = intel_execution_engines; e->name; e++) {
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-01-24 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 21:18 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling Chris Wilson
2019-01-18 21:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-19 0:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-24 14:34 ` Katarzyna Dec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124143424.GI4799@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox