Re: [igt-dev] [PATCH i-g-t 2/6] tools/intel_watermark: More biths for PLANE_BUF_CFG

Souza, Jose
2019-01-28T22:19:52Z

[-- Attachment #1.1: Type: text/plain, Size: 1612 bytes --]

"biths"? I guess this is a typo.

Other than that LGTM:
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

On Mon, 2019-01-28 at 22:01 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On icl PLANE_BUF_CFG fields are 11 bits. Decode them correctly.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tools/intel_watermark.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
> index b61a26f1cd57..c98b8649cc9c 100644
> --- a/tools/intel_watermark.c
> +++ b/tools/intel_watermark.c
> @@ -349,20 +349,20 @@ static void skl_wm_dump(void)
>
> printf("\nstart");
> for (plane = 0; plane < num_planes; plane++) {
> - start = REG_DECODE1(buf_cfg[pipe][plane], 0,
> 10);
> + start = REG_DECODE1(buf_cfg[pipe][plane], 0,
> 11);
> printf("%10d", start);
> }
>
> printf("\n end");
> for (plane = 0; plane < num_planes; plane++) {
> - end = REG_DECODE1(buf_cfg[pipe][plane], 16,
> 10);
> + end = REG_DECODE1(buf_cfg[pipe][plane], 16,
> 11);
> printf("%10d", end);
> }
>
> printf("\n size");
> for (plane = 0; plane < num_planes; plane++) {
> - start = REG_DECODE1(buf_cfg[pipe][plane], 0,
> 10);
> - end = REG_DECODE1(buf_cfg[pipe][plane], 16,
> 10);
> + start = REG_DECODE1(buf_cfg[pipe][plane], 0,
> 11);
> + end = REG_DECODE1(buf_cfg[pipe][plane], 16,
> 11);
> size = end - start + 1;
> printf("%10d", (end == 0 && size == 1) ? 0 :
> size);
> }

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]