From: Petri Latvala <petri.latvala@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Nicholas Kazlauskas <nkazlaus@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
Date: Thu, 31 Jan 2019 12:26:28 +0200 [thread overview]
Message-ID: <20190131102628.GJ4038@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190131085802.9703-1-maarten.lankhorst@linux.intel.com>
On Thu, Jan 31, 2019 at 09:58:02AM +0100, Maarten Lankhorst wrote:
> We used to add them all 1 by 1, but we really only care about not
> handling a few.
>
> Only skip unsetting all atomic properties, instead of handling it
> through a whitelist.
>
> This fixes kms_busy, which was updating the VRR hint, even though
> we already unset it in the legacy path.
>
> Cc: Nicholas Kazlauskas <nkazlaus@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109490
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> lib/igt_kms.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 58f32911d999..1f98b26fcd79 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -3298,10 +3298,9 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
> pipe_obj->values[IGT_CRTC_OUT_FENCE_PTR] = 0;
> pipe_obj->changed = 0;
> } else {
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_BACKGROUND);
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_CTM);
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_DEGAMMA_LUT);
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_GAMMA_LUT);
> + for (i = 0; i < IGT_NUM_CRTC_PROPS; i++)
> + if (!is_atomic_prop(i))
> + igt_pipe_obj_clear_prop_changed(pipe_obj, i);
Does IGT_CRTC_VRR_ENABLED need to be added to is_atomic_prop?
...
No, that's not a "is this an atomic-only property", is it?
Anyway, the effect matches the second chunk of Nicholas's patch.
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
There's some queue in shards so stand by a couple of hours for their results before merging.
>
> if (s != COMMIT_UNIVERSAL) {
> igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_MODE_ID);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-31 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 8:58 [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly Maarten Lankhorst
2019-01-31 9:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-31 10:26 ` Petri Latvala [this message]
2019-01-31 12:05 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
2019-01-31 14:38 ` Kazlauskas, Nicholas
2019-01-31 20:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-02-01 9:29 ` Petri Latvala
2019-02-01 9:56 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131102628.GJ4038@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=nkazlaus@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox