From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 4 Feb 2019 11:05:36 +0100 From: Katarzyna Dec Message-ID: <20190204100536.GA8896@kdec5-desk.ger.corp.intel.com> References: <20190204083614.2385-1-chris@chris-wilson.co.uk> <20190204083614.2385-5-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190204083614.2385-5-chris@chris-wilson.co.uk> Subject: Re: [igt-dev] [PATCH i-g-t 05/13] lib: Add GPU power measurement List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: T24gTW9uLCBGZWIgMDQsIDIwMTkgYXQgMDg6MzY6MDZBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFJlYWQgdGhlIFJBUEwgcG93ZXIgbWV0cmljcyBjb3VydGVzeSBvZiBwZXJmLiBPciB5 b3VyIGxvY2FsIEhXCj4gZXF1aXZhbGVudD8KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgbGliL01ha2VmaWxlLnNvdXJj ZXMgfCAgIDIgKwo+ICBsaWIvaWd0X2dwdV9wb3dlci5jICB8IDEwOSArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGxpYi9pZ3RfZ3B1X3Bvd2VyLmggIHwgIDU5 ICsrKysrKysrKysrKysrKysrKysrKysrCj4gIGxpYi9tZXNvbi5idWlsZCAgICAgIHwgICAyICsK PiAgNCBmaWxlcyBjaGFuZ2VkLCAxNzIgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2 NDQgbGliL2lndF9ncHVfcG93ZXIuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgbGliL2lndF9ncHVf cG93ZXIuaAo+IAo+IGRpZmYgLS1naXQgYS9saWIvTWFrZWZpbGUuc291cmNlcyBiL2xpYi9NYWtl ZmlsZS5zb3VyY2VzCj4gaW5kZXggODA4Yjk2MTdlLi41NGQ5ZTNlN2IgMTAwNjQ0Cj4gLS0tIGEv bGliL01ha2VmaWxlLnNvdXJjZXMKPiArKysgYi9saWIvTWFrZWZpbGUuc291cmNlcwo+IEBAIC0y NCw2ICsyNCw4IEBAIGxpYl9zb3VyY2VfbGlzdCA9CSAJXAo+ICAJaWd0X2NvbG9yX2VuY29kaW5n LmMJXAo+ICAJaWd0X2NvbG9yX2VuY29kaW5nLmgJXAo+ICAJaWd0X2VkaWRfdGVtcGxhdGUuaAlc Cj4gKwlpZ3RfZ3B1X3Bvd2VyLmMJCVwKPiArCWlndF9ncHVfcG93ZXIuaAkJXAo+ICAJaWd0X2d0 LmMJCVwKPiAgCWlndF9ndC5oCQlcCj4gIAlpZ3RfZ3Z0LmMJCVwKPiBkaWZmIC0tZ2l0IGEvbGli L2lndF9ncHVfcG93ZXIuYyBiL2xpYi9pZ3RfZ3B1X3Bvd2VyLmMKPiBuZXcgZmlsZSBtb2RlIDEw MDY0NAo+IGluZGV4IDAwMDAwMDAwMC4uZDYyYmY1ZGM4Cj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBi L2xpYi9pZ3RfZ3B1X3Bvd2VyLmMKPiBAQCAtMCwwICsxLDEwOSBAQAo+ICsjaW5jbHVkZSA8Y3R5 cGUuaD4KPiArI2luY2x1ZGUgPGVycm5vLmg+Cj4gKyNpbmNsdWRlIDxmY250bC5oPgo+ICsjaW5j bHVkZSA8bG9jYWxlLmg+Cj4gKyNpbmNsdWRlIDxtYXRoLmg+Cj4gKyNpbmNsdWRlIDx1bmlzdGQu aD4KPiArCj4gKyNpbmNsdWRlICJpZ3RfZ3B1X3Bvd2VyLmgiCj4gKyNpbmNsdWRlICJpZ3RfcGVy Zi5oIgo+ICsKPiArc3RhdGljIGludCBmaWxlbmFtZV90b19idWYoY29uc3QgY2hhciAqZmlsZW5h bWUsIGNoYXIgKmJ1ZiwgdW5zaWduZWQgaW50IHN6KQo+ICt7Cj4gKwlpbnQgZmQ7Cj4gKwlzc2l6 ZV90IHJldDsKPiArCj4gKwlmZCA9IG9wZW4oZmlsZW5hbWUsIE9fUkRPTkxZKTsKPiArCWlmIChm ZCA8IDApCj4gKwkJcmV0dXJuIC0xOwo+ICsKPiArCXJldCA9IHJlYWQoZmQsIGJ1Ziwgc3ogLSAx KTsKPiArCWNsb3NlKGZkKTsKPiArCWlmIChyZXQgPCAxKQo+ICsJCXJldHVybiAtMTsKPiArCj4g KwlidWZbcmV0XSA9ICdcMCc7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyB1 aW50NjRfdCBmaWxlbmFtZV90b191NjQoY29uc3QgY2hhciAqZmlsZW5hbWUsIGludCBiYXNlKQo+ ICt7Cj4gKwljaGFyIGJ1Zls2NF0sICpiOwo+ICsKPiArCWlmIChmaWxlbmFtZV90b19idWYoZmls ZW5hbWUsIGJ1Ziwgc2l6ZW9mKGJ1ZikpKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCS8qCj4gKwkg KiBIYW5kbGUgYm90aCBzaW5nbGUgaW50ZWdlciBhbmQga2V5PXZhbHVlIGZvcm1hdHMgYnkgc2tp cHBpbmcKPiArCSAqIGxlYWRpbmcgbm9uLWRpZ2l0cy4KPiArCSAqLwo+ICsJYiA9IGJ1ZjsKPiAr CXdoaWxlICgqYiAmJiAhaXNkaWdpdCgqYikpCj4gKwkJYisrOwo+ICsKPiArCXJldHVybiBzdHJ0 b3VsbChiLCBOVUxMLCBiYXNlKTsKPiArfQo+ICsKPiArc3RhdGljIGRvdWJsZSBmaWxlbmFtZV90 b19kb3VibGUoY29uc3QgY2hhciAqZmlsZW5hbWUpCj4gK3sKPiArCWNoYXIgKm9sZGxvY2FsZTsK PiArCWNoYXIgYnVmWzgwXTsKPiArCWRvdWJsZSB2Owo+ICsKPiArCWlmIChmaWxlbmFtZV90b19i dWYoZmlsZW5hbWUsIGJ1Ziwgc2l6ZW9mKGJ1ZikpKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCW9s ZGxvY2FsZSA9IHNldGxvY2FsZShMQ19BTEwsICJDIik7Cj4gKwl2ID0gc3RydG9kKGJ1ZiwgTlVM TCk7Cj4gKwlzZXRsb2NhbGUoTENfQUxMLCBvbGRsb2NhbGUpOwpXaHkgd2UgYXJlIGZpcnN0IHNl dHRpbmcgIkMiIGxvY2FsZSBhbmQgdGhlbiByZXN0b3JpbmcgaXQ/IElzIHRoZXJlIGEgbW9tZW50 CmR1cmluZyBtZXN1cmVtZW50IHdoZW4gaXQgaXMgY2hhbmdlZD8KCkthc2lhIDopCj4gKwo+ICsJ cmV0dXJuIHY7Cj4gK30KPiArCj4gK3N0YXRpYyB1aW50NjRfdCByYXBsX3R5cGVfaWQodm9pZCkK PiArewo+ICsJcmV0dXJuIGZpbGVuYW1lX3RvX3U2NCgiL3N5cy9kZXZpY2VzL3Bvd2VyL3R5cGUi LCAxMCk7Cj4gK30KPiArCj4gK3N0YXRpYyB1aW50NjRfdCByYXBsX2dwdV9wb3dlcih2b2lkKQo+ ICt7Cj4gKwlyZXR1cm4gZmlsZW5hbWVfdG9fdTY0KCIvc3lzL2RldmljZXMvcG93ZXIvZXZlbnRz L2VuZXJneS1ncHUiLCAwKTsKPiArfQo+ICsKPiArc3RhdGljIGRvdWJsZSByYXBsX2dwdV9wb3dl cl9zY2FsZSh2b2lkKQo+ICt7Cj4gKwlyZXR1cm4gZmlsZW5hbWVfdG9fZG91YmxlKCIvc3lzL2Rl dmljZXMvcG93ZXIvZXZlbnRzL2VuZXJneS1ncHUuc2NhbGUiKTsKPiArfQo+ICsKPiAraW50IGdw dV9wb3dlcl9vcGVuKHN0cnVjdCBncHVfcG93ZXIgKnBvd2VyKQo+ICt7Cj4gKwlwb3dlci0+ZmQg PSBpZ3RfcGVyZl9vcGVuKHJhcGxfdHlwZV9pZCgpLCByYXBsX2dwdV9wb3dlcigpKTsKPiArCWlm IChwb3dlci0+ZmQgPCAwKSB7Cj4gKwkJcG93ZXItPmZkID0gLWVycm5vOwo+ICsJCWdvdG8gZXJy Owo+ICsJfQo+ICsKPiArCXBvd2VyLT5zY2FsZSA9IHJhcGxfZ3B1X3Bvd2VyX3NjYWxlKCk7Cj4g KwlpZiAoaXNuYW4ocG93ZXItPnNjYWxlKSB8fCAhcG93ZXItPnNjYWxlKSB7Cj4gKwkJY2xvc2Uo cG93ZXItPmZkKTsKPiArCQlnb3RvIGVycjsKPiArCX0KPiArCXBvd2VyLT5zY2FsZSAqPSAxZTk7 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gKwo+ICtlcnI6Cj4gKwllcnJubyA9IDA7Cj4gKwlyZXR1cm4g cG93ZXItPmZkOwo+ICt9Cj4gKwo+ICtib29sIGdwdV9wb3dlcl9yZWFkKHN0cnVjdCBncHVfcG93 ZXIgKnBvd2VyLCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSAqcykKPiArewo+ICsJcmV0dXJuIHJl YWQocG93ZXItPmZkLCBzLCBzaXplb2YoKnMpKSA9PSBzaXplb2YoKnMpOwo+ICt9Cj4gKwo+ICt2 b2lkIGdwdV9wb3dlcl9jbG9zZShzdHJ1Y3QgZ3B1X3Bvd2VyICpwb3dlcikKPiArewo+ICsJY2xv c2UocG93ZXItPmZkKTsKPiArfQo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2dwdV9wb3dlci5oIGIv bGliL2lndF9ncHVfcG93ZXIuaAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAw MDAwLi40ZTFiNzQ3YzAKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvbGliL2lndF9ncHVfcG93ZXIu aAo+IEBAIC0wLDAgKzEsNTkgQEAKPiArLyoKPiArICogQ29weXJpZ2h0IMKpIDIwMTkgSW50ZWwg Q29ycG9yYXRpb24KPiArICoKPiArICogUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRlZCwgZnJl ZSBvZiBjaGFyZ2UsIHRvIGFueSBwZXJzb24gb2J0YWluaW5nIGEKPiArICogY29weSBvZiB0aGlz IHNvZnR3YXJlIGFuZCBhc3NvY2lhdGVkIGRvY3VtZW50YXRpb24gZmlsZXMgKHRoZSAiU29mdHdh cmUiKSwKPiArICogdG8gZGVhbCBpbiB0aGUgU29mdHdhcmUgd2l0aG91dCByZXN0cmljdGlvbiwg aW5jbHVkaW5nIHdpdGhvdXQgbGltaXRhdGlvbgo+ICsgKiB0aGUgcmlnaHRzIHRvIHVzZSwgY29w eSwgbW9kaWZ5LCBtZXJnZSwgcHVibGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5zZSwKPiArICog YW5kL29yIHNlbGwgY29waWVzIG9mIHRoZSBTb2Z0d2FyZSwgYW5kIHRvIHBlcm1pdCBwZXJzb25z IHRvIHdob20gdGhlCj4gKyAqIFNvZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBzbywgc3ViamVj dCB0byB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnM6Cj4gKyAqCj4gKyAqIFRoZSBhYm92ZSBjb3B5 cmlnaHQgbm90aWNlIGFuZCB0aGlzIHBlcm1pc3Npb24gbm90aWNlIChpbmNsdWRpbmcgdGhlIG5l eHQKPiArICogcGFyYWdyYXBoKSBzaGFsbCBiZSBpbmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1 YnN0YW50aWFsIHBvcnRpb25zIG9mIHRoZQo+ICsgKiBTb2Z0d2FyZS4KPiArICoKPiArICogVEhF IFNPRlRXQVJFIElTIFBST1ZJREVEICJBUyBJUyIsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5ZIEtJ TkQsIEVYUFJFU1MgT1IKPiArICogSU1QTElFRCwgSU5DTFVESU5HIEJVVCBOT1QgTElNSVRFRCBU TyBUSEUgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFksCj4gKyAqIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUiBQVVJQT1NFIEFORCBOT05JTkZSSU5HRU1FTlQuICBJTiBOTyBFVkVOVCBTSEFM TAo+ICsgKiBUSEUgQVVUSE9SUyBPUiBDT1BZUklHSFQgSE9MREVSUyBCRSBMSUFCTEUgRk9SIEFO WSBDTEFJTSwgREFNQUdFUyBPUiBPVEhFUgo+ICsgKiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQU4g QUNUSU9OIE9GIENPTlRSQUNULCBUT1JUIE9SIE9USEVSV0lTRSwgQVJJU0lORwo+ICsgKiBGUk9N LCBPVVQgT0YgT1IgSU4gQ09OTkVDVElPTiBXSVRIIFRIRSBTT0ZUV0FSRSBPUiBUSEUgVVNFIE9S IE9USEVSIERFQUxJTkdTCj4gKyAqIElOIFRIRSBTT0ZUV0FSRS4KPiArICoKPiArICovCj4gKwo+ ICsjaWZuZGVmIElHVF9HUFVfUE9XRVJfSAo+ICsjZGVmaW5lIElHVF9HUFVfUE9XRVJfSAo+ICsK PiArI2luY2x1ZGUgPHN0ZGJvb2wuaD4KPiArI2luY2x1ZGUgPHN0ZGludC5oPgo+ICsKPiArc3Ry dWN0IGdwdV9wb3dlciB7Cj4gKwlpbnQgZmQ7Cj4gKwlkb3VibGUgc2NhbGU7Cj4gK307Cj4gKwo+ ICtzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSB7Cj4gKwl1aW50NjRfdCBlbmVyZ3k7Cj4gKwl1aW50 NjRfdCB0aW1lOwo+ICt9Owo+ICsKPiAraW50IGdwdV9wb3dlcl9vcGVuKHN0cnVjdCBncHVfcG93 ZXIgKnBvd2VyKTsKPiArYm9vbCBncHVfcG93ZXJfcmVhZChzdHJ1Y3QgZ3B1X3Bvd2VyICpwb3dl ciwgc3RydWN0IGdwdV9wb3dlcl9zYW1wbGUgKnMpOwo+ICt2b2lkIGdwdV9wb3dlcl9jbG9zZShz dHJ1Y3QgZ3B1X3Bvd2VyICpwb3dlcik7Cj4gKwo+ICtzdGF0aWMgaW5saW5lIGRvdWJsZSBncHVf cG93ZXJfSihjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyICpwLAo+ICsJCQkJIGNvbnN0IHN0cnVjdCBn cHVfcG93ZXJfc2FtcGxlICp0MCwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBs ZSAqdDEpCj4gK3sKPiArCXJldHVybiAodDEtPmVuZXJneSAtIHQwLT5lbmVyZ3kpICogcC0+c2Nh bGUgKiAxZS05Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIGRvdWJsZSBncHVfcG93ZXJfVyhj b25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyICpwLAo+ICsJCQkJIGNvbnN0IHN0cnVjdCBncHVfcG93ZXJf c2FtcGxlICp0MCwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSAqdDEpCj4g K3sKPiArCXJldHVybiAodDEtPmVuZXJneSAtIHQwLT5lbmVyZ3kpICogcC0+c2NhbGUgLyAodDEt PnRpbWUgLSB0MC0+dGltZSk7Cj4gK30KPiArCj4gKyNlbmRpZiAvKiBJR1RfR1BVX1BPV0VSX0gg Ki8KPiBkaWZmIC0tZ2l0IGEvbGliL21lc29uLmJ1aWxkIGIvbGliL21lc29uLmJ1aWxkCj4gaW5k ZXggZGQzNmY4MTgwLi42MzI3OWFlMzAgMTAwNjQ0Cj4gLS0tIGEvbGliL21lc29uLmJ1aWxkCj4g KysrIGIvbGliL21lc29uLmJ1aWxkCj4gQEAgLTgsOSArOCwxMSBAQCBsaWJfc291cmNlcyA9IFsK PiAgCSdpZ3RfZGVidWdmcy5jJywKPiAgCSdpZ3RfZGV2aWNlLmMnLAo+ICAJJ2lndF9hdXguYycs Cj4gKwknaWd0X2dwdV9wb3dlci5jJywKPiAgCSdpZ3RfZ3QuYycsCj4gIAknaWd0X2d2dC5jJywK PiAgCSdpZ3RfbWF0cml4LmMnLAo+ICsJJ2lndF9wZXJmLmMnLAo+ICAJJ2lndF9wcmltZXMuYycs Cj4gIAknaWd0X3JhbmQuYycsCj4gIAknaWd0X3N0YXRzLmMnLAo+IC0tIAo+IDIuMjAuMQo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gaWd0LWRl diBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlz dAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK