From: Petri Latvala <petri.latvala@intel.com>
To: Mamta Shukla <mamtashukla555@gmail.com>
Cc: igt-dev@lists.freedesktop.org, hamohammed.sa@gmail.com, daniel@ffwll.ch
Subject: Re: [igt-dev] [PATCH i-g-t, v3, 1/2] tests/kms_cursor_crc.c: Improve test_cursor_alpha()
Date: Mon, 4 Feb 2019 15:04:59 +0200 [thread overview]
Message-ID: <20190204130459.GM4038@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <7fe5b67752b0d53137360a0a4539572df0287e7d.1549204343.git.mamtashukla555@gmail.com>
On Sun, Feb 03, 2019 at 08:08:03PM +0530, Mamta Shukla wrote:
> In the kms_cursor_crc, the subtest to check exterme alpha values failed due
> to different CRCs observed in hardware and software rendering. This patch fixes
> CRC mismatch error in cursor-alpha-opaque and cursor-alpha-transparent subtests
> by improving the order in which cursor was rendered in hardware test. Changes
> made in test_cursor_alpha() to ensure cursor rendering in hardware test and
> acquire CRC value:
> - Add drmModeSetCursor() to set cursor image.
> - Remove igt_display_commit() to reduce the chance of getting crc values cleared
> before it is acquired.
> - Add igt_remove_fb() to remove locally created framebuffer after disabling the
> cursor plane in HW test
>
> Also, aligned this function with test_cursor_size and after these changes
> got passing results for alpha blending support added in VKMS CRC API.
>
> Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Added link to https://bugs.freedesktop.org/show_bug.cgi?id=109350 and
merged the bunch, thanks.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-02-04 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 14:38 [igt-dev] [PATCH i-g-t, v3, 1/2] tests/kms_cursor_crc.c: Improve test_cursor_alpha() Mamta Shukla
2019-02-03 15:31 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/2] " Patchwork
2019-02-03 16:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
[not found] ` <f6b066cd3ad75629844ade3853e71c6c0786f3a1.1549204343.git.mamtashukla555@gmail.com>
2019-02-03 20:25 ` [igt-dev] [PATCH i-g-t, v3, 2/2] tests/kms_cursor_crc.c: Remove framebuffer at the end of the test Rodrigo Siqueira
2019-02-03 20:26 ` [igt-dev] [PATCH i-g-t, v3, 1/2] tests/kms_cursor_crc.c: Improve test_cursor_alpha() Rodrigo Siqueira
2019-02-04 13:04 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204130459.GM4038@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=daniel@ffwll.ch \
--cc=hamohammed.sa@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mamtashukla555@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox