From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A9CB6E687 for ; Tue, 5 Feb 2019 12:28:00 +0000 (UTC) Date: Tue, 5 Feb 2019 13:27:57 +0100 From: Katarzyna Dec Message-ID: <20190205122757.GA20062@kdec5-desk.ger.corp.intel.com> References: <20190204083614.2385-1-chris@chris-wilson.co.uk> <20190204083614.2385-5-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190204083614.2385-5-chris@chris-wilson.co.uk> Subject: Re: [igt-dev] [PATCH i-g-t 05/13] lib: Add GPU power measurement List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: T24gTW9uLCBGZWIgMDQsIDIwMTkgYXQgMDg6MzY6MDZBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFJlYWQgdGhlIFJBUEwgcG93ZXIgbWV0cmljcyBjb3VydGVzeSBvZiBwZXJmLiBPciB5 b3VyIGxvY2FsIEhXCj4gZXF1aXZhbGVudD8KSSB0aGluayB0aGlzIGNvbW1pdCBtZXNzYWdlIGl0 IHRvbyBicmllZi4gV2hvIHNob3VsZCBhbnN3ZXQgdGhlIHF1ZXN0aW9uPyA6KQo+IAo+IFNpZ25l ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ ICBsaWIvTWFrZWZpbGUuc291cmNlcyB8ICAgMiArCj4gIGxpYi9pZ3RfZ3B1X3Bvd2VyLmMgIHwg MTA5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgbGliL2ln dF9ncHVfcG93ZXIuaCAgfCAgNTkgKysrKysrKysrKysrKysrKysrKysrKysKPiAgbGliL21lc29u LmJ1aWxkICAgICAgfCAgIDIgKwo+ICA0IGZpbGVzIGNoYW5nZWQsIDE3MiBpbnNlcnRpb25zKCsp Cj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBsaWIvaWd0X2dwdV9wb3dlci5jCj4gIGNyZWF0ZSBtb2Rl IDEwMDY0NCBsaWIvaWd0X2dwdV9wb3dlci5oCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9NYWtlZmls ZS5zb3VyY2VzIGIvbGliL01ha2VmaWxlLnNvdXJjZXMKPiBpbmRleCA4MDhiOTYxN2UuLjU0ZDll M2U3YiAxMDA2NDQKPiAtLS0gYS9saWIvTWFrZWZpbGUuc291cmNlcwo+ICsrKyBiL2xpYi9NYWtl ZmlsZS5zb3VyY2VzCj4gQEAgLTI0LDYgKzI0LDggQEAgbGliX3NvdXJjZV9saXN0ID0JIAlcCj4g IAlpZ3RfY29sb3JfZW5jb2RpbmcuYwlcCj4gIAlpZ3RfY29sb3JfZW5jb2RpbmcuaAlcCj4gIAlp Z3RfZWRpZF90ZW1wbGF0ZS5oCVwKPiArCWlndF9ncHVfcG93ZXIuYwkJXAo+ICsJaWd0X2dwdV9w b3dlci5oCQlcCj4gIAlpZ3RfZ3QuYwkJXAo+ICAJaWd0X2d0LmgJCVwKPiAgCWlndF9ndnQuYwkJ XAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2dwdV9wb3dlci5jIGIvbGliL2lndF9ncHVfcG93ZXIu Ywo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwLi5kNjJiZjVkYzgKPiAt LS0gL2Rldi9udWxsCj4gKysrIGIvbGliL2lndF9ncHVfcG93ZXIuYwo+IEBAIC0wLDAgKzEsMTA5 IEBACj4gKyNpbmNsdWRlIDxjdHlwZS5oPgo+ICsjaW5jbHVkZSA8ZXJybm8uaD4KPiArI2luY2x1 ZGUgPGZjbnRsLmg+Cj4gKyNpbmNsdWRlIDxsb2NhbGUuaD4KPiArI2luY2x1ZGUgPG1hdGguaD4K PiArI2luY2x1ZGUgPHVuaXN0ZC5oPgo+ICsKPiArI2luY2x1ZGUgImlndF9ncHVfcG93ZXIuaCIK PiArI2luY2x1ZGUgImlndF9wZXJmLmgiCj4gKwo+ICtzdGF0aWMgaW50IGZpbGVuYW1lX3RvX2J1 Zihjb25zdCBjaGFyICpmaWxlbmFtZSwgY2hhciAqYnVmLCB1bnNpZ25lZCBpbnQgc3opCj4gK3sK PiArCWludCBmZDsKPiArCXNzaXplX3QgcmV0Owo+ICsKPiArCWZkID0gb3BlbihmaWxlbmFtZSwg T19SRE9OTFkpOwo+ICsJaWYgKGZkIDwgMCkKPiArCQlyZXR1cm4gLTE7Cj4gKwo+ICsJcmV0ID0g cmVhZChmZCwgYnVmLCBzeiAtIDEpOwo+ICsJY2xvc2UoZmQpOwo+ICsJaWYgKHJldCA8IDEpCj4g KwkJcmV0dXJuIC0xOwo+ICsKPiArCWJ1ZltyZXRdID0gJ1wwJzsKPiArCj4gKwlyZXR1cm4gMDsK PiArfQo+ICsKPiArc3RhdGljIHVpbnQ2NF90IGZpbGVuYW1lX3RvX3U2NChjb25zdCBjaGFyICpm aWxlbmFtZSwgaW50IGJhc2UpCj4gK3sKPiArCWNoYXIgYnVmWzY0XSwgKmI7Cj4gKwo+ICsJaWYg KGZpbGVuYW1lX3RvX2J1ZihmaWxlbmFtZSwgYnVmLCBzaXplb2YoYnVmKSkpCj4gKwkJcmV0dXJu IDA7Cj4gKwo+ICsJLyoKPiArCSAqIEhhbmRsZSBib3RoIHNpbmdsZSBpbnRlZ2VyIGFuZCBrZXk9 dmFsdWUgZm9ybWF0cyBieSBza2lwcGluZwo+ICsJICogbGVhZGluZyBub24tZGlnaXRzLgo+ICsJ ICovCj4gKwliID0gYnVmOwo+ICsJd2hpbGUgKCpiICYmICFpc2RpZ2l0KCpiKSkKPiArCQliKys7 Cj4gKwo+ICsJcmV0dXJuIHN0cnRvdWxsKGIsIE5VTEwsIGJhc2UpOwo+ICt9Cj4gKwo+ICtzdGF0 aWMgZG91YmxlIGZpbGVuYW1lX3RvX2RvdWJsZShjb25zdCBjaGFyICpmaWxlbmFtZSkKPiArewo+ ICsJY2hhciAqb2xkbG9jYWxlOwo+ICsJY2hhciBidWZbODBdOwo+ICsJZG91YmxlIHY7Cj4gKwo+ ICsJaWYgKGZpbGVuYW1lX3RvX2J1ZihmaWxlbmFtZSwgYnVmLCBzaXplb2YoYnVmKSkpCj4gKwkJ cmV0dXJuIDA7Cj4gKwo+ICsJb2xkbG9jYWxlID0gc2V0bG9jYWxlKExDX0FMTCwgIkMiKTsKPiAr CXYgPSBzdHJ0b2QoYnVmLCBOVUxMKTsKPiArCXNldGxvY2FsZShMQ19BTEwsIG9sZGxvY2FsZSk7 Cj4gKwo+ICsJcmV0dXJuIHY7Cj4gK30KPiArCj4gK3N0YXRpYyB1aW50NjRfdCByYXBsX3R5cGVf aWQodm9pZCkKPiArewo+ICsJcmV0dXJuIGZpbGVuYW1lX3RvX3U2NCgiL3N5cy9kZXZpY2VzL3Bv d2VyL3R5cGUiLCAxMCk7Cj4gK30KPiArCj4gK3N0YXRpYyB1aW50NjRfdCByYXBsX2dwdV9wb3dl cih2b2lkKQo+ICt7Cj4gKwlyZXR1cm4gZmlsZW5hbWVfdG9fdTY0KCIvc3lzL2RldmljZXMvcG93 ZXIvZXZlbnRzL2VuZXJneS1ncHUiLCAwKTsKPiArfQo+ICsKPiArc3RhdGljIGRvdWJsZSByYXBs X2dwdV9wb3dlcl9zY2FsZSh2b2lkKQo+ICt7Cj4gKwlyZXR1cm4gZmlsZW5hbWVfdG9fZG91Ymxl KCIvc3lzL2RldmljZXMvcG93ZXIvZXZlbnRzL2VuZXJneS1ncHUuc2NhbGUiKTsKPiArfQo+ICsK PiAraW50IGdwdV9wb3dlcl9vcGVuKHN0cnVjdCBncHVfcG93ZXIgKnBvd2VyKQo+ICt7Cj4gKwlw b3dlci0+ZmQgPSBpZ3RfcGVyZl9vcGVuKHJhcGxfdHlwZV9pZCgpLCByYXBsX2dwdV9wb3dlcigp KTsKPiArCWlmIChwb3dlci0+ZmQgPCAwKSB7Cj4gKwkJcG93ZXItPmZkID0gLWVycm5vOwo+ICsJ CWdvdG8gZXJyOwo+ICsJfQo+ICsKPiArCXBvd2VyLT5zY2FsZSA9IHJhcGxfZ3B1X3Bvd2VyX3Nj YWxlKCk7Cj4gKwlpZiAoaXNuYW4ocG93ZXItPnNjYWxlKSB8fCAhcG93ZXItPnNjYWxlKSB7Cj4g KwkJY2xvc2UocG93ZXItPmZkKTsKPiArCQlnb3RvIGVycjsKPiArCX0KPiArCXBvd2VyLT5zY2Fs ZSAqPSAxZTk7CldoZXJlIHRoaXMgc2NhbGUgdmFsdWUgaXMgY29taW5nIGZyb20/IEkgbG9va2Vk IGF0IHRoaXMgcGFyYW1ldGVyIG9uIG15IGRlc2t0b3AKYW5kIGl0IGlzIGUtMTAuCj4gKwo+ICsJ cmV0dXJuIDA7Cj4gKwo+ICtlcnI6Cj4gKwllcnJubyA9IDA7Cj4gKwlyZXR1cm4gcG93ZXItPmZk Owo+ICt9Cj4gKwo+ICtib29sIGdwdV9wb3dlcl9yZWFkKHN0cnVjdCBncHVfcG93ZXIgKnBvd2Vy LCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSAqcykKPiArewo+ICsJcmV0dXJuIHJlYWQocG93ZXIt PmZkLCBzLCBzaXplb2YoKnMpKSA9PSBzaXplb2YoKnMpOwo+ICt9Cj4gKwo+ICt2b2lkIGdwdV9w b3dlcl9jbG9zZShzdHJ1Y3QgZ3B1X3Bvd2VyICpwb3dlcikKPiArewo+ICsJY2xvc2UocG93ZXIt PmZkKTsKPiArfQo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2dwdV9wb3dlci5oIGIvbGliL2lndF9n cHVfcG93ZXIuaAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwLi40ZTFi NzQ3YzAKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvbGliL2lndF9ncHVfcG93ZXIuaAo+IEBAIC0w LDAgKzEsNTkgQEAKPiArLyoKPiArICogQ29weXJpZ2h0IMKpIDIwMTkgSW50ZWwgQ29ycG9yYXRp b24KPiArICoKPiArICogUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRlZCwgZnJlZSBvZiBjaGFy Z2UsIHRvIGFueSBwZXJzb24gb2J0YWluaW5nIGEKPiArICogY29weSBvZiB0aGlzIHNvZnR3YXJl IGFuZCBhc3NvY2lhdGVkIGRvY3VtZW50YXRpb24gZmlsZXMgKHRoZSAiU29mdHdhcmUiKSwKPiAr ICogdG8gZGVhbCBpbiB0aGUgU29mdHdhcmUgd2l0aG91dCByZXN0cmljdGlvbiwgaW5jbHVkaW5n IHdpdGhvdXQgbGltaXRhdGlvbgo+ICsgKiB0aGUgcmlnaHRzIHRvIHVzZSwgY29weSwgbW9kaWZ5 LCBtZXJnZSwgcHVibGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5zZSwKPiArICogYW5kL29yIHNl bGwgY29waWVzIG9mIHRoZSBTb2Z0d2FyZSwgYW5kIHRvIHBlcm1pdCBwZXJzb25zIHRvIHdob20g dGhlCj4gKyAqIFNvZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBzbywgc3ViamVjdCB0byB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnM6Cj4gKyAqCj4gKyAqIFRoZSBhYm92ZSBjb3B5cmlnaHQgbm90 aWNlIGFuZCB0aGlzIHBlcm1pc3Npb24gbm90aWNlIChpbmNsdWRpbmcgdGhlIG5leHQKPiArICog cGFyYWdyYXBoKSBzaGFsbCBiZSBpbmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1YnN0YW50aWFs IHBvcnRpb25zIG9mIHRoZQo+ICsgKiBTb2Z0d2FyZS4KPiArICoKPiArICogVEhFIFNPRlRXQVJF IElTIFBST1ZJREVEICJBUyBJUyIsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5ZIEtJTkQsIEVYUFJF U1MgT1IKPiArICogSU1QTElFRCwgSU5DTFVESU5HIEJVVCBOT1QgTElNSVRFRCBUTyBUSEUgV0FS UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFksCj4gKyAqIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFORCBOT05JTkZSSU5HRU1FTlQuICBJTiBOTyBFVkVOVCBTSEFMTAo+ICsgKiBU SEUgQVVUSE9SUyBPUiBDT1BZUklHSFQgSE9MREVSUyBCRSBMSUFCTEUgRk9SIEFOWSBDTEFJTSwg REFNQUdFUyBPUiBPVEhFUgo+ICsgKiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQU4gQUNUSU9OIE9G IENPTlRSQUNULCBUT1JUIE9SIE9USEVSV0lTRSwgQVJJU0lORwo+ICsgKiBGUk9NLCBPVVQgT0Yg T1IgSU4gQ09OTkVDVElPTiBXSVRIIFRIRSBTT0ZUV0FSRSBPUiBUSEUgVVNFIE9SIE9USEVSIERF QUxJTkdTCj4gKyAqIElOIFRIRSBTT0ZUV0FSRS4KPiArICoKPiArICovCj4gKwo+ICsjaWZuZGVm IElHVF9HUFVfUE9XRVJfSAo+ICsjZGVmaW5lIElHVF9HUFVfUE9XRVJfSAo+ICsKPiArI2luY2x1 ZGUgPHN0ZGJvb2wuaD4KPiArI2luY2x1ZGUgPHN0ZGludC5oPgo+ICsKPiArc3RydWN0IGdwdV9w b3dlciB7Cj4gKwlpbnQgZmQ7Cj4gKwlkb3VibGUgc2NhbGU7Cj4gK307Cj4gKwo+ICtzdHJ1Y3Qg Z3B1X3Bvd2VyX3NhbXBsZSB7Cj4gKwl1aW50NjRfdCBlbmVyZ3k7Cj4gKwl1aW50NjRfdCB0aW1l Owo+ICt9Owo+ICsKPiAraW50IGdwdV9wb3dlcl9vcGVuKHN0cnVjdCBncHVfcG93ZXIgKnBvd2Vy KTsKPiArYm9vbCBncHVfcG93ZXJfcmVhZChzdHJ1Y3QgZ3B1X3Bvd2VyICpwb3dlciwgc3RydWN0 IGdwdV9wb3dlcl9zYW1wbGUgKnMpOwo+ICt2b2lkIGdwdV9wb3dlcl9jbG9zZShzdHJ1Y3QgZ3B1 X3Bvd2VyICpwb3dlcik7Cj4gKwo+ICtzdGF0aWMgaW5saW5lIGRvdWJsZSBncHVfcG93ZXJfSihj b25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyICpwLAo+ICsJCQkJIGNvbnN0IHN0cnVjdCBncHVfcG93ZXJf c2FtcGxlICp0MCwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSAqdDEpCj4g K3sKPiArCXJldHVybiAodDEtPmVuZXJneSAtIHQwLT5lbmVyZ3kpICogcC0+c2NhbGUgKiAxZS05 OwpTYW1lIGEgYWJvdmUgLSB3aGVyZSB0aGlzIHZhbHVlIGNvbWVzIGZyb20/CgpLYXNpYSA6KQo+ ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIGRvdWJsZSBncHVfcG93ZXJfVyhjb25zdCBzdHJ1Y3Qg Z3B1X3Bvd2VyICpwLAo+ICsJCQkJIGNvbnN0IHN0cnVjdCBncHVfcG93ZXJfc2FtcGxlICp0MCwK PiArCQkJCSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSAqdDEpCj4gK3sKPiArCXJldHVy biAodDEtPmVuZXJneSAtIHQwLT5lbmVyZ3kpICogcC0+c2NhbGUgLyAodDEtPnRpbWUgLSB0MC0+ dGltZSk7Cj4gK30KPiArCj4gKyNlbmRpZiAvKiBJR1RfR1BVX1BPV0VSX0ggKi8KPiBkaWZmIC0t Z2l0IGEvbGliL21lc29uLmJ1aWxkIGIvbGliL21lc29uLmJ1aWxkCj4gaW5kZXggZGQzNmY4MTgw Li42MzI3OWFlMzAgMTAwNjQ0Cj4gLS0tIGEvbGliL21lc29uLmJ1aWxkCj4gKysrIGIvbGliL21l c29uLmJ1aWxkCj4gQEAgLTgsOSArOCwxMSBAQCBsaWJfc291cmNlcyA9IFsKPiAgCSdpZ3RfZGVi dWdmcy5jJywKPiAgCSdpZ3RfZGV2aWNlLmMnLAo+ICAJJ2lndF9hdXguYycsCj4gKwknaWd0X2dw dV9wb3dlci5jJywKPiAgCSdpZ3RfZ3QuYycsCj4gIAknaWd0X2d2dC5jJywKPiAgCSdpZ3RfbWF0 cml4LmMnLAo+ICsJJ2lndF9wZXJmLmMnLAo+ICAJJ2lndF9wcmltZXMuYycsCj4gIAknaWd0X3Jh bmQuYycsCj4gIAknaWd0X3N0YXRzLmMnLAo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gaWd0LWRldiBtYWlsaW5nIGxp c3QKPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lndC1kZXYK