From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 05/13] lib: Add GPU power measurement
Date: Tue, 5 Feb 2019 16:41:10 +0200 [thread overview]
Message-ID: <20190205144110.GR20097@intel.com> (raw)
In-Reply-To: <154927591922.14784.3266649005622961197@skylake-alporthouse-com>
On Mon, Feb 04, 2019 at 10:25:19AM +0000, Chris Wilson wrote:
> Quoting Katarzyna Dec (2019-02-04 10:05:36)
> > On Mon, Feb 04, 2019 at 08:36:06AM +0000, Chris Wilson wrote:
> > > + oldlocale = setlocale(LC_ALL, "C");
> > > + v = strtod(buf, NULL);
> > > + setlocale(LC_ALL, oldlocale);
> > Why we are first setting "C" locale and then restoring it? Is there a moment
> > during mesurement when it is changed?
>
> No, but it may be set in the environment for pretty-printing of output.
> Thread-safety not guaranteed.
uselocale() ?
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-05 14:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 8:36 [igt-dev] [PATCH i-g-t 01/13] i915/gem_mocs_settings: Allow hangs around reset tests Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 02/13] lib/i915: Pretty print busy stats support Chris Wilson
2019-02-04 8:36 ` [Intel-gfx] [PATCH i-g-t 03/13] i915/perf_pmu: Query for enhanced busyness tracking Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 04/13] lib/i915: Pretty print HW semaphores Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 05/13] lib: Add GPU power measurement Chris Wilson
2019-02-04 10:05 ` Katarzyna Dec
2019-02-04 10:25 ` Chris Wilson
2019-02-05 14:41 ` Ville Syrjälä [this message]
2019-02-05 15:09 ` Chris Wilson
2019-02-05 12:27 ` Katarzyna Dec
2019-02-05 12:31 ` Chris Wilson
2019-02-05 13:44 ` Katarzyna Dec
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 06/13] i915/gem_exec_schedule: Measure semaphore power consumption Chris Wilson
2019-02-05 12:50 ` Katarzyna Dec
2019-02-05 12:53 ` Chris Wilson
2019-02-05 13:57 ` Katarzyna Dec
2019-02-04 8:36 ` [Intel-gfx] [PATCH i-g-t 07/13] i915/gem_exec_whisper: Measure total power consumed Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 08/13] i915/gem_exec_latency: Normalize results into ns Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 09/13] i915/gem_exec_latency: Eliminate the wakeup penalty Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 10/13] i915/gem_exec_latency: Robustify measurements Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 11/13] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 12/13] i915/gem_exec_nop: poll-sequential requires ordering between rings Chris Wilson
2019-02-04 8:36 ` [igt-dev] [PATCH i-g-t 13/13] i915/gem_sync: Make switch-default asymmetric Chris Wilson
2019-02-04 9:16 ` [igt-dev] [Intel-gfx] [PATCH i-g-t 01/13] i915/gem_mocs_settings: Allow hangs around reset tests Tvrtko Ursulin
2019-02-04 9:31 ` [igt-dev] " Katarzyna Dec
2019-02-04 9:55 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/13] " Patchwork
2019-02-04 10:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205144110.GR20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox