From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/4] lib/tests: make sure igt_skip in igt_fork is forbidden
Date: Thu, 7 Feb 2019 15:57:05 +0100 [thread overview]
Message-ID: <20190207145707.27623-2-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190207145707.27623-1-daniel.vetter@ffwll.ch>
Another corner case to check.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/tests/igt_fork.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/lib/tests/igt_fork.c b/lib/tests/igt_fork.c
index d495c7815e06..5ff2956dd0ab 100644
--- a/lib/tests/igt_fork.c
+++ b/lib/tests/igt_fork.c
@@ -43,6 +43,15 @@
char test[] = "test";
char *argv_run[] = { test };
+static void igt_fork_vs_skip(void)
+{
+ igt_fork(i, 1) {
+ igt_skip("skipping");
+ }
+
+ igt_waitchildren();
+}
+
static void igt_fork_vs_assert(void)
{
igt_fork(i, 1) {
@@ -82,6 +91,11 @@ int main(int argc, char **argv)
{
int ret;
+ /* check that igt_assert is forwarded */
ret = do_fork(igt_fork_vs_assert);
internal_assert(ret == IGT_EXIT_FAILURE);
+
+ /* check that igt_skip within a fork blows up */
+ ret = do_fork(igt_fork_vs_skip);
+ internal_assert(ret == SIGABRT + 128);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-07 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 14:57 [igt-dev] [PATCH i-g-t 1/4] lib/tests: Check that igt_assert forwards correctly through igt_fork Daniel Vetter
2019-02-07 14:57 ` Daniel Vetter [this message]
2019-02-07 14:57 ` [igt-dev] [PATCH i-g-t 3/4] lib: Don't leak children in igt_waitchildren_timeout Daniel Vetter
2019-02-07 15:20 ` Chris Wilson
2019-02-07 16:06 ` Daniel Vetter
2019-02-07 16:34 ` Daniel Vetter
2019-02-07 14:57 ` [igt-dev] [PATCH i-g-t 4/4] lib/tests: make sure we catch igt_fork leaks Daniel Vetter
2019-02-07 15:07 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-02-07 15:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/tests: Check that igt_assert forwards correctly through igt_fork (rev2) Patchwork
2019-02-07 17:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207145707.27623-2-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox