From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61CAF6E5C9 for ; Mon, 11 Feb 2019 22:38:30 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id d9so458636edh.12 for ; Mon, 11 Feb 2019 14:38:30 -0800 (PST) Date: Mon, 11 Feb 2019 23:38:25 +0100 From: Daniel Vetter Message-ID: <20190211223825.GV23159@phenom.ffwll.local> References: <20190211180208.29406-1-daniel.vetter@ffwll.ch> <20190211180208.29406-3-daniel.vetter@ffwll.ch> <154991899170.15715.1631719136617848704@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <154991899170.15715.1631719136617848704@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t 3/9] lib: Don't leak children in igt_waitchildren_timeout List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT development , Daniel Vetter List-ID: T24gTW9uLCBGZWIgMTEsIDIwMTkgYXQgMDk6MDM6MTJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxOS0wMi0xMSAxODowMjowMikKPiA+IElu c3RlYWQgb2YgY2xlYW5pbmcgdXAgdGhlIG1lc3MgaW4gaWd0X2V4aXQgbWFrZSBzdXJlIHdlIGRv bid0IGV2ZW4KPiA+IGxldCBpdCBvdXQgb2YgdGhlIGNvbnRhaW5lci4gU2VlIGFsc28KPiA+IAo+ ID4gY29tbWl0IDc1NDg3NjM3OGQ2YzliMjc3NWU4YzA3YjRkMTZmOTg3OGM1NTk0OWYKPiA+IEF1 dGhvcjogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBEYXRlOiAg IEZyaSBGZWIgMjYgMjI6MTE6MTAgMjAxNiArMDAwMAo+ID4gCj4gPiAgICAgaWd0L2dlbV9zeW5j OiBFbmZvcmNlIGEgdGltZW91dCBvZiAyMHMKPiA+IAo+ID4gd2hpY2ggYWRkZWQgdGhpcyBoZWxw ZXIuCj4gPiAKPiA+IFRvIG1ha2Ugc3VyZSB0aGF0IGV2ZXJ5b25lIGZvbGxvd3MgdGhlIHJ1bGVz LCBhZGQgYW4gYXNzZXJ0Lgo+ID4gCj4gPiBXZSdyZSBrZWVwaW5nIHRoZSBjbGVhbnVwIGNvZGUg YXMgYSBmYWlsc2FmZSwgYW5kIGJlY2F1c2UgaXQgc3BlZWRzCj4gPiB1cCB0aGUgdGVzdGNhc2Ug SSdtIGZvbGxvd2luZyB1cCB3aXRoLgo+ID4gCj4gPiB2MjogQ2hyaXMgcG9pbnRlZCBvdXQgdGhh dCBteSBvcmlnaW5hbCBwYXRjaCBkaWQgbm90aGluZy4gV2hpY2ggSQo+ID4gZGlkbid0IGNhdGNo IGJlY2F1c2UgbXkgdGVzdGNhc2Ugd2FzIGFsc28gYnJva2VuLiBVbmZvcnR1bmF0ZWx5IHRoaXMK PiA+IG1lYW5zIHdlIG5lZWQgdG8gb3BlbiBjb2RlIHBhcnQgb2YgdGhlIHdhaXRpbmcuCj4gPiAK PiA+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IFNpZ25l ZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gLS0t Cj4gPiAgbGliL2lndF9jb3JlLmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv bnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfY29yZS5jIGIvbGliL2lndF9jb3Jl LmMKPiA+IGluZGV4IGNiYmU3OWY4ODA3MC4uMzA1MzY5N2RhNThjIDEwMDY0NAo+ID4gLS0tIGEv bGliL2lndF9jb3JlLmMKPiA+ICsrKyBiL2xpYi9pZ3RfY29yZS5jCj4gPiBAQCAtMTUyNSw2ICsx NTI1LDcgQEAgdm9pZCBpZ3RfZXhpdCh2b2lkKQo+ID4gIAo+ID4gICAgICAgICBmb3IgKGludCBj ID0gMDsgYyA8IG51bV90ZXN0X2NoaWxkcmVuOyBjKyspCj4gPiAgICAgICAgICAgICAgICAga2ls bCh0ZXN0X2NoaWxkcmVuW2NdLCBTSUdLSUxMKTsKPiA+ICsgICAgICAgYXNzZXJ0KCFudW1fdGVz dF9jaGlsZHJlbik7Cj4gPiAgCj4gPiAgICAgICAgIGlmICghdGVzdF93aXRoX3N1YnRlc3RzKSB7 Cj4gPiAgICAgICAgICAgICAgICAgc3RydWN0IHRpbWVzcGVjIG5vdzsKPiA+IEBAIC0xODMyLDIw ICsxODMzLDQ4IEBAIHZvaWQgaWd0X3dhaXRjaGlsZHJlbih2b2lkKQo+ID4gICAgICAgICAgICAg ICAgIGlndF9mYWlsKGVycik7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBib29sIGlndF9raWxs Y2hpZHJlbl90aW1lZF9vdXQ7Cj4gPiArCj4gPiArc3RhdGljIHZvaWQgaWd0X2FsYXJtX2tpbGxj aGlsZHJlbihpbnQgc2lnbmFsKQo+ID4gK3sKPiA+ICsgICAgICAgaWd0X2luZm8oIlRpbWVkIG91 dCB3YWl0aW5nIGZvciBjaGlsZHJlblxuIik7Cj4gCj4gV2UgdXNlZCB0byBwcmludCB0aGUgY2Fs bGVyIHN1cHBsaWVkIHJlYXNvbi4gQWx0aG91Z2ggdGhhdCBhcHBlYXJzIHRvCj4gaGF2ZSBuZXZl ciBiZWVuIHVzZWQsIHNvIG1pZ2h0IGFzIHdlbGwgZHJvcCBpdCBmcm9tIHRoZSBBUEkuCj4gCj4g PiArCj4gPiArICAgICAgIGlndF9raWxsY2hpZHJlbl90aW1lZF9vdXQgPSB0cnVlOwo+ID4gKwo+ ID4gKyAgICAgICBmb3IgKGludCBjID0gMDsgYyA8IG51bV90ZXN0X2NoaWxkcmVuOyBjKyspCj4g PiArICAgICAgICAgICAgICAga2lsbCh0ZXN0X2NoaWxkcmVuW2NdLCBTSUdLSUxMKTsKPiAKPiBP aywga2lsbCgpIGlzIHNpZ25hbC1zYWZlLgo+IAo+ID4gK30KPiA+ICsKPiA+ICAvKioKPiA+ICAg KiBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQ6Cj4gPiAgICogQHNlY29uZHM6IHRpbWVvdXQgaW4g c2Vjb25kcyB0byB3YWl0Cj4gPiAgICogQHJlYXNvbjogZGVidWcgc3RyaW5nIGV4cGxhaW5pbmcg d2hhdCB0aW1lZG91dAo+ID4gICAqCj4gPiAtICogV2FpdCBmb3IgYWxsIGNoaWxkcmVuIGZvcmtl ZCB3aXRoIGlndF9mb3JrLCBmb3IgYSBtYXhpbXVtIG9mIEBzZWNvbmRzLgo+ID4gLSAqCj4gPiAt ICogV3JhcHMgaWd0X3dhaXRjaGlsZHJlbigpIGFuZCBpZ3Rfc2V0X3RpbWVvdXQoKQo+ID4gKyAq IFdhaXQgZm9yIGFsbCBjaGlsZHJlbiBmb3JrZWQgd2l0aCBpZ3RfZm9yaywgZm9yIGEgbWF4aW11 bSBvZiBAc2Vjb25kcy4gSWYgdGhlCj4gPiArICogdGltZW91dCBleHBpcmVzLCBraWxscyBhbGwg Y2hpbGRyZW4gYW5kIGNsZWFucyB0aGVtIHVwLgo+ID4gICAqLwo+ID4gIHZvaWQgaWd0X3dhaXRj aGlsZHJlbl90aW1lb3V0KGludCBzZWNvbmRzLCBjb25zdCBjaGFyICpyZWFzb24pCj4gPiAgewo+ ID4gLSAgICAgICBpZ3Rfc2V0X3RpbWVvdXQoc2Vjb25kcywgcmVhc29uKTsKPiA+IC0gICAgICAg aWd0X3dhaXRjaGlsZHJlbigpOwo+ID4gKyAgICAgICBzdHJ1Y3Qgc2lnYWN0aW9uIHNhOwo+ID4g KyAgICAgICBpbnQgcmV0Owo+ID4gKwo+ID4gKyAgICAgICBzYS5zYV9oYW5kbGVyID0gaWd0X2Fs YXJtX2tpbGxjaGlsZHJlbjsKPiA+ICsgICAgICAgc2lnZW1wdHlzZXQoJnNhLnNhX21hc2spOwo+ ID4gKyAgICAgICBzYS5zYV9mbGFncyA9IDA7Cj4gPiArCj4gPiArICAgICAgIGlndF9raWxsY2hp ZHJlbl90aW1lZF9vdXQgPSBmYWxzZTsKPiA+ICsKPiA+ICsgICAgICAgc2lnYWN0aW9uKFNJR0FM Uk0sICZzYSwgTlVMTCk7Cj4gPiArCj4gPiArICAgICAgIGFsYXJtKHNlY29uZHMpOwo+ID4gKwo+ ID4gKyAgICAgICByZXQgPSBfX2lndF93YWl0Y2hpbGRyZW4oKTsKPiA+ICsgICAgICAgaWYgKCFp Z3Rfa2lsbGNoaWRyZW5fdGltZWRfb3V0ICYmIHJldCkKPiA+ICsgICAgICAgICAgICAgICBpZ3Rf ZmFpbChyZXQpOwo+ID4gICAgICAgICBpZ3RfcmVzZXRfdGltZW91dCgpOwo+ID4gKyAgICAgICBf X2lndF93YWl0Y2hpbGRyZW4oKTsKPiA+ICsgICAgICAgaWYgKGlndF9raWxsY2hpZHJlbl90aW1l ZF9vdXQpCj4gPiArICAgICAgICAgICAgICAgaWd0X2ZhaWwoSUdUX0VYSVRfRkFJTFVSRSk7Cj4g Cj4gRG91YmxlIF9faWd0X3dhaXRjaGlsZHJlbigpPyBNeSByZWFkaW5nIG9mIF9faWd0X3dhaXRj aGlsZHJlbigpIGlzIHRoYXQKPiBpdCB3aWxsIGNvbnRpbnVlIG9uIGFmdGVyIHRoZSBhbGFybSgp IHdha2VzIHdhaXQoKSB1cCB3aXRoIFNJR0lOVCBhbmQKPiByZXBlYXQgdGhlIHdhaXQoKSB1bnRp bCBhbGwgY2hpbGRyZW4gZGllLiBBbmQgbm93IHRob3NlIGNoaWxkcmVuIHdpbGwKPiBkaWUsIHJh dGhlciB0aGFuIHRoZSBwYXJlbnQgYXMgYmVmb3JlLgoKaWd0X3dhaXRjaGlsZHJlbl90aW1lb3V0 IGJlZm9yZSB0aGlzIHBhdGNoIHdvdWxkbid0IHdvcmsgaWYgaXQgZGlkIHRoYXQuClRoZSBwaWQg PT0gd2FpdCgpOyBpZiAocGlkID09IC0xKSBjb250aW51ZTsgYmFpbHMgb3V0IHRvIHRoZSBuZXh0 IGNoaWxkIGluCmNhc2Ugb2YgaW50ZXJydXB0cy4gSGVuY2UgdGhlIHdhaXQ7IGtpbGw7IHdhaXQg c2VxdWVuY2UgaGVyZS4gSSBkaXNjb3ZlcmVkCnRoaXMgdGhyb3VnaCB0ZXN0Y2FzZXMgOi0pCi1E YW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aWd0LWRldg==