From: Andi Shyti via igt-dev <igt-dev@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>,
Andi Shyti <andi@etezian.org>,
Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [RFC PATCH v7 3/5] lib: ioctl_wrappers: check GET/SETPARAM ioctl and build active engine list
Date: Tue, 12 Feb 2019 11:07:30 +0200 [thread overview]
Message-ID: <20190212090730.GA24750@intel.intel> (raw)
In-Reply-To: <154992700262.14378.14094133033784538677@skylake-alporthouse-com>
Hi Chris,
On Mon, Feb 11, 2019 at 11:16:42PM +0000, Chris Wilson wrote:
> Quoting Andi Shyti (2019-02-11 23:08:09)
> > The igt_require_gem_engine_list() is called whenever the test
> > wants to use the GET/SETPARAM ioctls.
> >
> > The function checks whether the GET/SETPARAM are implemented in
> > the running kernel and stops the test in case these commands are
> > not supported.
> >
> > At the first call it creates the current engine list as
> > implemented in the gem_init_engine_list() function.
> >
> > Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> > ---
> > lib/ioctl_wrappers.c | 7 +++++++
> > lib/ioctl_wrappers.h | 1 +
>
> No new additions to ioctl_wrappers.c please. If we are generalising an
> existing interface, pull it out into i915/ and add your additions there.
for both the reviews: I will move then everything in i915/.
Thanks again!
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-12 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 23:08 [igt-dev] [RFC PATCH v7 0/5] new engine discovery interface Andi Shyti via igt-dev
2019-02-11 23:08 ` [igt-dev] [RFC PATCH v7 1/5] include/drm-uapi: import i915_drm.h header file Andi Shyti via igt-dev
2019-02-11 23:08 ` [igt-dev] [RFC PATCH v7 2/5] lib: implement new engine discovery interface Andi Shyti via igt-dev
2019-02-11 23:15 ` Chris Wilson
2019-02-11 23:08 ` [igt-dev] [RFC PATCH v7 3/5] lib: ioctl_wrappers: check GET/SETPARAM ioctl and build active engine list Andi Shyti via igt-dev
2019-02-11 23:16 ` Chris Wilson
2019-02-12 9:07 ` Andi Shyti via igt-dev [this message]
2019-02-11 23:08 ` [igt-dev] [RFC PATCH v7 4/5] lib: ioctl_wrappers: reach engines by index as well Andi Shyti via igt-dev
2019-02-11 23:08 ` [igt-dev] [RFC PATCH v7 5/5] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti via igt-dev
2019-02-11 23:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [RFC,v7,1/5] include/drm-uapi: import i915_drm.h header file Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212090730.GA24750@intel.intel \
--to=igt-dev@lists.freedesktop.org \
--cc=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox