From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 117826E225 for ; Wed, 13 Feb 2019 00:55:06 +0000 (UTC) Date: Wed, 13 Feb 2019 02:55:03 +0200 Message-ID: <20190213004823.GA4740@intel.intel> References: <20190212235437.1218-1-andi.shyti@intel.com> <20190212235437.1218-3-andi.shyti@intel.com> <155001679573.13414.15938171617263157199@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <155001679573.13414.15938171617263157199@skylake-alporthouse-com> Subject: Re: [igt-dev] [RFC PATCH v8 2/5] lib/i915: add gem_query library List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andi Shyti via igt-dev Reply-To: Andi Shyti Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT dev , Andi Shyti , Petri Latvala List-ID: SGkgQ2hyaXMsCgo+ID4gK3N0YXRpYyBpbnQgX19nZW1fcXVlcnkoaW50IGZkLCBzdHJ1Y3QgZHJt X2k5MTVfcXVlcnkgKnEpCj4gPiArewo+ID4gKyAgICAgICByZXR1cm4gaWd0X2lvY3RsKGZkLCBE Uk1fSU9DVExfSTkxNV9RVUVSWSwgcSkgPyAtZXJybm8gOiAwOwo+ID4gK30KPiA+ICsKPiA+ICt2 b2lkIGdlbV9xdWVyeShpbnQgZmQsIHN0cnVjdCBkcm1faTkxNV9xdWVyeSAqcSkKPiA+ICt7Cj4g PiArICAgICAgIGlndF9hc3NlcnQoIV9fZ2VtX3F1ZXJ5KGZkLCBxKSk7Cj4gCj4gRm9yIGV4dHJh IHRpZHkgYXNzZXJ0czoKPiAKPiBzdGF0aWMgaW50IF9fZ2VtX3F1ZXJ5KGludCBmZCwgc3RydWN0 IGRybV9pOTE1X3F1ZXJ5ICpxKQo+IHsKPiAJaW50IGVycjsKPiAKPiAJZXJyID0gMDsKPiAJaWYg KGlndF9pb2N0bChmZCwgRFJNX0lPQ1RMX0k5MTVfUVVFUlksIHEpKQo+IAkJZXJyID0gLWVycm5v Owo+IAo+IAllcnJubyA9IDA7Cj4gCXJldHVybiBlcjsKPiB9CgpZZXMsIEkndmUgc2VlbiB0aGlz IGFyb3VuZCwgYWx0aG91Z2ggaXQgbG9va3MgYSBiaXQgcmVkdW5kYW50IHRvCm1lLCBJJ2xsIGtl ZXAgdGhlIHN0eWxlLgoKPiA+ICtzdGF0aWMgaW50IF9fZ2VtX2dldF9zZXRfcGFyYW0oaW50IGZk LCB1bnNpZ25lZCBsb25nIHJlcXVlc3QsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X3BhcmFtICpwKQo+ID4gK3sKPiA+ICsgICAg ICAgcmV0dXJuIGlndF9pb2N0bChmZCwgcmVxdWVzdCwgcCkgPyAgLWVycm5vIDogMDsKPiA+ICt9 Cj4gPiArCj4gPiArdm9pZCBnZW1fZ2V0X3NldF9wYXJhbShpbnQgZmQsIHVuc2lnbmVkIGxvbmcg cmVxdWVzdCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9j b250ZXh0X3BhcmFtICpwKQo+IAo+IGdlbV9jb250ZXh0X3NldF9wYXJhbSEgSXQgZXhpc3RzIQoK T2ghIEkgZGlkbid0IGtub3chIFRoYXQncyBhIGdyZWF0IGRpc2NvdmVyeSA6KQoKPiA+ICt7Cj4g PiArICAgICAgIGlndF9hc3NlcnQoIV9fZ2VtX2dldF9zZXRfcGFyYW0oZmQsIHJlcXVlc3QsIHAp KTsKPiA+ICt9Cj4gPiArCj4gPiArYm9vbCBnZW1faGFzX2dldF9zZXRfcGFyYW0odm9pZCkKPiAK PiBIYXMgd2hhdD8KCmhhcyBnZXQvc2V0cGFyYW0uIEkgY291bGRuJ3QgY29tZSBvdXQgd2l0aCBh IGJldHRlciBuYW1lLiBJJ2xsCnRoaW5rIGhhcmRlci4KCj4gPiArICAgICAgIGl0ZW0ucXVlcnlf aWQgPSBEUk1fSTkxNV9RVUVSWV9FTkdJTkVfSU5GTzsKPiA+ICsgICAgICAgcXVlcnkuaXRlbXNf cHRyID0gdG9fdXNlcl9wb2ludGVyKCZpdGVtKTsKPiA+ICsgICAgICAgcXVlcnkubnVtX2l0ZW1z ID0gMTsKPiA+ICsgICAgICAgaXRlbS5sZW5ndGggPSBzaXplb2YoKnF1ZXJ5X2VuZ2luZXMpICsK PiA+ICsgICAgICAgICAgICAgICAgICAgICA2NCAqIHNpemVvZihzdHJ1Y3QgZHJtX2k5MTVfZW5n aW5lX2luZm8pOwo+IAo+IFlvdSBhcmUgYmV0dGluZyB3ZSBhcmUgbm90IGdvaW5nIHRvIGV4Y2Vl ZCA2NCBlbmdpbmVzPyBBIGNvbW1vbiBiZXQgZm9yCj4gc3VyZS4uLgoKV2UndmUgYmVlbiBkaXNj dXNzaW5nIGFib3V0IHRoaXMgaW4gdjQgYW5kIHdlIGFncmVlZCB0aGF0IDY0IGlzCmJpZyBlbm91 Z2hbKl0uIEFtIEkgbWlzc2luZyBhbnl0aGluZz8KQmVzaWRlcywgSSB0aG91Z2h0IHRoYXQgd2Ug d29uJ3QgaGF2ZSBtb3JlIGVuZ2luZXMgdGhhbgpJOTE1X0VYRUNfUklOR19NQVNLLgoKWypdIGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2lndC1kZXYvMjAxOS1KYW51YXJ5 LzAwODAzNC5odG1sCgo+ID4gK3N0YXRpYyBpbnQgZ2VtX2luaXRfZW5naW5lX2xpc3QoaW50IGZk KQo+ID4gK3sKPiA+ICsgICAgICAgaW50IGksIHJldDsKPiA+ICsgICAgICAgc3RydWN0IGRybV9p OTE1X3F1ZXJ5X2VuZ2luZV9pbmZvICpxdWVyeV9lbmdpbmUgPSBxdWVyeV9lbmdpbmVzKGZkKTsK PiA+ICsgICAgICAgY29uc3QgY2hhciAqZW5naW5lX25hbWVzW10gPSB7ICJyY3MiLCAiYmNzIiwg InZjcyIsICJ2ZWNzIiB9Owo+IAo+IGNsYXNzLCBub3QgZW5naW5lLCBuYW1lcy4gQW5kIGRlc2Vy dmVzIGl0cyBvd24gbWFwcGluZyB0YWJsZSB3aXRoIGFwaS4KCkkgY2FuIG1ha2UgYSBuZXcgQVBJ IGluIGEgbmV4dCBwYXRjaCBhbmQgcmVtb3ZlIGl0IGZyb20gaGVyZSwgYXMKaXQgaXMgYSBiaXQg b3V0IG9mIHRoZSBzY29wZSBpZiB0aGUgc2VyaWVzLgoKPiA+ICsgICAgICAgc3RydWN0IGRybV9p OTE1X2dlbV9jb250ZXh0X3BhcmFtIGN0eF9wYXJhbSA9IHsKPiA+ICsgICAgICAgICAgICAgICAu cGFyYW0gPSBJOTE1X0NPTlRFWFRfUEFSQU1fRU5HSU5FUywKPiA+ICsgICAgICAgfTsKPiA+ICsK PiA+ICsgICAgICAgLyogdGhlIGxpc3QgaXMgYWxyZWFkeSBpbml0aWFsaXplZCAqLwo+ID4gKyAg ICAgICBpZiAoaW50ZWxfYWN0aXZlX2VuZ2luZXMyKQo+ID4gKyAgICAgICAgICAgICAgIHJldHVy biBnZW1faGFzX2dldF9zZXRfcGFyYW0oKSA/IDAgOiAtRUlOVkFMOwo+IAo+IFdlIHdvdWxkIHVz ZSAtRU5PREVWPyBMZWFrcyBxdWVyeV9lbmdpbmUsIHByb2JhYmx5IHNob3VsZCByZW9yZGVyLgoK SSB3YW50ZWQgaGVyZSB0byBiZSBjb25zaXN0ZW50IHdpdGggdGhlIGZhaWx1cmUgdmFsdWUuLi4g IChjb250aW51ZXMpCgo+ID4gKyAgICAgICAvKgo+ID4gKyAgICAgICAgKiB3ZSBjaGVjayBmaXJz dCB3aGV0aGVyIHRoZSBuZXcgZW5naW5lIGRpc2NvdmVyeSB1YXBpCj4gPiArICAgICAgICAqIGlz IGluIHRoZSBjdXJyZW50IGtlcm5lbCwgaWYgbm90LCB0aGUKPiA+ICsgICAgICAgICogRFJNX0lP Q1RMX0k5MTVfR0VNX0NPTlRFWFRfR0VUUEFSQU0gd2lsbCBmYWlsIHdpdGgKPiA+ICsgICAgICAg ICogZXJybm8gPSBFSU5WQUwuIEluIHRoaXMgY2FzZSwgd2UgZmFsbCBiYWNrIHRvIHVzaW5nCj4g PiArICAgICAgICAqIHRoZSBwcmV2aW91cyBlbmdpbmUgZGlzY292ZXJ5IHdheQo+ID4gKyAgICAg ICAgKi8KPiA+ICsgICAgICAgcmV0ID0gX19nZW1fZ2V0X3NldF9wYXJhbShmZCwgRFJNX0lPQ1RM X0k5MTVfR0VNX0NPTlRFWFRfR0VUUEFSQU0sCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJmN0eF9wYXJhbSk7Cj4gPiArICAgICAgIGlmIChyZXQpIHsKPiA+ICsgICAgICAg ICAgICAgICBpZiAocmV0ID09IC1FSU5WQUwpCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBp bnRlbF9hY3RpdmVfZW5naW5lczIgPSBpbnRlbF9leGVjdXRpb25fZW5naW5lczI7CgouLi4gaGVy ZSB3ZSByZXR1cm4gLUVJTlZBTCB0byBpbmRpY2F0ZSB0aGF0IHRoZSBnZXQvc2V0cGFyYW0gd2UK bmVlZCBpcyBub3QgaW1wbGVtZW50ZWQuIElmIEkgcmV0dXJuIC1FTk9ERVYgYmVmb3JlLCBJIHNo b3VsZApyZXR1cm4gLUVOT0RFViBoZXJlIGFzIHdlbGwgKGJ1dCB0aGF0J3Mgbm90IHdoYXQgdGhl IGlvY3RsCnJldHVybnMpLgoKPiBMZWFrcwoKUmlnaHQhCgo+ID4gKyAgICAgICBpZ3RfYXNzZXJ0 KChpbnRlbF9hY3RpdmVfZW5naW5lczIgPQo+ID4gKyAgICAgICAgICAgICAgICAgICBjYWxsb2Mo cXVlcnlfZW5naW5lLT5udW1fZW5naW5lcyArIDEsCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICBzaXplb2YoKmludGVsX2FjdGl2ZV9lbmdpbmVzMikpKSk7Cj4gCj4gRG9uJ3QgYmUgYWZy YWlkIG9mIHVzaW5nIHR3byBsaW5lcyBmb3IgZGlmZmVyZW50IGVmZmVjdHMuCgpZb3UgbWVhbiAy IGluc3RlYWQgb2YgMz8gSSBqdXN0IHdhbnRlZCB0byBrZWVwIGl0IHVuZGVyIDgwLgoKPiA+ICsg ICAgICAgZm9yIChpID0gMDsgaSA8IHF1ZXJ5X2VuZ2luZS0+bnVtX2VuZ2luZXM7IGkrKykgewo+ ID4gKyAgICAgICAgICAgICAgIGNoYXIgKm5hbWU7Cj4gPiArICAgICAgICAgICAgICAgaW50IGNs YXNzID0gcXVlcnlfZW5naW5lLT5lbmdpbmVzW2ldLmNsYXNzOwo+ID4gKyAgICAgICAgICAgICAg IGludCBpbnN0YW5jZSA9IHF1ZXJ5X2VuZ2luZS0+ZW5naW5lc1tpXS5pbnN0YW5jZTsKPiA+ICsK PiA+ICsgICAgICAgICAgICAgICBpZ3RfYXNzZXJ0KGNsYXNzIDwgQVJSQVlfU0laRShlbmdpbmVf bmFtZXMpICYmIGNsYXNzID49IDApOwo+ID4gKyAgICAgICAgICAgICAgIGlndF9hc3NlcnQoZW5n aW5lX25hbWVzW2NsYXNzXSk7Cj4gPiArCj4gPiArICAgICAgICAgICAgICAgaW50ZWxfYWN0aXZl X2VuZ2luZXMyW2ldLmNsYXNzID0gY2xhc3M7Cj4gPiArICAgICAgICAgICAgICAgaW50ZWxfYWN0 aXZlX2VuZ2luZXMyW2ldLmluc3RhbmNlID0gaW5zdGFuY2U7Cj4gPiArCj4gPiArICAgICAgICAg ICAgICAgaWd0X2Fzc2VydChhc3ByaW50ZigmbmFtZSwgIiVzJWQiLAo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZW5naW5lX25hbWVzW2NsYXNzXSwgaW5zdGFuY2UpID4g MCk7Cj4gPiArICAgICAgICAgICAgICAgaW50ZWxfYWN0aXZlX2VuZ2luZXMyW2ldLm5hbWUgPSBu YW1lOwo+ID4gKyAgICAgICB9Cj4gCj4gKzEgYmVjYXVzZSB5b3Ugd2FudCB0byB0ZXJtaW5hdGUg d2l0aCBhIHNlbnRpbmVsPwo+IAo+IFVzZSBtYWxsb2MgYW5kIG1ha2UgaXQgZXhwbGljaXQuCgpP Sy4KCj4gPiArdm9pZCBpZ3RfcmVxdWlyZV9nZW1fZW5naW5lX2xpc3QoaW50IGZkKQo+ID4gK3sK PiA+ICsgICAgICAgaWd0X3JlcXVpcmVfaW50ZWwoZmQpOwo+IAo+IFJlZHVuZGFudC4KCk9LLgoK VGhhbmtzIGFnYWluLCBDaHJpcyEKCkFuZGkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2