Re: [igt-dev] [RFC PATCH v8 3/5] lib/igt_gt: use for_each_engine2 to loop through engines - Andi Shyti via igt-dev

From: Andi Shyti via igt-dev <igt-dev@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>,
	Andi Shyti <andi@etezian.org>,
	Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [RFC PATCH v8 3/5] lib/igt_gt: use for_each_engine2 to loop through engines
Date: Wed, 13 Feb 2019 03:19:56 +0200	[thread overview]
Message-ID: <20190213011956.GD4740@intel.intel> (raw)
In-Reply-To: <155001699227.13414.2484948947032679048@skylake-alporthouse-com>

Hi Chris,

> > +#define for_each_engine2(fd, ctx, e) \
> > +               for (__set_ctx_engine_map(fd, ctx_id), \
> > +                    e = intel_active_engines2; e->name; e++) \
> > +                       for_if (gem_has_get_set_param() || \
> > +                               gem_has_engine(fd, e->class, e->instance))
> 
> intel_active_engines2 can define e->flags, and then you can just use
> gem_has_ring(fd, e->flags) for both ctx->engines[] and legacy.

Sorry, I haven't understood: 'e' is 'intel_execution_engine2' and
doesn't have flags. Indeed I call it as:

   [...]
   struct intel_execution_engine2 *e2;

   for_each_engine2(fd, ctx_id, e2) {
      /* whatever */
   }

Thanks,
Andi

> That's one for test/gem_query.c, making sure that set_ctx_engine_map()
> is fully iterable by gem_has_ring(fd, id).
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev