From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id D53F56E6BA for ; Wed, 13 Feb 2019 10:20:13 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id b14so1441076edt.6 for ; Wed, 13 Feb 2019 02:20:13 -0800 (PST) Date: Wed, 13 Feb 2019 11:20:09 +0100 From: Daniel Vetter Message-ID: <20190213102009.GJ23159@phenom.ffwll.local> References: <20190212120429.20625-1-daniel.vetter@ffwll.ch> <20190212160212.10015-1-daniel.vetter@ffwll.ch> <154998773467.11832.6635323623359769279@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <154998773467.11832.6635323623359769279@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t] lib: Don't leak children in igt_waitchildren_timeout List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT development , Daniel Vetter List-ID: T24gVHVlLCBGZWIgMTIsIDIwMTkgYXQgMDQ6MDg6NTlQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxOS0wMi0xMiAxNjowMjoxMikKPiA+IElu c3RlYWQgb2YgY2xlYW5pbmcgdXAgdGhlIG1lc3MgaW4gaWd0X2V4aXQgbWFrZSBzdXJlIHdlIGRv bid0IGV2ZW4KPiA+IGxldCBpdCBvdXQgb2YgdGhlIGNvbnRhaW5lci4gU2VlIGFsc28KPiA+IAo+ ID4gY29tbWl0IDc1NDg3NjM3OGQ2YzliMjc3NWU4YzA3YjRkMTZmOTg3OGM1NTk0OWYKPiA+IEF1 dGhvcjogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBEYXRlOiAg IEZyaSBGZWIgMjYgMjI6MTE6MTAgMjAxNiArMDAwMAo+ID4gCj4gPiAgICAgaWd0L2dlbV9zeW5j OiBFbmZvcmNlIGEgdGltZW91dCBvZiAyMHMKPiA+IAo+ID4gd2hpY2ggYWRkZWQgdGhpcyBoZWxw ZXIuCj4gPiAKPiA+IFRvIG1ha2Ugc3VyZSB0aGF0IGV2ZXJ5b25lIGZvbGxvd3MgdGhlIHJ1bGVz LCBhZGQgYW4gYXNzZXJ0Lgo+ID4gCj4gPiBXZSdyZSBrZWVwaW5nIHRoZSBjbGVhbnVwIGNvZGUg YXMgYSBmYWlsc2FmZSwgYW5kIGJlY2F1c2UgaXQgc3BlZWRzCj4gPiB1cCB0aGUgdGVzdGNhc2Ug SSdtIGZvbGxvd2luZyB1cCB3aXRoLgo+ID4gCj4gPiB2MjogQ2hyaXMgcG9pbnRlZCBvdXQgdGhh dCBteSBvcmlnaW5hbCBwYXRjaCBkaWQgbm90aGluZy4gV2hpY2ggSQo+ID4gZGlkbid0IGNhdGNo IGJlY2F1c2UgbXkgdGVzdGNhc2Ugd2FzIGFsc28gYnJva2VuLiBVbmZvcnR1bmF0ZWx5IHRoaXMK PiA+IG1lYW5zIHdlIG5lZWQgdG8gb3BlbiBjb2RlIHBhcnQgb2YgdGhlIHdhaXRpbmcuCj4gPiAK PiA+IHYzOiBUaGUgMm5kIF9faWd0X3dhaXRjaGlsZHJlbigpIGlzbid0IG5lY2Vzc2FyeSwgX19p Z3Rfd2FpdGNoaWxkcmVuCj4gPiByZWNvdmVycyBmcm9tIEVJTlRSIGFscmVhZHkgYW5kIGtlZXBz IHdhaXRpbmcgKENocmlzIFdpbHNvbikuCj4gPiAKPiA+IHY0OiBDaGFuZ2UgdGhlIHRpbWVvdXQg c2lnbmFsIHZzIHdhaXRjaGlsZHJlbiBsb2dpYyB0byBiZSByYWNlLWZyZWUKPiA+IChDaHJpcyku ICBUaGlzIGNoYW5nZXMgdGhlIGV4aXQgY29kZSBmb3IgYSB0aW1lb3V0IGZyb20KPiA+IElHVF9F WElUX0ZBSUxVUkUgdG8gU0lHS0lMTCArIDEyOC4KPiA+IAo+ID4gQ2M6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBsaWIvaWd0X2NvcmUuYyB8 IDMwICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAy NSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvbGli L2lndF9jb3JlLmMgYi9saWIvaWd0X2NvcmUuYwo+ID4gaW5kZXggY2JiZTc5Zjg4MDcwLi41N2Y3 NTc0MjEzMDkgMTAwNjQ0Cj4gPiAtLS0gYS9saWIvaWd0X2NvcmUuYwo+ID4gKysrIGIvbGliL2ln dF9jb3JlLmMKPiA+IEBAIC0xNTI1LDYgKzE1MjUsNyBAQCB2b2lkIGlndF9leGl0KHZvaWQpCj4g PiAgCj4gPiAgICAgICAgIGZvciAoaW50IGMgPSAwOyBjIDwgbnVtX3Rlc3RfY2hpbGRyZW47IGMr KykKPiA+ICAgICAgICAgICAgICAgICBraWxsKHRlc3RfY2hpbGRyZW5bY10sIFNJR0tJTEwpOwo+ ID4gKyAgICAgICBhc3NlcnQoIW51bV90ZXN0X2NoaWxkcmVuKTsKPiA+ICAKPiA+ICAgICAgICAg aWYgKCF0ZXN0X3dpdGhfc3VidGVzdHMpIHsKPiA+ICAgICAgICAgICAgICAgICBzdHJ1Y3QgdGlt ZXNwZWMgbm93Owo+ID4gQEAgLTE4MzIsMjAgKzE4MzMsMzkgQEAgdm9pZCBpZ3Rfd2FpdGNoaWxk cmVuKHZvaWQpCj4gPiAgICAgICAgICAgICAgICAgaWd0X2ZhaWwoZXJyKTsKPiA+ICB9Cj4gPiAg Cj4gPiArc3RhdGljIHZvaWQgaWd0X2FsYXJtX2tpbGxjaGlsZHJlbihpbnQgc2lnbmFsKQo+ID4g K3sKPiA+ICsgICAgICAgaWd0X2luZm8oIlRpbWVkIG91dCB3YWl0aW5nIGZvciBjaGlsZHJlblxu Iik7Cj4gPiArCj4gPiArICAgICAgIGZvciAoaW50IGMgPSAwOyBjIDwgbnVtX3Rlc3RfY2hpbGRy ZW47IGMrKykKPiA+ICsgICAgICAgICAgICAgICBraWxsKHRlc3RfY2hpbGRyZW5bY10sIFNJR0tJ TEwpOwo+ID4gK30KPiA+ICsKPiA+ICAvKioKPiA+ICAgKiBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVv dXQ6Cj4gPiAgICogQHNlY29uZHM6IHRpbWVvdXQgaW4gc2Vjb25kcyB0byB3YWl0Cj4gPiAgICog QHJlYXNvbjogZGVidWcgc3RyaW5nIGV4cGxhaW5pbmcgd2hhdCB0aW1lZG91dAo+ID4gICAqCj4g PiAtICogV2FpdCBmb3IgYWxsIGNoaWxkcmVuIGZvcmtlZCB3aXRoIGlndF9mb3JrLCBmb3IgYSBt YXhpbXVtIG9mIEBzZWNvbmRzLgo+ID4gLSAqCj4gPiAtICogV3JhcHMgaWd0X3dhaXRjaGlsZHJl bigpIGFuZCBpZ3Rfc2V0X3RpbWVvdXQoKQo+ID4gKyAqIFdhaXQgZm9yIGFsbCBjaGlsZHJlbiBm b3JrZWQgd2l0aCBpZ3RfZm9yaywgZm9yIGEgbWF4aW11bSBvZiBAc2Vjb25kcy4gSWYgdGhlCj4g PiArICogdGltZW91dCBleHBpcmVzLCBraWxscyBhbGwgY2hpbGRyZW4gYW5kIGNsZWFucyB0aGVt IHVwLgo+IAo+IC4uLmJlZm9yZSByZXBvcnRpbmcgdGhlIGZhaWwgd2l0aCBpZ3RfZmFpbAo+IAo+ IE9yIHdoYXRldmVyIGlzIHRoZSBjb21tb24gbGFuZ3VhZ2UgZm9yIGhpdHRpbmcgaWd0X2ZhaWwo KS4gQXMgaXQgc3RhbmRzLAo+IGl0IHNvdW5kcyBsaWtlIGl0IHNob3VsZCBncmFjZWZ1bGx5IGNs ZWFuIHVwIGFuZCByZXR1cm4gY29udHJvbCBvbgo+IHRpbWVvdXQuCgpZZWFoLCBjbGFyaWZpZWQu Cj4gCj4gPiAgICovCj4gPiAgdm9pZCBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQoaW50IHNlY29u ZHMsIGNvbnN0IGNoYXIgKnJlYXNvbikKPiA+ICB7Cj4gPiAtICAgICAgIGlndF9zZXRfdGltZW91 dChzZWNvbmRzLCByZWFzb24pOwo+ID4gLSAgICAgICBpZ3Rfd2FpdGNoaWxkcmVuKCk7Cj4gPiAr ICAgICAgIHN0cnVjdCBzaWdhY3Rpb24gc2E7Cj4gPiArICAgICAgIGludCByZXQ7Cj4gPiArCj4g PiArICAgICAgIHNhLnNhX2hhbmRsZXIgPSBpZ3RfYWxhcm1fa2lsbGNoaWxkcmVuOwo+ID4gKyAg ICAgICBzaWdlbXB0eXNldCgmc2Euc2FfbWFzayk7Cj4gPiArICAgICAgIHNhLnNhX2ZsYWdzID0g MDsKPiAKPiAJc3RydWN0IHNpZ2FjdGlvbiBzYSA9IHsgLnNhX2hhbmRsZXIgPSBpZ3RfYWxhcm1f a2lsbGNoaWxkcmVuIH07Cj4gPwoKSW4gdXNlcnNwYWNlIEknbSBtdWNoIGxlc3MgYWdncmVzc2l2 ZSB3aXRoIGFzc3VtZSBjbGVhcmluZyB0byAwIGlzIHRoZQpyaWdodCBkZWZhdWx0LCB1bmxpa2Ug a2VybmVsIGFuZCBremFsbG9jLiBJIGd1ZXNzIHNpZ2VtcHR5c2V0IGlzbid0CmFueXRoaW5nIGJ1 dCBjbGVhcmluZyBhbnl3aGVyZSB3ZSBldmVuIHJlbW90ZWx5IGNhcmUgYWJvdXQsIGJ1dCBwb3Np eCBpcwpmdW4uIEl0J3MgYWxzbyBvcGVuLWNvZGVkIGluIHRoZSBvdGhlciBwbGFjZXMsIHNvIEkg dGhpbmsgSSdsbCBsZWF2ZSBpdC4KPiAKPiA+ICsKPiA+ICsgICAgICAgc2lnYWN0aW9uKFNJR0FM Uk0sICZzYSwgTlVMTCk7Cj4gPiArCj4gPiArICAgICAgIGFsYXJtKHNlY29uZHMpOwo+ID4gKwo+ ID4gKyAgICAgICByZXQgPSBfX2lndF93YWl0Y2hpbGRyZW4oKTsKPiA+ICAgICAgICAgaWd0X3Jl c2V0X3RpbWVvdXQoKTsKPiA+ICsgICAgICAgaWYgKHJldCkKPiA+ICsgICAgICAgICAgICAgICBp Z3RfZmFpbChyZXQpOwo+IAo+IExndG0sCj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hy aXNAY2hyaXMtd2lsc29uLmNvLnVrPgoKVGhhbmtzIGZvciByZXZpZXdpbmcsIHdpbGwgcmVzcGlu IHRoZSBlbnRpcmUgc2VyaWVzLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlz dAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=