From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 710146E37F for ; Thu, 14 Feb 2019 08:33:06 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id b17so4312562eds.2 for ; Thu, 14 Feb 2019 00:33:06 -0800 (PST) Date: Thu, 14 Feb 2019 09:33:02 +0100 From: Daniel Vetter Message-ID: <20190214083302.GR23159@phenom.ffwll.local> References: <20190213161817.18758-1-stanislav.lisovskiy@intel.com> <20190213204131.GM23159@phenom.ffwll.local> <778d2d33955949b984a922585f53dd144d7bb673.camel@intel.com> <20190214082542.GQ23159@phenom.ffwll.local> <729d50520419f53ae843ac495ad467948935b29c.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <729d50520419f53ae843ac495ad467948935b29c.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] igt/tests: Fix error checking in kms_atomic_transition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Lisovskiy, Stanislav" Cc: "igt-dev@lists.freedesktop.org" , "juhapekka.heikkila@intel.com" , "Syrjala, Ville" , "Peres, Martin" , "daniel@ffwll.ch" List-ID: T24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMDg6MzE6NTJBTSArMDAwMCwgTGlzb3Zza2l5LCBTdGFu aXNsYXYgd3JvdGU6Cj4gT24gVGh1LCAyMDE5LTAyLTE0IGF0IDA5OjI1ICswMTAwLCBEYW5pZWwg VmV0dGVyIHdyb3RlOgo+ID4gT24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMDg6MjI6MjlBTSArMDAw MCwgTGlzb3Zza2l5LCBTdGFuaXNsYXYgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgMjAxOS0wMi0xMyBh dCAyMTo0MSArMDEwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gPiBPbiBXZWQsIEZlYiAx MywgMjAxOSBhdCAwNjoxODoxN1BNICswMjAwLCBTdGFuaXNsYXYgTGlzb3Zza2l5IHZpYQo+ID4g PiA+IGlndC1kZXYgd3JvdGU6Cj4gPiA+ID4gPiBUaGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCBl cnJvciByZXR1cm4gdmFsdWUgd2lsbCBiZQo+ID4gPiA+ID4gYWx3YXlzIEVJTlZBTCwgbWFkZSBh IGNoZWNrIG1vcmUgZ2VuZXJhbCBhcyBpdCBjYW4gYmUKPiA+ID4gPiA+IEVSQU5HRSwgRU5PU1BD LCBFSU5WQUwgYW5kIHByb2JhYmx5IG90aGVycywgd2hpY2ggYWxsCj4gPiA+ID4gPiBtZWFuIHRo ZSBzYW1lIGluIGNvbnRleHQgb2YgdGhpcyB0ZXN0IGNhc2U6IGkuZSB0aGlzIHNwcml0ZQo+ID4g PiA+ID4gc2l6ZSBpcyBub3QgdmFsaWQuCj4gPiA+ID4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdz LmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MjI1Cj4gPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBTdGFuaXNsYXYgTGlzb3Zza2l5IDxzdGFuaXNsYXYubGlzb3Zza2l5QGludGVsLmMK PiA+ID4gPiA+IG9tPgo+ID4gPiA+IAo+ID4gPiA+IEtlcm5lbCBhdG9taWMgc3BlYyBpcyBwcmV0 dHkgY2xlYXIgdGhhdCBpdCdzIGVpdGhlciBFSU5WQUwgb3IKPiA+ID4gPiBFUkFOR0UsCj4gPiA+ ID4gYW5kCj4gPiA+ID4gbm90aGluZyBlbHNlLiBJbiB0aGUgZG9jcyB3ZSBldmVuIGxpbWl0IHRv IEVJTlZBTCAoc2Nyb2xsIGRvd24gdG8KPiA+ID4gPiBhdG9taWNfY2hlY2spOgo+ID4gPiA+IAo+ ID4gPiA+IGh0dHBzOi8vZHJpLmZyZWVkZXNrdG9wLm9yZy9kb2NzL2RybS9ncHUvZHJtLWttcy5o dG1sP2hpZ2hsaWdodD1kCj4gPiA+ID4gcm1fbQo+ID4gPiA+IG9kZV9jb25maWdfZnVuY3MjYy5k cm1fbW9kZV9jb25maWdfZnVuY3MKPiA+ID4gPiAKPiA+ID4gPiBXb3VsZCBiZSBncmVhdCBpZiB5 b3UgY2FuIHN1Ym1pdCBhIGtlcm5lbCBwYXRjaCB0byBhZGQgdGhlCj4gPiA+ID4gRVJBTkdFLgo+ ID4gPiA+IEFuZAo+ID4gPiA+IGNoYW5nZSB0aGlzIG9uZSBoZXJlIHRvIG9ubHkgYWNjZXB0IEVS QU5HRSBhbmQgRUlOVkFMIGFzICJzcHJpdGUKPiA+ID4gPiBkb2Vzbid0Cj4gPiA+ID4gd29yayIu Cj4gPiA+IAo+ID4gPiBVbmZvcnR1bmF0ZWx5LCBpbiByZWFsaXR5IGl0IGlzIG5vdCBsaWtlIHRo YXQuIFdlIGhhdmUgYSBidWcKPiA+ID4gZmRvIzEwOTIyNSwgd2hlcmUgaXQgcmV0dXJucyBFTk9T UEMuIERSTSBkb2VzIHRoaXMgd2hlbiBwbGFuZSBzaXplCj4gPiA+IGV4Y2VlZHMgdGhlIGZyYW1l YnVmZmVyIHNpemUoY2hlY2sgZHJtX2F0b21pYy5jLAo+ID4gPiBkcm1fYXRvbWljX3BsYW5lX2No ZWNrKS4gCj4gPiA+IFdlIGhpdCB0aGlzIGlzc3VlIHdoZW4gd2UgaGFwcGVuIHRvIGhhdmUgcmVz b2x1dGlvbiBsb3dlciB0aGFuCj4gPiA+IGV4cGVjdGVkCj4gPiA+IGJ5IElHVCwgc28gd2UgYWN0 dWFsbHkgY3JlYXRlIGEgZnJhbWVidWZmZXIgb2Ygc21hbGxlciBzaXplIHRoYW4gaXQKPiA+ID4g c2V0cyBmb3IgdGhlIHBsYW5lIGFuZCB0aGVuIHdlCj4gPiA+IGhpdCBFTk9TUEMgaW5zdGVhZCBF SU5WQUwsIHdoaWNoIGlzIHRyZWF0ZWQgbm93IGFzIE9LIGJ5IHRoZSB0ZXN0Cj4gPiA+IGNhc2Uu Cj4gPiA+IFNvIGFkZGluZyBFUkFOR0Ugd2lsbCBub3QgaGVscCBmb3IgdGhpcyBidWcuIAo+ID4g PiBFaXRoZXIgSSBzaG91bGQgYWRkIGFsbCB0aHJlZSB0byBJR1QoRVJBTkdFLCBFTk9TUEMsIEVJ TlZBTCkgb3IgZml4Cj4gPiA+IGl0Cj4gPiA+IGluIHRoZSBrZXJuZWwsIHNvIHRoYXQgaXQgcmV0 dXJucyBFSU5WQUwgaW5zdGVhZCBvZiBFTk9TUEMuCj4gPiAKPiA+IEhtIHllYWgsIHBscyBkbywg YW5kIHBscyBkbyB1cGRhdGUgdGhlIGtlcm5lbCBkb2N1bWVudGF0aW9uLiBJJ20gYWxzbwo+ID4g d29uZGVyaW5nIHdoZXRoZXIgd2Ugc2hvdWxkbid0IHdyYXAgc29tZSBjaGVja3MgYXJvdW5kIGNh bGxzIHRvCj4gPiBhdG9taWNfY2hlY2sgaW4gdGhlIGtlcm5lbCBmb3IgdGhpcy4KPiA+IC1EYW5p ZWwKPiAKPiBTbyBkbyB5b3UgbWVhbiBJIHNob3VsZCBmaXggdGhlIGtlcm5lbCBvciBpZ3Q/IDop CgpPb3BzIDotKSBJIG1lYW50IHRvIGZpeCB0aGUgaWd0IGxvZ2ljIHRvIGFsc28gYWNjZXB0IEVO T1NQQyBhbmQgRUlOVkFMLApwbHVzIHVwZGF0ZSB0aGUga2VybmVsJ3MgZG9jdW1lbnRhdGlvbiBz byB0aGF0IGRvY3MgcmVmbGVjdCByZWFsaXR5LgotRGFuaWVsCgo+IAo+ID4gCj4gPiA+IAo+ID4g PiA+IC1EYW5pZWwKPiA+ID4gPiAKPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIHRlc3RzL2ttc19h dG9taWNfdHJhbnNpdGlvbi5jIHwgNCArKy0tCj4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPiA+IAo+ID4gPiA+ID4gZGlmZiAt LWdpdCBhL3Rlc3RzL2ttc19hdG9taWNfdHJhbnNpdGlvbi5jCj4gPiA+ID4gPiBiL3Rlc3RzL2tt c19hdG9taWNfdHJhbnNpdGlvbi5jCj4gPiA+ID4gPiBpbmRleCBlYzVkMjVkZS4uNThiZjYyODAg MTAwNjQ0Cj4gPiA+ID4gPiAtLS0gYS90ZXN0cy9rbXNfYXRvbWljX3RyYW5zaXRpb24uYwo+ID4g PiA+ID4gKysrIGIvdGVzdHMva21zX2F0b21pY190cmFuc2l0aW9uLmMKPiA+ID4gPiA+IEBAIC0y ODIsNyArMjgyLDcgQEAgcmV0cnk6Cj4gPiA+ID4gPiAgCQl3bV9zZXR1cF9wbGFuZShkaXNwbGF5 LCBwaXBlLCAoMSA8PCBuX3BsYW5lcykKPiA+ID4gPiA+IC0gMSwKPiA+ID4gPiA+IHBhcm1zLCBm YWxzZSk7Cj4gPiA+ID4gPiAgCQlyZXQgPSBpZ3RfZGlzcGxheV90cnlfY29tbWl0X2F0b21pYyhk aXNwbGF5LAo+ID4gPiA+ID4gRFJNX01PREVfQVRPTUlDX1RFU1RfT05MWSB8IERSTV9NT0RFX0FU T01JQ19BTExPV19NT0RFU0VULAo+ID4gPiA+ID4gTlVMTCk7Cj4gPiA+ID4gPiAgCj4gPiA+ID4g PiAtCQlpZiAocmV0ID09IC1FSU5WQUwpIHsKPiA+ID4gPiA+ICsJCWlmIChyZXQgIT0gMCkgewo+ ID4gPiA+ID4gIAkJCWlmIChjdXJzb3Jfd2lkdGggPT0gc3ByaXRlX3dpZHRoICYmCj4gPiA+ID4g PiAgCQkJICAgIGN1cnNvcl9oZWlnaHQgPT0gc3ByaXRlX2hlaWdodCkgewo+ID4gPiA+ID4gIAkJ CQlpZ3RfYXNzZXJ0X2YoYWxwaGEsCj4gPiA+ID4gPiBAQCAtNDcyLDcgKzQ3Miw3IEBAIHJ1bl90 cmFuc2l0aW9uX3Rlc3QoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSwKPiA+ID4gPiA+IGVudW0gcGlw ZSBwaXBlLCBpZ3Rfb3V0cHV0X3QgKm91dHB1dAo+ID4gPiA+ID4gIAkJCWlndF9waXBlX3JlcXVl c3Rfb3V0X2ZlbmNlKHBpcGVfb2JqKTsKPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICAJCXJldCA9IGln dF9kaXNwbGF5X3RyeV9jb21taXRfYXRvbWljKGRpc3BsYXksCj4gPiA+ID4gPiBEUk1fTU9ERV9B VE9NSUNfVEVTVF9PTkxZIHwgRFJNX01PREVfQVRPTUlDX0FMTE9XX01PREVTRVQsCj4gPiA+ID4g PiBOVUxMKTsKPiA+ID4gPiA+IC0JCWlmIChyZXQgIT0gLUVJTlZBTCB8fCBwaXBlX29iai0+bl9w bGFuZXMgPCAzKQo+ID4gPiA+ID4gKwkJaWYgKHJldCA9PSAwIHx8IHBpcGVfb2JqLT5uX3BsYW5l cyA8IDMpCj4gPiA+ID4gPiAgCQkJYnJlYWs7Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAgCQlyZXQg PSAwOwo+ID4gPiA+ID4gLS0gCj4gPiA+ID4gPiAyLjE3LjEKPiA+ID4gPiA+IAo+ID4gPiA+ID4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiA+ IGlndC1kZXYgbWFpbGluZyBsaXN0Cj4gPiA+ID4gPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4gPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pZ3QtZGV2Cj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+IAo+ID4gPiAtLSAKPiA+ID4gQmVz dCBSZWdhcmRzLAo+ID4gPiAKPiA+ID4gTGlzb3Zza2l5IFN0YW5pc2xhdgo+ID4gCj4gPiAKPiAt LSAKPiBCZXN0IFJlZ2FyZHMsCj4gCj4gTGlzb3Zza2l5IFN0YW5pc2xhdgoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmln dC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==